From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2C65C433ED for ; Thu, 29 Apr 2021 09:50:43 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0D96361445 for ; Thu, 29 Apr 2021 09:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0D96361445 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FGyJaDQ7oBSPwJW8CKUDQS4UTsqEzdW2SpI7q43BXN0=; b=Vww7ZD6BCpSUVic05iDHiiqSP iVA2b6VjbIZyOiD93di7Gw9O1EpxfFlXhPbk8KvtPrsj4Kh6C3Z3ZAjcLtX3NdPaJ307TfKYkBZaO 3tnw/cXEQe7KDXJk6YJN/jS+Oa1XlQYVXaz95j8FZahVEbpZIghaebOe8SGJMkrrnJYSAgOdemZMn fVpXhRGn/LIkha5NTkx/0yuc5ZIvM3PcizxihDt2ZwfPDq0tBjeJibNVuF3NLpgMxswgdqrd9KKZF KZzeThf0/VkvC73EdojvHcXzLXdocpGkqhaVG8mXnqAQhM2zabzBHtqzv1wceR5AdAbLeEIJtrURN 3/Q+WVe0A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lc3Hz-005SK8-RJ; Thu, 29 Apr 2021 09:48:56 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc3Hw-005SJp-Tf for linux-arm-kernel@desiato.infradead.org; Thu, 29 Apr 2021 09:48:53 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=KXl/c74AMpKZXf8ydn6vhU4c7o1h7zu3c9c3XPNN9ek=; b=T/hX0S9n4GMzNWHHH9iQZ1mKA6 VNbIEYz3P7p8T4L1Hib4P6VtYJUP1PCfFOKLEnl7jCNTK44L/glZiXrTRoDOilbawMJsG+a0/qs2d yl/u7wECG0ii9F1NG36xy0Y1ErYbnjmpTdZaa7pZvogbzKbDIVQ2XdGlRcvWmcKTFcOiszoxpXCNA svOxcH4gxyBts8iHp9wQH76MI3Ypts+cswFLTxqwIu4ws170JfZh74khShfkimYQkDvuRMXEzSOeS o7c+JD9yp9yjX6RzBC0dl0H2OozD4SBVQpmTI6FR98o9RBYCYzBGf6RUNLgKC5OsyBjrl4K588YNj uquoenuA==; Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lc3Ht-000XAN-0c for linux-arm-kernel@lists.infradead.org; Thu, 29 Apr 2021 09:48:51 +0000 Received: by mail-pg1-x52c.google.com with SMTP id z16so5828421pga.1 for ; Thu, 29 Apr 2021 02:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KXl/c74AMpKZXf8ydn6vhU4c7o1h7zu3c9c3XPNN9ek=; b=MTtt/Nicd8OEciv2xT9CmfzHqdDuyn2e7nw6RCCov0FN+FuL6ZrpUU1iNfUnfkzACI yV5s+FdSe1EQHnbHvrtfQgsOkZNTyP6ByTU9E4c3oHTh7DZQobLVNJQ+N8mt9HjwEIfb ihygcHtmq7qJHu+Hb6AfBkw8jqR7O9vDtT9hpu8CpUkUBTUQcMMU12ShyVh54+qUUbI3 U6p3r707ZfnMkXhWxrV/90dFSn8Q7x2M28gQE2qMtDs5b9sBXOFPEluCYf6u3mXWP5RM op/bjC3M4hxqnPL1q7JHz7CJxHxS473+sYWDVaJaqhQ4zDMbsI0VZCcg1TyDi0HPCUU5 qrWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KXl/c74AMpKZXf8ydn6vhU4c7o1h7zu3c9c3XPNN9ek=; b=VyqmeBtTDQRzB1gSW8UsuRki+BUyKw16nuV0MkeDh32BAp5exizkHf7sYp+fJMJAWu 553jypijV2XobPDo6XNuK0KvtmHA2qk0nJ4uel7IdmU3WmPaBpBNpQ/aq1sV5baNaFek /68QHpvO8kulOJgAWivTGt8JU1eSUD20toyAod45+j0wlCYFl+TQFd/Cx83avHCW4yH4 7d1kKOnqfNTXIo26OBlgOaO4cGK0yf6QZE5Hsio4RZJ/wdkUyNO02FmMUnkbNsKN1Sww wFYo3CyPVgTAwWFMM9PRPl9zOWS2nVMMKJuZ2qVEJ2jwLxmX46E7GbI8vwgbj05AvbUN xl0Q== X-Gm-Message-State: AOAM532irVtFwo5dWfgyheqPv+zk2gjkPu+VpFS/bRso25qNGKuQNvgK zwaneStLlYKiXf7ZENUSbogaTwHUpuySpJZbsWc= X-Google-Smtp-Source: ABdhPJyGi2Wa7Ag0E7GFaCLYcJrAxeJPaiDV0C27TjkJJDFI5x1CFRltip91H/u+tuBzOeROXtER6XqR6J5gYiqhnkY= X-Received: by 2002:a62:a515:0:b029:263:214f:27ff with SMTP id v21-20020a62a5150000b0290263214f27ffmr32639435pfm.4.1619689727386; Thu, 29 Apr 2021 02:48:47 -0700 (PDT) MIME-Version: 1.0 References: <1618976938-20834-1-git-send-email-dillon.minfei@gmail.com> <1618976938-20834-5-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1618976938-20834-5-git-send-email-dillon.minfei@gmail.com> From: dillon min Date: Thu, 29 Apr 2021 17:48:11 +0800 Message-ID: Subject: Re: [PATCH v4 4/4] media: i2c: ov2659: Use clk_{prepare_enable, disable_unprepare}() to set xvclk on/off To: Fabio Estevam , Shawn Guo , Stefan Riedmueller , Matthias Schiffer , leoyang.li@nxp.com, arnd@arndb.de, olof@lixom.net, Sascha Hauer , kernel@pengutronix.de, prabhakar.csengg@gmail.com, mchehab@kernel.org, mchehab+huawei@kernel.org Cc: Krzysztof Kozlowski , Krzysztof Kozlowski , Rob Herring , Oleksij Rempel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux Kernel Mailing List , Linux ARM , linux-imx@nxp.com, linux-media@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210429_024849_065172_118525C8 X-CRM114-Status: GOOD ( 25.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi All, Just a gentle ping. and loop mchehab+huawei@kernel.org Thanks Best Regards Dillon On Wed, Apr 21, 2021 at 11:49 AM wrote: > > From: dillon min > > On some platform(imx6q), xvclk might not switch on in advance, > also for power save purpose, xvclk should not be always on. > so, add clk_prepare_enable(), clk_disable_unprepare() in driver > side to set xvclk on/off at proper stage. > > Add following changes: > - add 'struct clk *clk;' in 'struct ov2659 {}' > - enable xvclk in ov2659_power_on() > - disable xvclk in ov2659_power_off() > > Signed-off-by: dillon min > --- > v4: no changes > > drivers/media/i2c/ov2659.c | 24 ++++++++++++++++++------ > 1 file changed, 18 insertions(+), 6 deletions(-) > > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > index 42f64175a6df..fb78a1cedc03 100644 > --- a/drivers/media/i2c/ov2659.c > +++ b/drivers/media/i2c/ov2659.c > @@ -204,6 +204,7 @@ struct ov2659 { > struct i2c_client *client; > struct v4l2_ctrl_handler ctrls; > struct v4l2_ctrl *link_frequency; > + struct clk *clk; > const struct ov2659_framesize *frame_size; > struct sensor_register *format_ctrl_regs; > struct ov2659_pll_ctrl pll; > @@ -1270,6 +1271,8 @@ static int ov2659_power_off(struct device *dev) > > gpiod_set_value(ov2659->pwdn_gpio, 1); > > + clk_disable_unprepare(ov2659->clk); > + > return 0; > } > > @@ -1278,9 +1281,17 @@ static int ov2659_power_on(struct device *dev) > struct i2c_client *client = to_i2c_client(dev); > struct v4l2_subdev *sd = i2c_get_clientdata(client); > struct ov2659 *ov2659 = to_ov2659(sd); > + int ret; > > dev_dbg(&client->dev, "%s:\n", __func__); > > + ret = clk_prepare_enable(ov2659->clk); > + if (ret) { > + dev_err(&client->dev, "%s: failed to enable clock\n", > + __func__); > + return ret; > + } > + > gpiod_set_value(ov2659->pwdn_gpio, 0); > > if (ov2659->resetb_gpio) { > @@ -1425,7 +1436,6 @@ static int ov2659_probe(struct i2c_client *client) > const struct ov2659_platform_data *pdata = ov2659_get_pdata(client); > struct v4l2_subdev *sd; > struct ov2659 *ov2659; > - struct clk *clk; > int ret; > > if (!pdata) { > @@ -1440,11 +1450,11 @@ static int ov2659_probe(struct i2c_client *client) > ov2659->pdata = pdata; > ov2659->client = client; > > - clk = devm_clk_get(&client->dev, "xvclk"); > - if (IS_ERR(clk)) > - return PTR_ERR(clk); > + ov2659->clk = devm_clk_get(&client->dev, "xvclk"); > + if (IS_ERR(ov2659->clk)) > + return PTR_ERR(ov2659->clk); > > - ov2659->xvclk_frequency = clk_get_rate(clk); > + ov2659->xvclk_frequency = clk_get_rate(ov2659->clk); > if (ov2659->xvclk_frequency < 6000000 || > ov2659->xvclk_frequency > 27000000) > return -EINVAL; > @@ -1506,7 +1516,9 @@ static int ov2659_probe(struct i2c_client *client) > ov2659->frame_size = &ov2659_framesizes[2]; > ov2659->format_ctrl_regs = ov2659_formats[0].format_ctrl_regs; > > - ov2659_power_on(&client->dev); > + ret = ov2659_power_on(&client->dev); > + if (ret < 0) > + goto error; > > ret = ov2659_detect(sd); > if (ret < 0) > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel