From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA39C433B4 for ; Mon, 3 May 2021 14:14:46 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B2C61155 for ; Mon, 3 May 2021 14:14:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B2C61155 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=vzsb3YT0v0Han8hI6ilB5QtNzgNlpLYFSVGnnNusJG8=; b=JpsI1LIuCYaJncBUX6JSgqopk +1XAcLdJZ4badFwExoczKHnrTLZHXwr237q1KcZ6Cc1yDC/EfsmIOGZv35sa5TP2paOjOLv94B2TZ QH9QL9mqkRCjeSLkv1eZXsDhS/uKPs1OU9LWfg7jiSiN73+/0x3Z8yqcx93C/EDA7s4HvSpjI6LOE +SlPN3879/E/DQTpDruhtkDGFBSgMEFv2s4L/fUuSKy0NzXHXFbN3PwAAGXCSZT9ZyxcYdNhl93PV pvDlZyglz6lKAT+e4D7Qkdvk13mUpyymqX/4VJ3lDpdCfKc9OhpE/M7omdzes9rZVi5onH1qBv06x u9ZrL6u4A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ldZJI-00E1I3-WE; Mon, 03 May 2021 14:12:33 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldZJF-00E1HD-6q for linux-arm-kernel@desiato.infradead.org; Mon, 03 May 2021 14:12:30 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Is7Jnp3BHxwMJZ3xqBnGr8z8FKTgA32vVnaoI/FxVRw=; b=G7u308+M/YEd+9htv/DNvCVZa7 1llFgNQPAmk3/r4sUe4axZAUGVMS9nilHDOHTOWVfpsPhDb0UacLXbP77GsuOuVt2gNFW2Dp9dmbb O1Fzf2vAmDIOwSnVGF+I5fGGb2EtQkFrji0oi0N/u7L7PZ6Eagaeg+KFX3qpnYT3/exIo/WIW1mYD 9RSGayAMKtIzLS7M2JjW08Kg+XFxfMhXRl+ZiE32rkacjnAdjknz298ggsZqWkuYmIjKb7SCeiGqS IrZKlI2OglrmmGbbp0NLmcq/gDDqGhQX87Pij6Fz2Amw1QiTs74KLTpx/ME3P5e3R+hQb77HT3ij2 BhIvtRTQ==; Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ldZJC-0037B9-GA for linux-arm-kernel@lists.infradead.org; Mon, 03 May 2021 14:12:27 +0000 Received: by mail-pj1-x1029.google.com with SMTP id gj14so3154254pjb.5 for ; Mon, 03 May 2021 07:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Is7Jnp3BHxwMJZ3xqBnGr8z8FKTgA32vVnaoI/FxVRw=; b=qP2nfbxnF0v/sj2jLAmEFSVPxwLhwlMF20PXnyLaA9PYe+C/txCz4VB4sw0vfwOQE0 rDBs99GmYLB1gp65xco9ZDUAgbD4sBqcqlrVWe40GS8+8IJPNl9c4oCMsV50AEXrEpOr vjREqcKuBI//GhYbxhXnYH7TVaIqwW0sOXRe79+9xYSKJchowUEEO+MtXUy6kzvVJASh fJP2n0rR6hld6Sz5gMN/DanLOO3w9stPMfCagZRE2pVoeOQd01WhiAZI0J4gtCaSRbRb zbMb/kYUzkrNQcyfuWtwB1dOQFBZ17fc45AXmlpALVvovOKFc/Vph9lo7/Y0CfrY0aMW Ruvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Is7Jnp3BHxwMJZ3xqBnGr8z8FKTgA32vVnaoI/FxVRw=; b=md4TuocAZSwg8qRFaowjkupVd8JttIL5ZQ+k1d6xapUonJGZ3VzjvxeeXPZ/F7uNff X+k+aCdx7rIU4sm4roWEJecAvGmE6ttz8L0KW6JOR+xSYhwSmucvKUG/ev1TfpP6uQwQ VLfX0jBRRjWMHJTP2PyG8g+itBXLrB2Lo1rKckLFGtl7YX3coMBqLB6H0TVxbjfBRWKz lM+neAOW2yN3Mdgle+TXHAJAr1obcPTG9bQnLT3JxrqR00tNTCZ9FxrXcoqa+6b0y1w4 RpAHiFn7sNv1k0JpjjolFiJzAniICSwnyG+4CLZNNR5FPB5QVNEZgsrMerCKp/QnjX+L PdvA== X-Gm-Message-State: AOAM532590ZF+ArtOcy9nQ8o5JwAOu3xHpcp3QOFtOQRaagDhUp04t+p JHsEC4elASzgiziHCAatrpQnBQXJCG1UguWZW5M= X-Google-Smtp-Source: ABdhPJymHtG2UL8qr+SXl+0VKwKjjvxhxPOxDqG7ZGrefDQ+W0Bg/BeS140OYJWVnY4w2zxwZNKvFgq+a2cRhKu/H/A= X-Received: by 2002:a17:90a:dc81:: with SMTP id j1mr21840725pjv.115.1620051143214; Mon, 03 May 2021 07:12:23 -0700 (PDT) MIME-Version: 1.0 References: <1618976938-20834-1-git-send-email-dillon.minfei@gmail.com> <1618976938-20834-5-git-send-email-dillon.minfei@gmail.com> In-Reply-To: From: dillon min Date: Mon, 3 May 2021 22:11:47 +0800 Message-ID: Subject: Re: [PATCH v4 4/4] media: i2c: ov2659: Use clk_{prepare_enable, disable_unprepare}() to set xvclk on/off To: "Lad, Prabhakar" Cc: Fabio Estevam , Shawn Guo , Stefan Riedmueller , Matthias Schiffer , leoyang.li@nxp.com, Arnd Bergmann , Olof Johansson , Sascha Hauer , Sascha Hauer , Mauro Carvalho Chehab , Krzysztof Kozlowski , Krzysztof Kozlowski , Rob Herring , Oleksij Rempel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , LAK , NXP Linux Team , linux-media X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210503_071226_548650_C565915F X-CRM114-Status: GOOD ( 31.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Prabhakar, Thanks for the reminder. On Mon, May 3, 2021 at 8:24 PM Lad, Prabhakar wrote: > > Hi Dillon, > > Thank you for the patch. > > On Wed, Apr 21, 2021 at 4:49 AM wrote: > > > > From: dillon min > > > > On some platform(imx6q), xvclk might not switch on in advance, > > also for power save purpose, xvclk should not be always on. > > so, add clk_prepare_enable(), clk_disable_unprepare() in driver > > side to set xvclk on/off at proper stage. > > > > Add following changes: > > - add 'struct clk *clk;' in 'struct ov2659 {}' > > - enable xvclk in ov2659_power_on() > > - disable xvclk in ov2659_power_off() > > > > Signed-off-by: dillon min > s / dillon min /Dillon Min (unless you prefer in lower case) ? Thanks, I haven't noticed it yet, and will change to a higher case in the next submission. Best regards. Dillon > > > --- > > v4: no changes > > > > drivers/media/i2c/ov2659.c | 24 ++++++++++++++++++------ > > 1 file changed, 18 insertions(+), 6 deletions(-) > > > Acked-by: Lad Prabhakar > > Cheers, > Prabhakar > > > diff --git a/drivers/media/i2c/ov2659.c b/drivers/media/i2c/ov2659.c > > index 42f64175a6df..fb78a1cedc03 100644 > > --- a/drivers/media/i2c/ov2659.c > > +++ b/drivers/media/i2c/ov2659.c > > @@ -204,6 +204,7 @@ struct ov2659 { > > struct i2c_client *client; > > struct v4l2_ctrl_handler ctrls; > > struct v4l2_ctrl *link_frequency; > > + struct clk *clk; > > const struct ov2659_framesize *frame_size; > > struct sensor_register *format_ctrl_regs; > > struct ov2659_pll_ctrl pll; > > @@ -1270,6 +1271,8 @@ static int ov2659_power_off(struct device *dev) > > > > gpiod_set_value(ov2659->pwdn_gpio, 1); > > > > + clk_disable_unprepare(ov2659->clk); > > + > > return 0; > > } > > > > @@ -1278,9 +1281,17 @@ static int ov2659_power_on(struct device *dev) > > struct i2c_client *client = to_i2c_client(dev); > > struct v4l2_subdev *sd = i2c_get_clientdata(client); > > struct ov2659 *ov2659 = to_ov2659(sd); > > + int ret; > > > > dev_dbg(&client->dev, "%s:\n", __func__); > > > > + ret = clk_prepare_enable(ov2659->clk); > > + if (ret) { > > + dev_err(&client->dev, "%s: failed to enable clock\n", > > + __func__); > > + return ret; > > + } > > + > > gpiod_set_value(ov2659->pwdn_gpio, 0); > > > > if (ov2659->resetb_gpio) { > > @@ -1425,7 +1436,6 @@ static int ov2659_probe(struct i2c_client *client) > > const struct ov2659_platform_data *pdata = ov2659_get_pdata(client); > > struct v4l2_subdev *sd; > > struct ov2659 *ov2659; > > - struct clk *clk; > > int ret; > > > > if (!pdata) { > > @@ -1440,11 +1450,11 @@ static int ov2659_probe(struct i2c_client *client) > > ov2659->pdata = pdata; > > ov2659->client = client; > > > > - clk = devm_clk_get(&client->dev, "xvclk"); > > - if (IS_ERR(clk)) > > - return PTR_ERR(clk); > > + ov2659->clk = devm_clk_get(&client->dev, "xvclk"); > > + if (IS_ERR(ov2659->clk)) > > + return PTR_ERR(ov2659->clk); > > > > - ov2659->xvclk_frequency = clk_get_rate(clk); > > + ov2659->xvclk_frequency = clk_get_rate(ov2659->clk); > > if (ov2659->xvclk_frequency < 6000000 || > > ov2659->xvclk_frequency > 27000000) > > return -EINVAL; > > @@ -1506,7 +1516,9 @@ static int ov2659_probe(struct i2c_client *client) > > ov2659->frame_size = &ov2659_framesizes[2]; > > ov2659->format_ctrl_regs = ov2659_formats[0].format_ctrl_regs; > > > > - ov2659_power_on(&client->dev); > > + ret = ov2659_power_on(&client->dev); > > + if (ret < 0) > > + goto error; > > > > ret = ov2659_detect(sd); > > if (ret < 0) > > -- > > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel