From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02FEBC31E5D for ; Tue, 18 Jun 2019 14:18:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AD0B220B1F for ; Tue, 18 Jun 2019 14:18:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jSN1rf9u"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JoDrQk3M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AD0B220B1F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HK7v4NJmqOiOEIwoDwVAmeZSxQWPhhMFnvJ69Fh+gMk=; b=jSN1rf9ueY2jfh N9aBIiWOh9VieTbSi8qtwNdUxkRDlHl8+upWF7dyoW16fg+tBzSvkXi76zemO18E7VCcIKbljBFD2 34iZsaZbpiWUga8W2vC1NSyI5aXP8zx2sojXe3ZsVudr8hE+LXr1mt9ot+12HACrbsKockhtj8iIr 7gAU+ducfNoti0piA951s2AvuHlEQxJA0QVfxJjU/kfSdq6zdGqBcu85+6j8e6A1ZGlkFQZ9D6bPt SuGmC5vrQzE9UTm8QZmnaHTYLXy23ffdegV/Zq5WtX2vMRi9AV7GpUIyUf6ujuSJfeRQ5azL71pSy sxrJHb5cf1WC98/qL9EQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hdEwi-0001AB-IM; Tue, 18 Jun 2019 14:18:48 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hdEwf-00019i-Bh for linux-arm-kernel@lists.infradead.org; Tue, 18 Jun 2019 14:18:46 +0000 Received: from mail-qt1-f180.google.com (mail-qt1-f180.google.com [209.85.160.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED33C20B1F for ; Tue, 18 Jun 2019 14:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1560867525; bh=fmH1HS1i21FXBrdGVVcYis11lRtY96O6Nq7hw7xpuXc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JoDrQk3MgbRvSeO+7rtnkhiCNb09N7doFTHOV7WnAsndUpzx+LxFKG5zn2RpjsgeQ E8wiAS1v58NskYQsv3sgTFHkFapWDgDYH7WE/SoMd4gryGJpNbrOGyIeLHGGkAnMwt FEOhMsVWLZ4cKFsLpkBHVVq21MDiyEMW+ocxBnLQ= Received: by mail-qt1-f180.google.com with SMTP id d23so15513610qto.2 for ; Tue, 18 Jun 2019 07:18:44 -0700 (PDT) X-Gm-Message-State: APjAAAUtgwhJalNXBhjS2hdJu+FJU1/JRk3nO44uANH/VppevI/CJxUZ CiTAg+GmtmHg3ma7pSpcwoUGcZOk0g/3Z7ynNw== X-Google-Smtp-Source: APXvYqxqXrhBkfwz+CkmpI6Dnza5Sqa7IVWFgp1FgSWrNioXxep7UkwWRLPmku5uTgQa9FsH0l163BNzQrHu5CpPAQs= X-Received: by 2002:aed:3f10:: with SMTP id p16mr35442573qtf.110.1560867524199; Tue, 18 Jun 2019 07:18:44 -0700 (PDT) MIME-Version: 1.0 References: <20190614203144.3850-2-joseph.kogut@gmail.com> <20190614235719.8134-1-joseph.kogut@gmail.com> In-Reply-To: From: Rob Herring Date: Tue, 18 Jun 2019 08:18:32 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/2] arm: dts: add ARM Mali GPU node for Odroid XU3 To: Krzysztof Kozlowski , Joseph Kogut X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190618_071845_428174_5240EE30 X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , David Airlie , dri-devel , Kukjin Kim , Daniel Vetter , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 18, 2019 at 3:27 AM Krzysztof Kozlowski wrote: > > On Sat, 15 Jun 2019 at 01:57, Joseph Kogut wrote: > > > > Add device tree node for mali gpu on Odroid XU3 SoCs. > > > > Signed-off-by: Joseph Kogut > > --- > > > > Changes v1 -> v2: > > - Use interrupt name ordering from binding doc > > - Specify a single clock for GPU node > > - Add gpu opp table > > - Fix warnings from IRQ_TYPE_NONE > > > > .../boot/dts/exynos5422-odroidxu3-common.dtsi | 26 +++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > index 93a48f2dda49..b8a4246e3b37 100644 > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3-common.dtsi > > @@ -48,6 +48,32 @@ > > cooling-levels = <0 130 170 230>; > > }; > > > > + gpu: gpu@11800000 { > > + compatible = "samsung,exynos-mali", "arm,mali-t628"; > > + reg = <0x11800000 0x5000>; > > + interrupts = , > > + , > > + ; > > + interrupt-names = "job", "mmu", "gpu"; > > + clocks = <&clock CLK_G3D>; > > + mali-supply = <&buck4_reg>; > > + operating-points-v2 = <&gpu_opp_table>; > > + }; > > + > > + gpu_opp_table: gpu-opp-table { > > One more thing - use "opp_table" as node name (generic class of node, > matches style with other tables). 'opp-table' as convention is using '-' rather than '_'. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel