Re: [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem to json schema

From: Rob Herring <robh@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: devicetree@vger.kernel.org,
	 linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	 Cristian Marussi <cristian.marussi@arm.com>,
	Kevin Hilman <khilman@baylibre.com>,
	 Neil Armstrong <narmstrong@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 1/8] dt-bindings: firmware: arm, scpi: Move arm, scpi-shmem to json schema
Date: Tue, 1 Jun 2021 08:37:57 -0500	[thread overview]
Message-ID: <CAL_Jsq+BGrU5Rb_fso3FK4T_1K+3zFbt_4m5RYAZwLNCGgYn-w@mail.gmail.com> (raw)
In-Reply-To: <20210531082002.spu73u7n35n53lqp@bogus>

On Mon, May 31, 2021 at 3:20 AM Sudeep Holla <sudeep.holla@arm.com> wrote:
>
> On Mon, May 31, 2021 at 09:15:48AM +0100, Sudeep Holla wrote:
> > On Thu, May 27, 2021 at 03:25:54PM -0500, Rob Herring wrote:
> > > On Wed, May 26, 2021 at 07:28:00PM +0100, Sudeep Holla wrote:
> > > > Move the SRAM and shared memory binding for SCPI into the existing
> > > > Generic on-chip SRAM. We just need to update the compatible list and
> > > > there-by remove the whole old text format binding for the same.
> > > >
> > > > Cc: Rob Herring <robh+dt@kernel.org>
> > > > Cc: Kevin Hilman <khilman@baylibre.com>
> > > > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > > > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > > > ---
> > > >  .../devicetree/bindings/arm/arm,scpi.txt          | 15 ---------------
> > > >  Documentation/devicetree/bindings/sram/sram.yaml  |  1 +
> > > >  2 files changed, 1 insertion(+), 15 deletions(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/arm/arm,scpi.txt b/Documentation/devicetree/bindings/arm/arm,scpi.txt
> > > > index bcd6c3ec471e..bcb8b3d61e68 100644
> > > > --- a/Documentation/devicetree/bindings/arm/arm,scpi.txt
> > > > +++ b/Documentation/devicetree/bindings/arm/arm,scpi.txt
> > > > @@ -56,21 +56,6 @@ Sub-nodes
> > > >   node. It can be non linear and hence provide the mapping of identifiers
> > > >   into the clock-output-names array.
> > > >
> > > > -SRAM and Shared Memory for SCPI
> > > > --------------------------------
> > > > -
> > > > -A small area of SRAM is reserved for SCPI communication between application
> > > > -processors and SCP.
> > > > -
> > > > -The properties should follow the generic mmio-sram description found in [3]
> > > > -
> > > > -Each sub-node represents the reserved area for SCPI.
> > > > -
> > > > -Required sub-node properties:
> > > > -- reg : The base offset and size of the reserved area with the SRAM
> > > > -- compatible : should be "arm,scp-shmem" for Non-secure SRAM based
> > >
> > > > +            - arm,scpi-shmem
> > >
> > > Which is correct? There's not a single other occurrance in the kernel
> > > tree of either.
> > >
> >
> > Right I was thinking removing it but wasn't sure if any downstream DTS
> > have used this as it has been in the binding for a while now.
> >
>
> Sent it too early before I completed, we don't have explicit check for
> these compatible in the code. We just use phandles directly.

But which one is correct? "arm,scp-shmem" or "arm,scpi-shmem"

I can fix up when applying.

Rob

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel