From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B406AC433F5 for ; Thu, 2 Dec 2021 20:46:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=PU7meuu1TrNTbxR0X0iEoVHDhCuSl9gsuwvznMQDb2A=; b=aTRurf1GGDTOWU Rt3Ipf9h0ArMQs8gwjQbehyWW4pBvp7v4bkaAelL4/7WhwjyylGR2AZCh3fKwqyK6XqewoCGScyYi sZPTD24kC83IEVsoCyCdsdAqfPubb+Fz4vsx5lORrUpNUBrWug0pANPFir6bGxI/jbXNGoaEiVs+Y PvfZsQahATtqD22dpvA3UxnyWwdRemNAW2BbLrXl8HxIngrQzy4SrUzzQdHIAcFJGdu1xy5WiQUAM ihfaifqXNLQ8AULkL3f+UgBCRk+QbrvTtahMf/6rALZ2h2ptDf3absOjgMRTJjlkQWPcpMIgSH4lV /TxeC0RJL/BJWtuX9EWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msswc-00DQYn-K8; Thu, 02 Dec 2021 20:44:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msswY-00DQYU-HD for linux-arm-kernel@lists.infradead.org; Thu, 02 Dec 2021 20:44:40 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 140D8627F6 for ; Thu, 2 Dec 2021 20:44:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7FC13C53FD3 for ; Thu, 2 Dec 2021 20:44:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1638477877; bh=D+XIVtJBMJs6vJlJVkfubqTw2gl+Mh7CJ9ZRrFKA0R4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hiHyCQ1237rTv8Tp6276FGKCYm3JCk6Ml5zsrxqfAXeGJnuDaKMDQnVTeCNEZ7870 Gnkgx7FG3lxMdmu+ndqjYmhw5GJRY/M8Kr3T3qMnfHXQUR+m8iiXdpsIF1YI2sQjve pjTNZziNRSNXti7JgKMutTGlyeSc+6yUHZl9FL/5LiZltOny0oZxUflB1oAYjGQesb D4uH6VXNWpDsWNLnfddncksvWOXxSh7i8KLfeh+GmVm3hjK8KFs5BuhaTjhFeEbFYs rCIn5SDcCqJ+tYLV0ZPDXMGe0RsiQQ9UNry92rgEmnFPMuWCP36JHaujE2C6ICdHuk Z7h4AY8tDFmJA== Received: by mail-ed1-f52.google.com with SMTP id y13so2768620edd.13 for ; Thu, 02 Dec 2021 12:44:37 -0800 (PST) X-Gm-Message-State: AOAM5315+VAma9YcsLTgeXdQzKJKWmo+BKY943u3ijtXV50ysJhLk/vr 1QGRtF7fjflaVMvJGD7lzLj3cQKsKXRx0L8Fnw== X-Google-Smtp-Source: ABdhPJyzThOhhiZuR6ye1HIiOYkJBH+7pZpAES4RrvIAKS54c2WOOBHFZcf0F8jp2b9OzH5zBx/GUv/DYwgH126mvgg= X-Received: by 2002:a17:906:bccc:: with SMTP id lw12mr17641007ejb.128.1638477875718; Thu, 02 Dec 2021 12:44:35 -0800 (PST) MIME-Version: 1.0 References: <20211130111325.29328-1-semen.protsenko@linaro.org> <20211130111325.29328-2-semen.protsenko@linaro.org> <1638294184.179325.2713642.nullmailer@robh.at.kernel.org> <4b5bebb0-ed74-8132-1e6b-cb7cbc21439c@canonical.com> In-Reply-To: From: Rob Herring Date: Thu, 2 Dec 2021 14:44:24 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 RESEND 1/5] dt-bindings: soc: samsung: Add Exynos USI bindings To: Sam Protsenko Cc: Krzysztof Kozlowski , Jiri Slaby , linux-samsung-soc@vger.kernel.org, Greg Kroah-Hartman , Chanho Park , linux-serial@vger.kernel.org, Youngmin Nam , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, David Virag , Jaewon Kim , linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211202_124438_690294_44E92B4B X-CRM114-Status: GOOD ( 38.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 2, 2021 at 5:01 AM Sam Protsenko wrote: > > On Wed, 1 Dec 2021 at 18:20, Rob Herring wrote: > > > > On Tue, Nov 30, 2021 at 2:04 PM Krzysztof Kozlowski > > wrote: > > > > > > On 30/11/2021 18:43, Rob Herring wrote: > > > > On Tue, 30 Nov 2021 13:13:21 +0200, Sam Protsenko wrote: > > > >> Add constants for choosing USIv2 configuration mode in device tree. > > > >> Those are further used in USI driver to figure out which value to write > > > >> into SW_CONF register. Also document USIv2 IP-core bindings. > > > >> > > > >> Signed-off-by: Sam Protsenko > > > >> --- > > > >> Changes in v2: > > > >> - Combined dt-bindings doc and dt-bindings header patches > > > >> - Added i2c node to example in bindings doc > > > >> - Added mentioning of shared internal circuits > > > >> - Added USI_V2_NONE value to bindings header > > > >> > > > >> .../bindings/soc/samsung/exynos-usi.yaml | 135 ++++++++++++++++++ > > > >> include/dt-bindings/soc/samsung,exynos-usi.h | 17 +++ > > > >> 2 files changed, 152 insertions(+) > > > >> create mode 100644 Documentation/devicetree/bindings/soc/samsung/exynos-usi.yaml > > > >> create mode 100644 include/dt-bindings/soc/samsung,exynos-usi.h > > > >> > > > > > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > > > > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > > > > > > > yamllint warnings/errors: > > > > > > > > dtschema/dtc warnings/errors: > > > > Documentation/devicetree/bindings/soc/samsung/exynos-usi.example.dts:35.39-42.15: Warning (unique_unit_address): /example-0/usi@138200c0/serial@13820000: duplicate unit-address (also used in node /example-0/usi@138200c0/i2c@13820000) > > > > > > Rob, > > > > > > The checker complains about two nodes with same unit-address, even > > > though the node name is different. Does it mean that our idea of > > > embedding two children in USI and having enabled only one (used one) is > > > wrong? > > > > IIRC, we allow for this exact scenario, and there was a change in dtc > > for it. So I'm not sure why this triggered. > > > > It's triggered from WARNING(unique_unit_address, ...), because it > calls static void check_unique_unit_address_common() function with > disable_check=false. I guess we should interpret that this way: the > warning makes sense in regular case, when having the same unit address > for two nodes is wrong. So the warning is reasonable, it's just not > relevant in this particular case. What can be done: > > 1. We can introduce some specific property to mark nodes with > duplicated address as intentional. check_unique_unit_address_common() > can be extended then to omit checking the nodes if that property is > present. > 2. We can just ignore that warning in this particular case (and > similar cases). > 3. We can add some disambiguation note to that warning message, like > "if it's intentional -- please ignore this message" > > I'm all for option (3), as it's the easiest one, and still reasonable. > Rob, what do you think? Can we just ignore that warning in further > versions of this patch series? Just change the dtc flags to '-Wno-unique_unit_address -Wunique_unit_address_if_enabled' for both examples and dtbs. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel