From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D534CC4360C for ; Tue, 8 Oct 2019 14:38:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AB49220659 for ; Tue, 8 Oct 2019 14:38:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Jth+Pqjx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="uHp1KfTN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AB49220659 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xu8Lekp1ae79YdKVyWu29uaBDuCPM1eoSg1afPg5eUk=; b=Jth+PqjxH5n9oQ P1GTA6MQLlL8Lx6nfdu91kreDNzwST7V3lANMHm43nvsjbmR6SEYVGB4P69bvVKSkm9Tad8t2ujNE PHLcw/X54wJXJVMGkfzoIdYW1WDsTPf/Jqm05pYVZfp0CmIZi1/NiO3VfOznudkY6auFHGOA9hiUu cHHH2ILaPuHHVbkryvSj6Y0hImnZYwKlYkNeW/7iyQwNLS5mk4FKmaZxeY2irtRSBoSXDRL8vK6pw nbvBFXK8vSwvo1XYne6pQwX3jYKlAxyF77Yx4ajK1uFhBRzuOGOh4JpOjsuFPq2Ul/vKVSQwqXyHL cjOevSoia0McPFK5PHDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqdD-00076c-IF; Tue, 08 Oct 2019 14:38:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHqdA-00075x-1M for linux-arm-kernel@lists.infradead.org; Tue, 08 Oct 2019 14:38:29 +0000 Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F10E218AC for ; Tue, 8 Oct 2019 14:38:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1570545507; bh=1Q4mMsOb96kylNfFxUq+jNGhofo0vA75cx96BsraELc=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=uHp1KfTNQWDdfSngQbG2a61L+AfiFcIuxX05zWvcMEkTqqrjwkoMahdNpPRCZmhIE tVQ3fNX1NmBrY9KHHIFaQ4zNPuZjGbiRB5ZesilRKdAOxL+BPAI1T/DOb0BmSvVELs 1jc6/vhHbdHTBxIGs2mMmAIIDgK/7nDthGD7t1KQ= Received: by mail-qt1-f175.google.com with SMTP id 3so25666138qta.1 for ; Tue, 08 Oct 2019 07:38:27 -0700 (PDT) X-Gm-Message-State: APjAAAXdhDr9e6M/+R81BeGAIwJaSxpyZxy8EBC3I87YyD+cA34F4Scj x6rXSqQVyPE+bijKKxAqbhADpXWuypXHXBPYQA== X-Google-Smtp-Source: APXvYqyTiDBKsgu4+AG5Pntyh3cdGaf1r6LnkyAMi4aS1suYyJJDpHx4CMSAkGYGBnyIWM7DQIrHIaFzaWMBtTBS7B8= X-Received: by 2002:a05:6214:1590:: with SMTP id m16mr32958286qvw.20.1570545506528; Tue, 08 Oct 2019 07:38:26 -0700 (PDT) MIME-Version: 1.0 References: <20191004151414.8458-1-krzk@kernel.org> <20191008125038.GA2550@pi3> <20191008142900.GA2635@pi3> In-Reply-To: <20191008142900.GA2635@pi3> From: Rob Herring Date: Tue, 8 Oct 2019 09:38:15 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 1/3] dt-bindings: arm: samsung: Force clkoutN names to be unique in PMU To: Krzysztof Kozlowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191008_073828_122299_1004BF87 X-CRM114-Status: GOOD ( 21.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, linux-samsung-soc , Maciej Falkowski , "open list:SERIAL DRIVERS" , David Airlie , Greg Kroah-Hartman , "linux-kernel@vger.kernel.org" , dri-devel , Kukjin Kim , Daniel Vetter , Lee Jones , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 8, 2019 at 9:29 AM Krzysztof Kozlowski wrote: > > On Tue, Oct 08, 2019 at 09:17:16AM -0500, Rob Herring wrote: > > On Tue, Oct 8, 2019 at 9:05 AM Rob Herring wrote: > > > > > > On Tue, Oct 8, 2019 at 7:50 AM Krzysztof Kozlowski wrote: > > > > > > > > On Tue, Oct 08, 2019 at 07:38:14AM -0500, Rob Herring wrote: > > > > > On Fri, Oct 4, 2019 at 10:14 AM Krzysztof Kozlowski wrote: > > > > > > > > > > > > The clkoutN names of clocks must be unique because they represent > > > > > > unique inputs of clock multiplexer. > > > > > > > > > > > > Signed-off-by: Krzysztof Kozlowski > > > > > > --- > > > > > > Documentation/devicetree/bindings/arm/samsung/pmu.yaml | 6 ++++-- > > > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > > index 73b56fc5bf58..d8e03716f5d2 100644 > > > > > > --- a/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > > +++ b/Documentation/devicetree/bindings/arm/samsung/pmu.yaml > > > > > > @@ -53,8 +53,10 @@ properties: > > > > > > List of clock names for particular CLKOUT mux inputs > > > > > > minItems: 1 > > > > > > maxItems: 32 > > > > > > - items: > > > > > > - pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > > + allOf: > > > > > > + - items: > > > > > > + pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > > + - uniqueItems: true > > > > > > > > > > You shouldn't need the 'allOf', just add uniqueItems at the same level as items. > > > > > > > > If you mean something like: > > > > 56 uniqueItems: true > > > > 57 items: > > > > 58 pattern: '^clkout([0-9]|[12][0-9]|3[0-1])$' > > > > > > > > Then the dt_binding_check fails: > > > > > > > > dev/linux/Documentation/devicetree/bindings/arm/samsung/pmu.yaml: properties:clock-names: > > > > 'uniqueItems' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties'] > > > > > > I can add it. > > > > > > The other option is to fix this in the clock schema. I'm not sure if > > > there's a need for duplicate clock-names. Seems unlikely. I'll test > > > that. > > > > Actually, clock-names is already set to be unique. Did you see otherwise? > > Yeah, I duplicated on purpose "clkout1" and it was not reported as an > error. That's why I added "uniqueItems". Are you running using DT_SCHEMA_FILES? If so, you won't get the core schema. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel