From: Rob Herring <robh@kernel.org>
To: "Łukasz Stelmach" <l.stelmach@samsung.com>
Cc: linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/4] scripts/dtc: update fdtget.c to upstream version v1.4.7-57-gf267e674d145
Date: Thu, 30 Jan 2020 08:16:51 -0600 [thread overview]
Message-ID: <CAL_Jsq+Q8ekM8ty33fKAmffTMZ5aZDCbMUPpdup7j=UuggB9Pw@mail.gmail.com> (raw)
In-Reply-To: <20200130124233.4006-1-l.stelmach@samsung.com>
On Thu, Jan 30, 2020 at 6:42 AM Łukasz Stelmach <l.stelmach@samsung.com> wrote:
>
> Build and fdtget and add fdtget.c to the list of update source files.
Why does the kernel need fdtget and why not use the version from your distro?
Please Cc the DT list next time.
> Signed-off-by: Łukasz Stelmach <l.stelmach@samsung.com>
> ---
> scripts/dtc/.gitignore | 4 +
> scripts/dtc/Makefile | 5 ++
> scripts/dtc/fdtget.c | 125 ++++++++++++++++++-------------
> scripts/dtc/update-dtc-source.sh | 4 +-
Separate changes by updates to this script, running the script (to get
fdtget.c), and updates to kernel files.
> 4 files changed, 82 insertions(+), 56 deletions(-)
>
> diff --git scripts/dtc/.gitignore scripts/dtc/.gitignore
> index 2e6e60d64ede..80f6b50fdf77 100644
> --- scripts/dtc/.gitignore
> +++ scripts/dtc/.gitignore
> @@ -1 +1,5 @@
> dtc
> +dtc-lexer.lex.c
> +dtc-parser.tab.c
> +dtc-parser.tab.h
These are needed regardless. Probably a treewide rule for *.lex.c,
*.tab.c, *.tab.h would be better.
> +fdtget
> diff --git scripts/dtc/Makefile scripts/dtc/Makefile
> index b5a5b1c548c9..74322d8dac25 100644
> --- scripts/dtc/Makefile
> +++ scripts/dtc/Makefile
> @@ -2,12 +2,15 @@
> # scripts/dtc makefile
>
> hostprogs-$(CONFIG_DTC) := dtc
> +hostprogs-$(CONFIG_DTC) += fdtget
> always := $(hostprogs-y)
>
> dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
> srcpos.o checks.o util.o
> dtc-objs += dtc-lexer.lex.o dtc-parser.tab.o
>
> +fdtget-objs := fdtget.o util.o
> +
> # Source files need to get at the userspace version of libfdt_env.h to compile
> HOST_EXTRACFLAGS := -I $(srctree)/$(src)/libfdt
>
> @@ -26,5 +29,7 @@ endif
> HOSTCFLAGS_dtc-lexer.lex.o := -I $(srctree)/$(src)
> HOSTCFLAGS_dtc-parser.tab.o := -I $(srctree)/$(src)
>
> +HOSTLDLIBS_fdtget := -L$(obj)/libfdt -lfdt -Wl,-rpath='$$ORIGIN/libfdt'
> +
We never build libfdt as a library, so how does this work unless it
pulls in the distro copy?
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-30 14:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200130124000eucas1p137943be0fe3e5e1eb45e705dc5c46431@eucas1p1.samsung.com>
2020-01-30 12:39 ` [RFC PATCH 0/4] boot/loader: Load kernel directly from firmware Łukasz Stelmach
[not found] ` <CGME20200130124251eucas1p2046004a71a1a9ff4274a6d1d96e2c260@eucas1p2.samsung.com>
2020-01-30 12:42 ` [RFC PATCH 1/4] scripts/dtc: update fdtget.c to upstream version v1.4.7-57-gf267e674d145 Łukasz Stelmach
[not found] ` <CGME20200130124304eucas1p2f3381b1009cd71cd292169d5f10265c1@eucas1p2.samsung.com>
2020-01-30 12:42 ` [RFC PATCH 2/4] scripts: add get_console_base.pl Łukasz Stelmach
[not found] ` <CGME20200130124314eucas1p11a244e77c9c5f583832832313ba93335@eucas1p1.samsung.com>
2020-01-30 12:42 ` [RFC PATCH 3/4] Add tools/hsinit Łukasz Stelmach
[not found] ` <CGME20200130124315eucas1p12d5380c44b68d08ae96849056303e175@eucas1p1.samsung.com>
2020-01-30 12:42 ` [RFC PATCH 4/4] boot/loader: Enable building bootloader replacement for Odroid XU4 Łukasz Stelmach
2020-01-30 12:47 ` [RFC PATCH 1/4] scripts/dtc: update fdtget.c to upstream version v1.4.7-57-gf267e674d145 Russell King - ARM Linux admin
[not found] ` <CGME20200130125530eucas1p282d9749764c3a5c21c85c829d372b650@eucas1p2.samsung.com>
2020-01-30 12:55 ` Łukasz Stelmach
2020-01-30 14:16 ` Rob Herring [this message]
[not found] ` <CGME20200206131712eucas1p15a5c38ac3dc6e05af318a9955a09e013@eucas1p1.samsung.com>
2020-02-06 13:17 ` Łukasz Stelmach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+Q8ekM8ty33fKAmffTMZ5aZDCbMUPpdup7j=UuggB9Pw@mail.gmail.com' \
--to=robh@kernel.org \
--cc=l.stelmach@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).