From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52CE7C433E5 for ; Fri, 10 Jul 2020 20:02:36 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1D5D22075D for ; Fri, 10 Jul 2020 20:02:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZIbQMD/9"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1wPkaE20" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D5D22075D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=F3IAUXKKq1yrJVdA0Lrz8tPKEIdXi2CXHODpx0pFFWY=; b=ZIbQMD/9FwcPAqAuPJONM3xwk XxvFhGOi3/N7Y+O3uJMkbk9tWF7UGc6ZldEhPYPQSoMWji0rSYzEvGvvE4oAOyZ7wpXsMlq2LSwkJ J94FDXkd++oWKP9dEwVQElJr8QjHNxlkrc6oTX988iV056PtOajKH/M/1YGUCsgp/LiY2vHYy4eTD qfO7rP2VoZPJmUOctsLCIGzwd1h3bLLhaOsRaNYa1lOQdtZ7GoqH6vlIAfuHGfxdk8zaKsekEdNJx MzwV3v19dx1GVY+ydFGycXnltQerooV7RshXWQggmCiUYJwLk4v0mlgE7yuvxRBz2liKYcEogHvaj kQWfji1FA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtzCx-0000gU-9L; Fri, 10 Jul 2020 20:01:19 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jtzCu-0000fN-Ke for linux-arm-kernel@lists.infradead.org; Fri, 10 Jul 2020 20:01:17 +0000 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 69A5F207FF for ; Fri, 10 Jul 2020 20:01:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1594411275; bh=uxSaA+fCdlWn4qcPwLruiKx79jbqmYw66ELH749IiaE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1wPkaE20z7plsMQiJwhVZ0+paqUwAPcL9GsKXf1XrgHsHp6QKFd3U0qwNQj1wVKw6 oFM2bYRdanLlb02iDrG6quyLCCI8fDqDyAlcxJYyq5iMV0fXlzOygHrhBaOBnc10fv qOZWzZ3l5FqPvoVBsTQgTCr2YMgP9r32B1WtrAIw= Received: by mail-oi1-f178.google.com with SMTP id l63so5739819oih.13 for ; Fri, 10 Jul 2020 13:01:15 -0700 (PDT) X-Gm-Message-State: AOAM533eTKMQTmWPhHraTvj8ZG8ixSXHkXaF6r2s0x/iO6hTOwBQWSo1 dPitLkJpXmVGfGf5v+gmRrcwttQupEKBXG7Udg== X-Google-Smtp-Source: ABdhPJwp+smXE3Nydu1By4o0JE3KuEQE3LX21t7xmomGltsl4AiTMSJDziZ1tEKIqsf+vYtAAi8lMSlSyNN6DaD306U= X-Received: by 2002:aca:bb82:: with SMTP id l124mr5612171oif.106.1594411274634; Fri, 10 Jul 2020 13:01:14 -0700 (PDT) MIME-Version: 1.0 References: <20200701130129.30961-1-benjamin.gaignard@st.com> <20200701130129.30961-2-benjamin.gaignard@st.com> <20200709203718.GA837160@bogus> <20e4907a-f218-3e43-1111-7d4b9ee6d945@st.com> In-Reply-To: <20e4907a-f218-3e43-1111-7d4b9ee6d945@st.com> From: Rob Herring Date: Fri, 10 Jul 2020 14:01:02 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v7 1/3] dt-bindings: media: stm32-dcmi: Add DCMI min frequency property To: Benjamin GAIGNARD X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200710_160116_800324_87389428 X-CRM114-Status: GOOD ( 22.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "vincent.guittot@linaro.org" , Alexandre TORGUE , "rjw@rjwysocki.net" , "linux-kernel@vger.kernel.org" , "valentin.schneider@arm.com" , "mcoquelin.stm32@gmail.com" , Hugues FRUCHET , "mchehab@kernel.org" , "linux-stm32@st-md-mailman.stormreply.com" , "linux-arm-kernel@lists.infradead.org" , "linux-media@vger.kernel.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 10, 2020 at 1:33 AM Benjamin GAIGNARD wrote: > > > > On 7/9/20 10:37 PM, Rob Herring wrote: > > On Wed, Jul 01, 2020 at 03:01:27PM +0200, Benjamin Gaignard wrote: > >> Document st,stm32-dcmi-min-frequency property which is used to > >> request CPUs minimum frequency when streaming frames. > >> > >> Signed-off-by: Benjamin Gaignard > >> --- > >> Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml | 8 ++++++++ > >> 1 file changed, 8 insertions(+) > >> > >> diff --git a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > >> index 3fe778cb5cc3..05ca85a2411a 100644 > >> --- a/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > >> +++ b/Documentation/devicetree/bindings/media/st,stm32-dcmi.yaml > >> @@ -44,6 +44,13 @@ properties: > >> bindings defined in > >> Documentation/devicetree/bindings/media/video-interfaces.txt. > >> > >> + st,stm32-dcmi-min-frequency: > >> + description: DCMI minimum CPUs frequency requirement (in KHz). > >> + allOf: > >> + - $ref: /schemas/types.yaml#/definitions/uint32 > >> + - minimum: 0 > >> + - default: 0 > > I think this is questionable to be in DT and if it is, it's something > > that's hardly specific to ST or this block. IIRC, we already have a way > > to specify minimum OPPs. > This binding is only needed on some STM32 SoC when DVFS is activated > with low frequency setting in opp. The value also depends of the targeted > video format and framerate. As those 2 things are not in the DT, then neither should this value be. > It is not an opp because it doesn't define a voltage-current-frequency > combination > but only set a minimum target for the CPUs frequency to guaranty a good > reaction > time when handling IRQs for the sensor. OPPs can be frequency only. This is pretty clearly defining the CPU must Operate at a certain minimum Performance Point. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel