From: Rob Herring <robh+dt@kernel.org>
To: ChiaEn Wu <peterwu.pub@gmail.com>
Cc: pavel@ucw.cz, krzysztof.kozlowski+dt@linaro.org,
matthias.bgg@gmail.com, sre@kernel.org, jic23@kernel.org,
lars@metafoo.de, broonie@kernel.org, mazziesaccount@gmail.com,
andriy.shevchenko@linux.intel.com, chiaen_wu@richtek.com,
alice_chen@richtek.com, cy_huang@richtek.com,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-iio@vger.kernel.org, szunichen@gmail.com,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH v11 1/8] dt-bindings: power: supply: Add MediaTek MT6370 Charger
Date: Mon, 26 Sep 2022 09:52:06 -0500 [thread overview]
Message-ID: <CAL_Jsq+Zkgfq0q_XgpLEjHLPGSuG06L6y5YbzbiberNMWtAuJw@mail.gmail.com> (raw)
In-Reply-To: <9382254831bb6ed8c228398a68896b0e8e61c7c4.1663254344.git.chiaen_wu@richtek.com>
On Thu, Sep 15, 2022 at 4:49 AM ChiaEn Wu <peterwu.pub@gmail.com> wrote:
>
> From: ChiaEn Wu <chiaen_wu@richtek.com>
>
> Add MediaTek MT6370 Charger binding documentation.
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Signed-off-by: ChiaEn Wu <chiaen_wu@richtek.com>
> ---
> v11
> - Add more detailed description of irqs.
> - Adujust the order of irqs
> ---
> .../power/supply/mediatek,mt6370-charger.yaml | 96 ++++++++++++++++++++++
> 1 file changed, 96 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
>
> diff --git a/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> new file mode 100644
> index 0000000..fd491c5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/power/supply/mediatek,mt6370-charger.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT6370 Battery Charger
> +
> +maintainers:
> + - ChiaEn Wu <chiaen_wu@richtek.com>
> +
> +description: |
> + This module is part of the MT6370 MFD device.
> + Provides Battery Charger, Boost for OTG devices and BC1.2 detection.
> +
> +properties:
> + compatible:
> + const: mediatek,mt6370-charger
> +
> + interrupts:
> + description: |
> + Specify what irqs are needed to be handled by MT6370 Charger driver.
> + We need to use the IRQ "MT6370_IRQ_OVPCTRL_UVP_D" to know when USB
> + is plugged in, and then the driver will enable BC1.2 detection.
> + After the hardware of MT6370 completes the BC1.2 detection,
> + IRQ "MT6370_IRQ_ATTACH" will be triggered, and the driver will know
> + the result of BC1.2 detection.
> + When the IRQ "MT6370_IRQ_CHG_MIVR" is triggered, it means that the
> + hardware enters the "Minimum Input Voltage Regulation loop" and
> + a workaround needs to be applied at this time.
> + In summary, "MT6370_IRQ_OVPCTRL_UVP_D", "MT6370_IRQ_ATTACH" and
> + "MT6370_IRQ_CHG_MIVR" are required in this charger driver.
> + items:
> + - description: irq of "USB is plugged in"
> + - description: irq of "BC1.2 is done"
> + - description: irq of "Minimum Input Voltage Regulation loop is active"
> +
> + interrupt-names:
> + items:
> + - const: uvp_d_evt
> + - const: attach_i
> + - const: mivr
Now warning in linux-next:
/builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
charger: interrupt-names:0: 'uvp_d_evt' was expected
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
/builds/robherring/linux-dt/Documentation/devicetree/bindings/mfd/mediatek,mt6370.example.dtb:
charger: interrupt-names:1: 'attach_i' was expected
From schema: /builds/robherring/linux-dt/Documentation/devicetree/bindings/power/supply/mediatek,mt6370-charger.yaml
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-26 14:53 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 9:47 [PATCH v11 0/8] Add MediaTek MT6370 PMIC support ChiaEn Wu
2022-09-15 9:47 ` [PATCH v11 1/8] dt-bindings: power: supply: Add MediaTek MT6370 Charger ChiaEn Wu
2022-09-16 14:18 ` Sebastian Reichel
2022-09-20 16:08 ` Sebastian Reichel
2022-09-26 14:52 ` Rob Herring [this message]
2022-10-01 20:29 ` Sebastian Reichel
2022-09-15 9:47 ` [PATCH v11 2/8] dt-bindings: leds: mt6370: Add MediaTek MT6370 current sink type LED indicator ChiaEn Wu
2022-09-15 9:47 ` [PATCH v11 3/8] dt-bindings: leds: Add MediaTek MT6370 flashlight ChiaEn Wu
2022-09-15 9:47 ` [PATCH v11 4/8] lib: add linear range index macro ChiaEn Wu
2022-09-20 16:12 ` Sebastian Reichel
2022-09-15 9:47 ` [PATCH v11 5/8] iio: adc: mt6370: Add MediaTek MT6370 support ChiaEn Wu
2022-09-15 9:47 ` [PATCH v11 6/8] power: supply: mt6370: Add MediaTek MT6370 charger driver ChiaEn Wu
2022-09-20 16:12 ` Sebastian Reichel
2022-09-15 9:47 ` [PATCH v11 7/8] leds: rgb: mt6370: Add MediaTek MT6370 current sink type LED Indicator support ChiaEn Wu
2022-09-15 9:47 ` [PATCH v11 8/8] leds: flash: mt6370: Add MediaTek MT6370 flashlight support ChiaEn Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_Jsq+Zkgfq0q_XgpLEjHLPGSuG06L6y5YbzbiberNMWtAuJw@mail.gmail.com \
--to=robh+dt@kernel.org \
--cc=alice_chen@richtek.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=chiaen_wu@richtek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=mazziesaccount@gmail.com \
--cc=pavel@ucw.cz \
--cc=peterwu.pub@gmail.com \
--cc=sre@kernel.org \
--cc=szunichen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).