From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D24B8C04AB4 for ; Fri, 17 May 2019 22:23:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C0392166E for ; Fri, 17 May 2019 22:23:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="bSWsu8Xp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="1H8AXHsM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C0392166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MvrAc/iFHdEvE/5PhxG/en3pALUoByQR08BqbtZfl1w=; b=bSWsu8XpJTHc27 GBeCuIPloREJaEu7Qpyffo7R+Kn8VLacJutmGimx/tJHkRvxdTF2tssEdAG37blBETcxL4DGpkWZJ SFCnUzgBZLab2HW1LxAklDbk1cBn7BB2+cEbjozYD1e8Q4njOdw5fhJExENp3Qj1Zq4ehFQLx30wU rESddfxq4h1YRikMBuBGmfVRFfbrJ/KuvyBLkdIx2J/5xvoUv3f7GCS2Eikhljm879ADVo5D3Pzip Z7wMWr6UhRbo5ghqnsLDuNKU5u8uQDgdpoHeURF2yxFmBuxySwxt3prb4ydOjKUYHZBVvEKJZYkQr noZOwsvmJ9qVwSgKxnnw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRlFi-0003H2-3K; Fri, 17 May 2019 22:22:58 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hRlFe-0003GM-4Q; Fri, 17 May 2019 22:22:55 +0000 Received: from mail-qt1-f176.google.com (mail-qt1-f176.google.com [209.85.160.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6DD2221734; Fri, 17 May 2019 22:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1558131773; bh=wy3tUZPJTfjLA6B2iSkaBZEFlBpyvFUKCy44GXr0yjI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=1H8AXHsM/HDg4uE/AoRizeknctHuF4pbibpUykeWsjQrOTs0uwSaNYbA+O6l/2Xs9 Ov6lBU00JS8+Tb8R+N/06VtXt0SHNrz52/TeDKk0D6sLF58BZTsWtnjdtblWRqqJie R2I4HibvqDOpWRkqITAOovENVOXUYTjn/z18L03w= Received: by mail-qt1-f176.google.com with SMTP id a39so9865366qtk.2; Fri, 17 May 2019 15:22:53 -0700 (PDT) X-Gm-Message-State: APjAAAUgI1Cjd//dHdytBYN1z9YtyRZGBuTn+zNba3nVfiQY0E9EQh/k SUW0LArd8kS/vc4qQlOwOBIco2X1Eyd4JzeOCQ== X-Google-Smtp-Source: APXvYqxCG14RTMkHi4AFjCOBJ2jDfMBdP6IR9Yo55aGoXHKbHkWK52ZrzIrGRx1VvIDs46fF56pwC87n9mQ89Qff9Qc= X-Received: by 2002:a0c:f350:: with SMTP id e16mr48812969qvm.72.1558131772630; Fri, 17 May 2019 15:22:52 -0700 (PDT) MIME-Version: 1.0 References: <20190417104511.21514-1-frederic.chen@mediatek.com> <20190417104511.21514-2-frederic.chen@mediatek.com> <20190430011506.GA8514@bogus> <1557238925.11663.21.camel@mtksdccf07> In-Reply-To: From: Rob Herring Date: Fri, 17 May 2019 17:22:41 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH V1 1/6] dt-bindings: mt8183: Add binding for DIP shared memory To: Tomasz Figa X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190517_152254_207902_C667C64E X-CRM114-Status: GOOD ( 33.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Shik Chen , devicetree@vger.kernel.org, =?UTF-8?B?U2VhbiBDaGVuZyAo6YSt5piH5byYKQ==?= , Frederic Chen , =?UTF-8?B?UnlubiBXdSAo5ZCz6IKy5oGpKQ==?= , =?UTF-8?B?Q2hyaXN0aWUgWXUgKOa4uOmbheaDoCk=?= , srv_heupstream , =?UTF-8?B?SG9sbWVzIENoaW91ICjpgrHmjLop?= , suleiman@chromium.org, Jerry-ch Chen , yuzhao@chromium.org, =?UTF-8?B?SnVuZ28gTGluICjmnpfmmI7kv4op?= , Sj Huang , Laurent Pinchart , Hans Verkuil , zwisler@chromium.org, Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , Mauro Carvalho Chehab , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , Linux Media Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 16, 2019 at 1:12 AM Tomasz Figa wrote: > > On Wed, May 15, 2019 at 1:19 AM Rob Herring wrote: > > > > On Tue, May 7, 2019 at 9:22 AM Frederic Chen wrote: > > > > > > Dear Rob, > > > > > > I appreciate your comments. > > > > > > On Mon, 2019-04-29 at 20:15 -0500, Rob Herring wrote: > > > > On Wed, Apr 17, 2019 at 06:45:06PM +0800, Frederic Chen wrote: > > > > > This patch adds the binding for describing the shared memory > > > > > used to exchange configuration and tuning data between the > > > > > co-processor and Digital Image Processing (DIP) unit of the > > > > > camera ISP system on Mediatek SoCs. > > > > > > > > > > Signed-off-by: Frederic Chen > > > > > --- > > > > > .../mediatek,reserve-memory-dip_smem.txt | 45 +++++++++++++++++++ > > > > > 1 file changed, 45 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > new file mode 100644 > > > > > index 000000000000..64c001b476b9 > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/reserved-memory/mediatek,reserve-memory-dip_smem.txt > > > > > @@ -0,0 +1,45 @@ > > > > > +Mediatek DIP Shared Memory binding > > > > > + > > > > > +This binding describes the shared memory, which serves the purpose of > > > > > +describing the shared memory region used to exchange data between Digital > > > > > +Image Processing (DIP) and co-processor in Mediatek SoCs. > > > > > + > > > > > +The co-processor doesn't have the iommu so we need to use the physical > > > > > +address to access the shared buffer in the firmware. > > > > > + > > > > > +The Digital Image Processing (DIP) can access memory through mt8183 IOMMU so > > > > > +it can use dma address to access the memory region. > > > > > +(See iommu/mediatek,iommu.txt for the detailed description of Mediatek IOMMU) > > > > > + > > > > > + > > > > > +Required properties: > > > > > + > > > > > +- compatible: must be "mediatek,reserve-memory-dip_smem" > > > > > > > > Don't use '_'. > > > > > > I got it. I will use "mediatek,reserve-memory-dip-smem" instead in next > > > version of the patch > > > > > > > > > > > > + > > > > > +- reg: required for static allocation (see reserved-memory.txt for > > > > > + the detailed usage) > > > > > + > > > > > +- alloc-range: required for dynamic allocation. The range must > > > > > + between 0x00000400 and 0x100000000 due to the co-processer's > > > > > + addressing limitation > > > > > > > > Generally, you should pick either static or dynamic allocation for a > > > > given binding. Static if there's some address restriction or sharing, > > > > dynamic if not. > > > > > > > > Sounds like static in this case. > > > > > > > > > > DIP reserved memory has address restriction so it is the static case. I > > > would like to remove the dynamic allocation part and modify the > > > description as following: > > > > > > - reg: required for DIP. The range must be between 0x00000400 and > > > 0x100000000 due to the co-processor's addressing limitation. > > > The size must be 26MB. Please see reserved-memory.txt for the > > > detailed usage. > > > > You can use dma-ranges to define addressing translations and > > restrictions like this. That will in turn set the device's dma-mask to > > ensure allocations are done in a region that is addressable. > > > > But if you have a known, fixed size, then a carve out with > > reserved-memory is fine. > > There is also another aspect here. The coprocessor that we're > allocating the memory for is behind an MPU that must be programmed > completely in one go and locked for security reasons to ensure that > the coprocessor itself doesn't rewrite the MPU settings. That means > that we need to have all the allocations completed before booting that > coprocessor. > > To be honest, I'd adopt a completely different design here. > > We're going to have a driver for that coprocessor (SCP) and IMHO any > shared memory areas should belong to it. Then, any specific drivers > talking to the firmware running on SCP should ask the SCP driver to > allocate some memory from its fixed pool. WDYT? That's more than just an address restriction, so yeah, use a reserved-memory area. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel