From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82AB6C432BE for ; Thu, 26 Aug 2021 12:14:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D7436108D for ; Thu, 26 Aug 2021 12:14:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D7436108D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O4gbnslY+pyHmDSnDcLfKTrJkbAJrsMS2MEXo3mfGLU=; b=m3i93LSuFN9IaN 4EyMG3DsAjjd/urUcqUqEiW3xnE+AVmGBxxWMRC9JiE0HMPWEhr0LFh6FXQKS8jebURabMIv3C/Xi HY5y19q2M/7nc8qg6SUaTSnSIosJeDmUnFlT73GCDdPvtjQFKW0+53X6HEO/RT44L5MYOo8x8f8YN F9AQx64Uvx5ObzfB5dRmtVGTds7pqw69NrUbfxfFRfpUT0ERY32QdV1hUW82Et8acdovD2JVtsn9O XPNMKzoEp7ycuAbObEiaUOxeVIb9HnHh0szU1yb4XHuF/d5R+WDsMcQ1B7jIztIlfWIb/N8surI2e KuhbnQ1NPUVA53VKUsOA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJEEM-00A1sN-Uh; Thu, 26 Aug 2021 12:11:39 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJEEK-00A1rO-1O for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 12:11:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 3C8466108D for ; Thu, 26 Aug 2021 12:11:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629979895; bh=BryUrSxyT2TT6tSSSqTo2t7ZRd6bMgSUrWrQMLXF2ac=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BDBj7holoBi9ZiJTRkXbmYMWcK+xMo0nardzLXT7i4MOjGqW0dAn0wmbvp8j+6+zZ Fg21bazC0VEsUwoBuNDFR7MEh0AJL6UIE4plthN2FY2JPr7F65JZQaFsK2OfaVV83G 9dljEGkyMnbI/J2mdZLjesaHEFOQbDWYfFDy0S5rtW5cpQWVyydKqnvINGVsIYNpGJ kS7/2Nc9DJDRdljYSibSd+MdpnaYU355yAM55ScDuTlpaJpP8QZIk1UB4WCa/a78gP GPv4+6mUzgVsnYdaDNSxhBIhfcQDngB4CSRoWeir3QsyAr7EwkbjAZm55tjrs2fTJh ZdT6vBvMMV0mw== Received: by mail-ed1-f50.google.com with SMTP id r19so4259425eds.13 for ; Thu, 26 Aug 2021 05:11:35 -0700 (PDT) X-Gm-Message-State: AOAM531va++piuGgFTzsktlEG2r0yeClI7MeyPp2jrLYgYkm1NVTdBPb 4hH4+r6+xLfQyLf8c/byeL25yjYhLl4Wkl8fCw== X-Google-Smtp-Source: ABdhPJwYLeRflBPMuNkJZH2Kt3TECicrmcHUV9lHeboJn3XtLXvVEYg6HgPyTCS/Hgqjxpjz5VLMtu4/5uEZEvNSCgg= X-Received: by 2002:aa7:c49a:: with SMTP id m26mr3990849edq.258.1629979893809; Thu, 26 Aug 2021 05:11:33 -0700 (PDT) MIME-Version: 1.0 References: <20210811083830.784065-1-nobuhiro1.iwamatsu@toshiba.co.jp> <20210811083830.784065-3-nobuhiro1.iwamatsu@toshiba.co.jp> In-Reply-To: <20210811083830.784065-3-nobuhiro1.iwamatsu@toshiba.co.jp> From: Rob Herring Date: Thu, 26 Aug 2021 07:11:21 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 2/3] PCI: visconti: Add Toshiba Visconti PCIe host controller driver To: Nobuhiro Iwamatsu Cc: Bjorn Helgaas , Lorenzo Pieralisi , PCI , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , devicetree@vger.kernel.org, Punit Agrawal , yuji2.ishikawa@toshiba.co.jp, linux-arm-kernel , "linux-kernel@vger.kernel.org" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_051136_156543_A219EAB8 X-CRM114-Status: GOOD ( 19.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 11, 2021 at 3:38 AM Nobuhiro Iwamatsu wrote: > > Add support to PCIe RC controller on Toshiba Visconti ARM SoCs. PCIe > controller is based of Synopsys DesignWare PCIe core. > > Signed-off-by: Yuji Ishikawa > Signed-off-by: Nobuhiro Iwamatsu > > v5 -> v6: > - Remove unnecessary commit log. > - Fix split line of visconti_add_pcie_port() > > v4 -> v5: > - Remove PCIE_BUS_OFFSET > - Change link_up confirmation function of visconti_pcie_link_up(). > - Move setting event mask before dw_pcie_link_up(). > - Move the contents of visconti_pcie_power_on() to visconti_pcie_host_init(). > - Remove code for link_gen. > > v3 -> v4: > - Change variable from pci_addr to cpu_addr in visconti_pcie_cpu_addr_fixup(). > - Change the calculation method of CPU addres from subtraction to mask, and > add comment. > - Drop dma_set_mask_and_coherent(). > - Drop set MAX_MSI_IRQS. > - Drop dev_dbg for Link speed. > - Use use the dev_err_probe() to handle the devm_clk_get() failed. > - Changed the redundant clock name. > > v2 -> v3: > - Update subject. > - Wrap description in 75 columns. > - Change config name to PCIE_VISCONTI_HOST. > - Update Kconfig text. > - Drop blank lines. > - Adjusted to 80 columns. > - Drop inline from functions for register access. > - Changed function name from visconti_pcie_check_link_status to > visconti_pcie_link_up. > - Update to using dw_pcie_host_init(). > - Reorder these in the order of use in visconti_pcie_establish_link. > - Rewrite visconti_pcie_host_init() without dw_pcie_setup_rc(). > - Change function name from visconti_device_turnon() to > visconti_pcie_power_on(). > - Unify formats such as dev_err(). > - Drop error label in visconti_add_pcie_port(). > > v1 -> v2: > - Fix typo in commit message. > - Drop "depends on OF && HAS_IOMEM" from Kconfig. > - Stop using the pointer of struct dw_pcie. > - Use _relaxed variant. > - Drop dw_pcie_wait_for_link. > - Drop dbi resource processing. > - Drop MSI IRQ initialization processing. > --- > drivers/pci/controller/dwc/Kconfig | 9 + > drivers/pci/controller/dwc/Makefile | 1 + > drivers/pci/controller/dwc/pcie-visconti.c | 333 +++++++++++++++++++++ > 3 files changed, 343 insertions(+) > create mode 100644 drivers/pci/controller/dwc/pcie-visconti.c Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel