From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46355C83000 for ; Wed, 29 Apr 2020 14:01:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1903420731 for ; Wed, 29 Apr 2020 14:01:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jVC+QV48"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="hc4Odvjl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1903420731 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6xvNvsm/pZgoFeXYC/UMI4SAa7lKO9Pf2gFNMGxnAHQ=; b=jVC+QV48Lievyi OLTso19bwYWy9vCy9+vF28ChyD69WiG2O5csp5TNDar9Wo8Pf9KscUAUFJcn1td8waCd4FiN+zUEd KMXfabQ4y/PQZQ4BWMFvL2W09irIMVk+EsM095ceO5iBgJKBcTrF1MhXMR0f3GTIYBTvIjD5EYTyh 3R6zl/WXAfHZK5l/M4XCAis9ScM/SgbYyi3Cl86YkRoft58Dxqz+asv3BdKWMUUpvtQNw4WBVX2k8 nkUVQqO/8xWPT928LkLFBp5wqnICuTNq3/65KqP4sYwWRDP8q9e7QJ/Zsmr2guOsVCK2QIfjXT6Xi hS+J5zMV3b3Okmt6Pbyg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTnHE-0006qE-If; Wed, 29 Apr 2020 14:01:28 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jTnHB-0006pH-CH for linux-arm-kernel@lists.infradead.org; Wed, 29 Apr 2020 14:01:26 +0000 Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 40D332186A for ; Wed, 29 Apr 2020 14:01:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588168884; bh=xN/X7hSbyxPyWVESktTIbMiEwkcjRKhrmXriJssAL3Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=hc4OdvjlfuNDzNJ8Rv/gIKYnn/xzQNgTWxpxzDwUfNxftJxwO71ikssc8rhC0gvtP dH5AGw6nEEmPmiG7cdo23MJzd4U3O0o8VvMV+ZlIJlDgcLBTMoUwSmqaQgVexVD1jz hQMGrORFsIzCL0gJuiusk8An37qLxjuPb+QFfMIE= Received: by mail-ot1-f44.google.com with SMTP id g14so1721213otg.10 for ; Wed, 29 Apr 2020 07:01:24 -0700 (PDT) X-Gm-Message-State: AGi0PuZpTWF/VF65yopJ65gyPVdXB8gB/Be7Y4tOCDjFYaFI4Kgu+Ej8 sAlLLEKDS1NnIswcimbeyoN7je7Dp/lWGJbz2g== X-Google-Smtp-Source: APiQypKMUHflexMSv4hw0/zHJxF61nw4QTAZjiM/2VPiWMTvQ8ob96+3/iKvOm5RoZWD5h2gKSa+35uIsS2AVfd+ihs= X-Received: by 2002:a9d:1441:: with SMTP id h59mr26992630oth.192.1588168882890; Wed, 29 Apr 2020 07:01:22 -0700 (PDT) MIME-Version: 1.0 References: <20200427212514.11219-1-robh@kernel.org> <733e20b1-9592-6941-766b-9f321ad2ace5@samsung.com> In-Reply-To: From: Rob Herring Date: Wed, 29 Apr 2020 09:01:11 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] amba: Retry adding deferred devices at late_initcall To: Linus Walleij X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200429_070125_439313_7FA8C8C7 X-CRM114-Status: GOOD ( 15.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Geert Uytterhoeven , Saravana Kannan , Russell King , John Stultz , Linux ARM , Sudeep Holla , Nicolas Saenz Julienne , Marek Szyprowski Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Apr 29, 2020 at 7:26 AM Linus Walleij wrote: > > On Wed, Apr 29, 2020 at 8:06 AM Marek Szyprowski > wrote: > > [Me] > > > There are a bit of other differences that have piled up, > > > should we take a quick look at dd.c so there is not something > > > else we're missing? I see some PM code for example. > > > > Well, late initcall based approach is what earlier version of my patch did: > > I see, thanks for the context. > > > For me it is fine to get back to late initcall based solution, though. > > The idea here is to do both/and initcall and timer deferred probe, > not either/or. Yes. > And the dd.c core also does both/and. Not really. Deferred probe delays retrying until late_initcall and then somewhat intelligently retries after successful probes rather than time based. > And then it does some more things, so I was thinking we may be > missing out on some of them? You mean like timeout (which is getting moved back to 0 as timeout causes problems with NFS root)? Remember this is deferred add, not deferred probe. Once the amba devices are added, the deferred probe in dd.c takes over. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel