From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E494C76186 for ; Tue, 23 Jul 2019 22:32:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6206622387 for ; Tue, 23 Jul 2019 22:32:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YgR5Al6H"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="DjBjihMr" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6206622387 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=szqdtRwK8H446Sz4W3Dsadsmg2rw59KPUxgu+tqXTNQ=; b=YgR5Al6HNGGfrK H4pcBsvFeVYDzbyTReqid2VyrJ0biMRtCe4AtwILPJwZ7YImLrzkEYm7tUxIFJctLy89EVYYzOXC0 QvhSoAJxqPOMWJioN7TtzYiB8ATrghA1LxEWuD5eDvsWfZVe12WVAvRvc/5rhvQtJyfjNyzM9HAZM 9CrgzOPlb5lePSoUPm7qgCJeol3LJAgntmG+BXEYdmJ6sA4jAZg+4crmQ48vcKdbXqJR7qLPWRrkJ 6N5KCq5X92ZL/9loSekNhtD1bGEMCkRR3pSbC7XDPv88CLZlspUg4hazGnDLf62aqbDIUKIIGxpMo lhImGtNkdNi8iwlYunkA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hq3Kj-0006wX-3F; Tue, 23 Jul 2019 22:32:33 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hq3Kf-0006vy-UR for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 22:32:31 +0000 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EE97B229F3 for ; Tue, 23 Jul 2019 22:32:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563921149; bh=KRGyoog8m5Y5cpAsI7fSu8XujIiwfwHpdopSDKGv8lI=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DjBjihMrAblKU2YRuoTftYTHNzv1uEcbWnmbdLP12bpNuAEunBCRPBMBaUk+oi7ej nDCr0BYMWeFCRtffKUbuAMfeMGDqP8lzVm5GDzL5VTlOsT0zriKNPgbH+y6Cj5jw5c sncv/xIfPhuf3MM07b+Dm0aKaHn8tld3jGI2M7BQ= Received: by mail-qt1-f182.google.com with SMTP id z4so43569927qtc.3 for ; Tue, 23 Jul 2019 15:32:28 -0700 (PDT) X-Gm-Message-State: APjAAAV9TE4RWP94OxdfYePdmT5Jn1sF/eT2Hufh37zYJDeYNcVfZt+M Lp1sllvW3LrkD/rbC3IE38sVhbp7yLZcTcZLWw== X-Google-Smtp-Source: APXvYqwfoClSOrKbu6CT9RTzisAhHFe5/alrfNoWmvSRZ0JhTVbIQjdWY8lSXYWQs5CGy8HyiUVSlShpxw7B4w0OWGk= X-Received: by 2002:ac8:36b9:: with SMTP id a54mr55862838qtc.300.1563921148138; Tue, 23 Jul 2019 15:32:28 -0700 (PDT) MIME-Version: 1.0 References: <20190723084104.12639-1-daniel.baluta@nxp.com> <20190723084104.12639-6-daniel.baluta@nxp.com> In-Reply-To: <20190723084104.12639-6-daniel.baluta@nxp.com> From: Rob Herring Date: Tue, 23 Jul 2019 16:32:16 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 5/5] dt-bindings: dsp: fsl: Add DSP core binding support To: Daniel Baluta X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_153230_116247_24C0A672 X-CRM114-Status: GOOD ( 19.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Dong Aisheng , Peng Fan , Anson Huang , devicetree@vger.kernel.org, Fabio Estevam , "S.j. Wang" , Marco Felsch , "linux-kernel@vger.kernel.org" , paul.olaru@nxp.com, NXP Linux Team , Sascha Hauer , Leonard Crestez , Shawn Guo , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , sound-open-firmware@alsa-project.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2019 at 2:41 AM Daniel Baluta wrote: > > This describes the DSP device tree node. > > Signed-off-by: Daniel Baluta > --- > .../devicetree/bindings/dsp/fsl,dsp.yaml | 87 +++++++++++++++++++ > 1 file changed, 87 insertions(+) > create mode 100644 Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > new file mode 100644 > index 000000000000..d112486eda0e > --- /dev/null > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > @@ -0,0 +1,87 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/arm/freescale/fsl,dsp.yaml# This needs updating to match the path. > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX8 DSP core > + > +maintainers: > + - Daniel Baluta > + > +description: | > + Some boards from i.MX8 family contain a DSP core used for > + advanced pre- and post- audio processing. > + > +properties: > + compatible: > + enum: > + - fsl,imx8qxp-dsp > + > + reg: > + description: Should contain register location and length > + > + clocks: > + items: > + - description: ipg clock > + - description: ocram clock > + - description: core clock > + > + clock-names: > + items: > + - const: ipg > + - const: ocram > + - const: core > + > + power-domains: > + description: > + List of phandle and PM domain specifier as documented in > + Documentation/devicetree/bindings/power/power_domain.txt > + maxItems: 4 Need a blank line here. With those 2 fixes: Reviewed-by: Rob Herring > + mboxes: > + description: > + List of <&phandle type channel> - 2 channels for TXDB, 2 channels for RXDB > + (see mailbox/fsl,mu.txt) > + maxItems: 4 > + > + mbox-names: > + items: > + - const: txdb0 > + - const: txdb1 > + - const: rxdb0 > + - const: rxdb1 > + > + memory-region: > + description: > + phandle to a node describing reserved memory (System RAM memory) > + used by DSP (see bindings/reserved-memory/reserved-memory.txt) > + maxItems: 1 > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - power-domains > + - mboxes > + - mbox-names > + - memory-region > + > +examples: > + - | > + #include > + #include > + dsp@596e8000 { > + compatbile = "fsl,imx8qxp-dsp"; > + reg = <0x596e8000 0x88000>; > + clocks = <&adma_lpcg IMX_ADMA_LPCG_DSP_IPG_CLK>, > + <&adma_lpcg IMX_ADMA_LPCG_OCRAM_IPG_CLK>, > + <&adma_lpcg IMX_ADMA_LPCG_DSP_CORE_CLK>; > + clock-names = "ipg", "ocram", "core"; > + power-domains = <&pd IMX_SC_R_MU_13A>, > + <&pd IMX_SC_R_MU_13B>, > + <&pd IMX_SC_R_DSP>, > + <&pd IMX_SC_R_DSP_RAM>; > + mbox-names = "txdb0", "txdb1", "rxdb0", "rxdb1"; > + mboxes = <&lsio_mu13 2 0>, <&lsio_mu13 2 1>, <&lsio_mu13 3 0>, <&lsio_mu13 3 1>; > + }; > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel