From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AAEBC33CAF for ; Thu, 16 Jan 2020 18:45:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 37642206E6 for ; Thu, 16 Jan 2020 18:45:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="blczgvVW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="qRbfjgut" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 37642206E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pxboOKbxvKO0tjIjocy7RWYfyYo9jRF5ew+XCa9NWZM=; b=blczgvVWKk2IKe 9ciDrgk5NxTtsgM8tBSwLKBsfKUfCrLbdsXtCXB2oAphrpYKxvOsc+JFyr95cowfLQKxLG8AD7lrd nylOwZ0v9K0GfxBEXyWUa6pc7YcmehJQAmtA4onCSJUFpvTI51OypBl5PPfnY035pHhsIgTKE7hvs hJHwml8jyNHQlTdlJ0kTItSX4xFtDUw20Y8eOvYTkQMBEyHZBkKkujlpoksdIwDJGEzL9C+V6pYNQ x6yGAd+hN1qMgUWY+NDdwH29a79Cbo+qjUILR/HwyI9gz5VzjsX6R0kj4EPKS88/4Cvy9it+BB9SB KPt8smhE8LerHpQiWRyQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1isA8y-0008FJ-St; Thu, 16 Jan 2020 18:45:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1is9k4-0003PZ-Gf for linux-arm-kernel@lists.infradead.org; Thu, 16 Jan 2020 18:19:46 +0000 Received: from mail-qt1-f169.google.com (mail-qt1-f169.google.com [209.85.160.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7DFFD2192A for ; Thu, 16 Jan 2020 18:19:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579198779; bh=FbsZ0/SErF2ACVNYz0E0ittdmPkIEVqQMLPm/a1nnOs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=qRbfjgutZ+me9IhtL7pTaw6/Pkvpm8fZPk33PyLELtiIfXTnWLxkzgwT8N42MF75z JYk+3G2nW7URzZvnzziSNBju2wP4+teeyy7rpEnZpZtDPL9HuH+u2PNdr1A53HkACL y7xDrCnAUzuigR1/bGMhKY/e7CaGNLJSDCaGyE3Q= Received: by mail-qt1-f169.google.com with SMTP id i13so19671604qtr.3 for ; Thu, 16 Jan 2020 10:19:39 -0800 (PST) X-Gm-Message-State: APjAAAWKbhwutP2Reut3BJWf3MTxLaBERq66IVX1LofodXxysIcZTESR O386G78BG4gH8eqZhDGVIkWO30m6ff18LgpW5Q== X-Google-Smtp-Source: APXvYqxWNn7kYxyGzj+kt6DlR20uI18OuWT7JlUj/1abGnmEtEDhdDbV9AJ0rgV0W/pwGJ54BXmTkotnf+ixVRZyAzc= X-Received: by 2002:ac8:1415:: with SMTP id k21mr3734145qtj.300.1579198778476; Thu, 16 Jan 2020 10:19:38 -0800 (PST) MIME-Version: 1.0 References: <20191230144402.30195-1-ulf.hansson@linaro.org> <20191230144402.30195-3-ulf.hansson@linaro.org> In-Reply-To: From: Rob Herring Date: Thu, 16 Jan 2020 12:19:27 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 02/15] dt: psci: Update DT bindings to support hierarchical PSCI states To: Ulf Hansson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200116_101940_618203_AF560A34 X-CRM114-Status: GOOD ( 36.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , "open list:THERMAL" , Stephen Boyd , linux-arm-msm , Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Kevin Hilman , Andy Gross , Lina Iyer , Sudeep Holla , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jan 14, 2020 at 11:55 AM Ulf Hansson wrote: > > On Mon, 13 Jan 2020 at 20:53, Rob Herring wrote: > > > > On Mon, Dec 30, 2019 at 8:44 AM Ulf Hansson wrote: > > > > > > Update PSCI DT bindings to allow to represent idle states for CPUs and the > > > CPU topology, by using a hierarchical layout. Primarily this is done by > > > re-using the existing DT bindings for PM domains [1] and for PM domain idle > > > states [2]. > > > > > > Let's also add an example into the document for the PSCI DT bindings, to > > > clearly show the new hierarchical based layout. The currently supported > > > flattened layout, is already described in the ARM idle states bindings [3], > > > so let's leave that as is. > > > > > > [1] Documentation/devicetree/bindings/power/power_domain.txt > > > [2] Documentation/devicetree/bindings/power/domain-idle-state.txt > > > [3] Documentation/devicetree/bindings/arm/idle-states.txt > > > > > > Co-developed-by: Lina Iyer > > > Signed-off-by: Lina Iyer > > > Reviewed-by: Sudeep Holla > > > Signed-off-by: Ulf Hansson > > > --- > > > > > > Changes in v5: > > > - None. > > > > First I'm seeing this as the DT list was not copied. The example has > > problems when running 'make dt_binding_check': > > > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: cpu@0: > > compatible: Additional items are not allowed ('arm,armv8' was > > unexpected) > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: cpu@0: > > compatible: ['arm,cortex-a53', 'arm,armv8'] is too long > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: cpu@1: > > compatible: Additional items are not allowed ('arm,armv8' was > > unexpected) > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: cpu@1: > > compatible: ['arm,cortex-a57', 'arm,armv8'] is too long > > > > 'arm,armv8' is only valid for s/w models. > > Perhaps you have a different version of the tools than I have (I have > tried both on v.5.5-rc5 and todays linux-next), because I can't > reproduce these errors at my side when running "make > dt_binding_check". > > Can you please check again? Are you setting DT_SCHEMA_FILES? If so, then arm/cpus.yaml (or any other schema) isn't loaded and used for validation. That schema is the source of this error. It is failing in my CI job: https://gitlab.com/robherring/linux-dt-bindings/-/jobs/405298185 Is dt-schema up to date? Though I can't think of any recent changes that would impact this. This check has been there a while and I fixed all the dts files. Do you see psci.example.dt.yaml getting built? > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: > > idle-states: cluster-retention:compatible:0: 'arm,idle-state' was > > expected > > Documentation/devicetree/bindings/arm/psci.example.dt.yaml: > > idle-states: cluster-power-down:compatible:0: 'arm,idle-state' was > > expected > > > > The last 2 are due to my conversion of the idle-states binding which > > is in my tree now. Probably need to add 'domain-idle-state' as a > > compatible at a minimum. It looks like domain-idle-state.txt is pretty > > much the same as arm/idle-state.txt, so we should perhaps merge them. > > Ahh, so maybe *all* of the above problems are caused by conflicts in > the arm-soc tree with changes from your tree!? Shouldn't be. arm/cpus.yaml has been in place for a few cycles now. > > In regards to merging files, I am fine by that if that helps. > > > > > There's some bigger issues though. > > > > > --- > > > .../devicetree/bindings/arm/cpus.yaml | 15 +++ > > > .../devicetree/bindings/arm/psci.yaml | 104 ++++++++++++++++++ > > > 2 files changed, 119 insertions(+) > > > > > > diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml > > > index c23c24ff7575..7a9c3ce2dbef 100644 > > > --- a/Documentation/devicetree/bindings/arm/cpus.yaml > > > +++ b/Documentation/devicetree/bindings/arm/cpus.yaml > > > @@ -242,6 +242,21 @@ properties: > > > > > > where voltage is in V, frequency is in MHz. > > > > > > + power-domains: > > > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > > > + description: > > > + List of phandles and PM domain specifiers, as defined by bindings of the > > > + PM domain provider (see also ../power_domain.txt). > > > + > > > + power-domain-names: > > > + $ref: '/schemas/types.yaml#/definitions/string-array' > > > + description: > > > + A list of power domain name strings sorted in the same order as the > > > + power-domains property. > > > + > > > + For PSCI based platforms, the name corresponding to the index of the PSCI > > > + PM domain provider, must be "psci". > > > + > > > qcom,saw: > > > $ref: '/schemas/types.yaml#/definitions/phandle' > > > description: | > > > diff --git a/Documentation/devicetree/bindings/arm/psci.yaml b/Documentation/devicetree/bindings/arm/psci.yaml > > > index 7abdf58b335e..8ef85420b2ab 100644 > > > --- a/Documentation/devicetree/bindings/arm/psci.yaml > > > +++ b/Documentation/devicetree/bindings/arm/psci.yaml > > > @@ -102,6 +102,34 @@ properties: > > > [1] Kernel documentation - ARM idle states bindings > > > Documentation/devicetree/bindings/arm/idle-states.txt > > > > > > + "#power-domain-cells": > > > > This is wrong because you are saying the /psci node should have these > > properties. You need to define the child nodes (at least a pattern you > > can match on) and put these properties there. > > Right, good point. > > I searched for some similar examples for how to encode this, but > couldn't really find something useful. You need something like: patternProperties: '^(cluster|cpu)-pd[0-9a-f]+$': type: object properties: ... and then the properties in the child nodes Note that its going to look weird for the 10th PD with 'cpu-pda'. So maybe add a '-'. > One more thing, it seems like > this change is also needed for the common power-domain bindings, as > that also specifies parent/childs domains. Normally, we'd have a $ref to power-domain.yaml, but for that to work here, you'll have to expand the node names ($nodename). > > Anyway, I would really appreciate if you can suggest something more > detailed for you think this should be done!? > > > > > > + description: > > > + The number of cells in a PM domain specifier as per binding in [3]. > > > + Must be 0 as to represent a single PM domain. > > > + > > > + ARM systems can have multiple cores, sometimes in an hierarchical > > > + arrangement. This often, but not always, maps directly to the processor > > > + power topology of the system. Individual nodes in a topology have their > > > + own specific power states and can be better represented hierarchically. > > > + > > > + For these cases, the definitions of the idle states for the CPUs and the > > > + CPU topology, must conform to the binding in [3]. The idle states > > > + themselves must conform to the binding in [4] and must specify the > > > + arm,psci-suspend-param property. > > > + > > > + It should also be noted that, in PSCI firmware v1.0 the OS-Initiated > > > + (OSI) CPU suspend mode is introduced. Using a hierarchical representation > > > + helps to implement support for OSI mode and OS implementations may choose > > > + to mandate it. > > > + > > > + [3] Documentation/devicetree/bindings/power/power_domain.txt > > > + [4] Documentation/devicetree/bindings/power/domain-idle-state.txt > > > + > > > + power-domains: > > > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > > > + description: > > > + List of phandles and PM domain specifiers, as defined by bindings of the > > > + PM domain provider. > > > > A schema for 'domain-idle-states' property is missing. > > Right, let's figure out the best way for how to add that. If power-domain.yaml is referenced, then don't need anything else unless you can define the number of phandles (looks like you can't?). Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel