From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7080BC433ED for ; Thu, 13 May 2021 20:50:16 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D1B2D613FB for ; Thu, 13 May 2021 20:50:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D1B2D613FB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9tDITNEMcDb6agFC6Zj7naCkmHmjXrMf5j+VDW+5Kek=; b=nWRP8ZEGV2Xy+goNv/lmz3YeJ Fve5mkx7fBw8t4QSHYI/GUZ5ikJXPEoSBBR3tGGpQK90Qw+JNIv/xpX/mMNORsqJsEg9WqyVdZ7JR mk9nT8pZUHpSbFWhilORW5vDTakhJyD95bTQak5RP01S0H5InRqHuHxRJM7wJhoIF3CliaTUjf4NB rFLpqXRq4NA+mBQNlXJamcivGdY7JvYvud7pu6vibydVBuH74ZX9Z7A9CKaOYUZU2HCgzmW2O0DHq fzw1HWNwmWE841JAm0Vq3X0qGRGzaI7QMiOMkeKaeZ3Bws4Aor2WKSDJjFDt7y9odzn20RyjTBOGd /ctpm8+UQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lhIFX-006Paf-9o; Thu, 13 May 2021 20:48:03 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhIBK-006PLJ-Oq for linux-arm-kernel@desiato.infradead.org; Thu, 13 May 2021 20:44:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Pk4O9pMV/P9HYQ4ZaHXJ24rozdQ7Syfxt4bQ4JoVys4=; b=JrU3vDwuKyDm6vqo5XlkQDCCE0 g3aeoCQKUbMxYeSmL/tSEm4zOFPTJ5Ow3/08FkbwS76HvQiyW51JKG05/vCQuwQYcSXbVSNbmt9TQ GIhitSBynzDrK8eCXzJiS/gIiYnwcBvl3twA7dHnkeUbR5l3nWxHI5OVY9/U7hnIxP/cPLgRJ9sWv Z/CHQukjq0BpdRfpQ4F0fmLryL9vxQNfDDozGxsdvhkxYWiSlZjXbCUYVM9j2fYPXM9HBe9fy+rPG wKRHFyFP1E67wpd/kuRRWzSTEvojKt6DIAJbtWqyqN1tmVhyaaYa8dbY1GZnV1mb6kcd8t2goqtRs 6LmuWL/Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lhIBI-00BWQl-1N for linux-arm-kernel@lists.infradead.org; Thu, 13 May 2021 20:43:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 67A1C613FB for ; Thu, 13 May 2021 20:43:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620938619; bh=A3b16ZVY/C5ZO5MXnyxLTrDK5X7y0uCD4VfIVPCIxZw=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Gzx8vcmyVC0PIR9R2EXJPmIMlLRpTQ8mculxrb84Gtg/6WwgrrIZHkJ0jXgbzupv7 ZOskrgV4czU9o14jF6gcavbWFomqFb4wmesnYXsTboG/lOb999I41AMrsv31N/QPnq ozaIpKTRB6Jcv0z/kuvGD/0xe4aI8cEO3yaVpR0+Lww/wJEp27sNjwSvdOzBUDP3j5 RC6LdYaWC1SFL2mv0nYVgCqER/F2ifnbsn4mRgXdJXEOu2AA3wH6jEkVsJoxwYVsr6 djJoEY15lT3GsVih2iNuZ4ELSpmRBszqd30pu5akOg9S64WFoZNLSKzmoXiru/c9Uq 0fkuqtFS+8pgg== Received: by mail-qk1-f182.google.com with SMTP id x8so26868832qkl.2 for ; Thu, 13 May 2021 13:43:39 -0700 (PDT) X-Gm-Message-State: AOAM533won0WxxOjCTKCbm9IljMoeHM1wfyReGLscfKrE6Rvssl9B4zD QRgJWGefdAvIZ33xeGw9iPtvktML2tVrgsx8lA== X-Google-Smtp-Source: ABdhPJyS9sqwtUxxwJj+pw7aOZgNGV+YskujLTBOnbUWy50BMbWIxY3hIKtH/Vp7VcL3+me6WFqaxQaF0aAZqR54m0g= X-Received: by 2002:a37:6116:: with SMTP id v22mr26536521qkb.464.1620938618472; Thu, 13 May 2021 13:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20210511191239.774570-1-sean.anderson@seco.com> <20210513021631.GA878860@robh.at.kernel.org> <70176596-2250-8ae1-912a-9f9c30694e7d@seco.com> In-Reply-To: <70176596-2250-8ae1-912a-9f9c30694e7d@seco.com> From: Rob Herring Date: Thu, 13 May 2021 15:43:27 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Add Xilinx AXI Timer To: Sean Anderson Cc: Linux PWM List , devicetree@vger.kernel.org, Michal Simek , Alvaro Gamez , "linux-kernel@vger.kernel.org" , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210513_134340_177019_A6CB4EF1 X-CRM114-Status: GOOD ( 34.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 13, 2021 at 10:28 AM Sean Anderson wrote: > > > > On 5/13/21 10:33 AM, Sean Anderson wrote: > > > > > > On 5/12/21 10:16 PM, Rob Herring wrote: > > > On Tue, May 11, 2021 at 03:12:37PM -0400, Sean Anderson wrote: > > >> This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is > > >> a "soft" block, so it has many parameters which would not be > > >> configurable in most hardware. This binding is usually automatically > > >> generated by Xilinx's tools, so the names and values of some properties > > >> must be kept as they are. Replacement properties have been provided for > > >> new device trees. > > > > > > Because you have some tool generating properties is not a reason we have > > > to accept them upstream. > > > > These properties are already in arch/microblaze/boot/dts/system.dts and > > in the devicetree supplied to Linux by qemu. Removing these properties > > will break existing setups, which I would like to avoid. Already in use in upstream dts files is different than just 'automatically generated' by vendor tools. > > > > > 'deprecated' is for what *we* have deprecated. > > > > Ok. I will remove that then. > > > > > > > > In this case, I don't really see the point in defining new properties > > > just to have bool. > > > > I don't either, but it was requested, by Michal... > > Err, your comment on the original bindings was > > > Can't all these be boolean? With no other context, yes that's what I would ask. Now you've given me some context, between using the existing ones and 2 sets of properties to maintain, I choose the former. > And Michal commented > > > I think in this case you should described what it is used by current > > driver in Microblaze and these options are required. The rest are by > > design optional. > > If you want to change them to different value then current binding > > should be deprecated and have any transition time with code alignment. > > So that is what I tried to accomplish with this revision. I also tried > allowing something like > > xlnx,one-timer-only = <0>; /* two timers */ > xlnx,one-timer-only = <1>; /* one timer */ > xlnx,one-timer-only; /* one timer */ > /* property absent means two timers */ > > but I was unable to figure out how to express this with json-schema. I > don't think it's the best design either... json-schema would certainly let you, but generally we don't want properties to have more than 1 type. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel