From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2225FC76186 for ; Tue, 23 Jul 2019 16:33:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EA23F20840 for ; Tue, 23 Jul 2019 16:32:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AeBUrbMD"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="JFx1udfR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EA23F20840 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RX74eytTb02cBuG+bRvVqhyeuhcw5jvTaBeVu8DFa8s=; b=AeBUrbMD8gdtQi EtI48mN+SiRGDm1odCEmlmN2UhIGpMUCfiuRjFb4BKh/U5r8i5tdRnPzzcrQzyorWdwkxq28nQ4Ls 0sWDIM13/248lfqcJmjPxuGl6z0PHp9IvVtBsD+uFyk+6YMPhQygjSwW6jU+Wb/3Y4EctEcAvo+I1 UdMPsojTwoW6HBulEWP1wON0+oZraQCzgtnto6lpU1mZTx+9WEmKY87tn/oIm7kuoG+VBfnMG8axt ym9FhMV/hmMhIWY2Rsj0kLB/YYOLnBnypWcs/jlY3Kyux+3HT9Lfr9BEiStBIe/7T0a0rxkQFFWPq GpKbXx2xPCbGMASFChzg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hpxil-00007c-5y; Tue, 23 Jul 2019 16:32:59 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hpxih-0008Os-3T for linux-arm-kernel@lists.infradead.org; Tue, 23 Jul 2019 16:32:56 +0000 Received: from mail-yw1-f44.google.com (mail-yw1-f44.google.com [209.85.161.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 95DD1227BF for ; Tue, 23 Jul 2019 16:32:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563899574; bh=UkC9CMAg2OA3YyFW059HsAnan8UVUBUydqVwz+KnGXo=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=JFx1udfR2Smg079z8oHQ9gAztG5ijfvP0ayA7dJh/CWZ+dFoSF0CSse1tkcFPy/+j dmrr4zl3dAdoODQEILGkWHAeR6RBe16FOqzohVwKhIrEUCsotVnaUudtjwAzTUAuvA uWFSMcttwIlJLgdwfw0vGKTqDXmgJVLvsTtyJV80= Received: by mail-yw1-f44.google.com with SMTP id u141so17161148ywe.4 for ; Tue, 23 Jul 2019 09:32:54 -0700 (PDT) X-Gm-Message-State: APjAAAV7+3aZBVNBWM60WMW79oh6SN6+xLUjW/bxn51lqyCLvjCHSaQT JaD9XMPh802Lf8zb8uxCsT2Y1bObiZl1GBXU8g== X-Google-Smtp-Source: APXvYqzTkj0IYYWKDgZSL/Io1oTkkh3szkCRGZDjVJgYHjvYn6KAws+dxyPhaOCU7BlGZaFaH9GYfScLchP2GVsEVbs= X-Received: by 2002:a81:6a05:: with SMTP id f5mr47818045ywc.368.1563899573743; Tue, 23 Jul 2019 09:32:53 -0700 (PDT) MIME-Version: 1.0 References: <20190723132658.5068-1-maxime.ripard@bootlin.com> <20190723132658.5068-2-maxime.ripard@bootlin.com> In-Reply-To: <20190723132658.5068-2-maxime.ripard@bootlin.com> From: Rob Herring Date: Tue, 23 Jul 2019 10:32:41 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: irq: Convert Allwinner NMI Controller to a schema To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190723_093255_193287_E722180D X-CRM114-Status: GOOD ( 22.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Jason Cooper , maz@kernel.org, Chen-Yu Tsai , Thomas Gleixner , Frank Rowand , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 23, 2019 at 7:27 AM Maxime Ripard wrote: > > The Allwinner SoCs have an interrupt controller called NMI supported in > Linux, with a matching Device Tree binding. > > Now that we have the DT validation in place, let's convert the device tree > bindings for that controller over to a YAML schemas. > > Signed-off-by: Maxime Ripard > --- > .../allwinner,sun7i-a20-sc-nmi.yaml | 83 +++++++++++++++++++ > .../allwinner,sunxi-nmi.txt | 29 ------- > 2 files changed, 83 insertions(+), 29 deletions(-) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/allwinner,sunxi-nmi.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > new file mode 100644 > index 000000000000..cb8077b0c8dd > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml > @@ -0,0 +1,83 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/allwinner,sun7i-a20-sc-nmi.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Allwinner A20 Non-Maskable Interrupt Controller Device Tree Bindings > + > +maintainers: > + - Chen-Yu Tsai > + - Maxime Ripard > + > +allOf: > + - $ref: /schemas/interrupt-controller.yaml# > + > +select: > + properties: > + compatible: > + contains: > + enum: > + - allwinner,sun6i-a31-r-intc > + - allwinner,sun7i-a20-sc-nmi > + - allwinner,sun9i-a80-sc-nmi This should have all the possible compatibles in case all are not listed. > + > + # Deprecated > + - allwinner,sun6i-a31-sc-nmi I know we already did things this way before, but perhaps this should be listed below with the 'deprecated' property. The tools can include it in select, but then remove it from compatible property. > + > + required: > + - compatible > + > +properties: > + "#interrupt-cells": > + const: 2 > + description: > + The first cell is the IRQ number, the second cell the trigger > + type as defined in interrupt.txt in this directory. > + > + compatible: > + oneOf: > + - const: allwinner,sun6i-a31-r-intc > + - const: allwinner,sun7i-a20-sc-nmi > + - items: > + - const: allwinner,sun8i-a83t-r-intc > + - const: allwinner,sun6i-a31-r-intc > + - const: allwinner,sun9i-a80-sc-nmi > + - items: > + - const: allwinner,sun50i-a64-r-intc > + - const: allwinner,sun6i-a31-r-intc > + - items: > + - const: allwinner,sun50i-h6-r-intc > + - const: allwinner,sun6i-a31-r-intc > + > + reg: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + interrupt-controller: true > + > +required: > + - "#interrupt-cells" > + - compatible > + - reg > + - interrupts > + - interrupt-controller > + > +# FIXME: We should set it, but it would report all the generic > +# properties as additional properties. > +# additionalProperties: false > + > +examples: > + - | > + interrupt-controller@1c00030 { > + compatible = "allwinner,sun7i-a20-sc-nmi"; > + interrupt-controller; > + #interrupt-cells = <2>; > + reg = <0x01c00030 0x0c>; > + interrupt-parent = <&gic>; > + interrupts = <0 0 4>; > + }; > + > +... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel