From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CDF0C433E0 for ; Wed, 10 Mar 2021 17:21:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BA3C864E56 for ; Wed, 10 Mar 2021 17:21:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA3C864E56 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Bnxeup4y8krS92kA1Sm6+Oj86yUizTPfEo8Y7PIN49k=; b=NT1SeW1SC3MZXCmOm2//t+tTH zzySwMclQ0Qz6F8Muz6YdGOoix1Q9OArvxn9XiBD42EX7DFfL0dvup4ANPjiyTMGyTH+10vy1BhK3 LRFwaegdyD+SULOzA0TAs+VQd97cgQ3fpDn1b9+uSZmSAnAp/ajcexOvHEeMXDolkZ4hsMosGLjgy 6k+DooserOJHFSjk7fzLhNR+6htGY2R/6RXRISrJKGPWp3uJFPJ4p0HPgfyi4ecYhAcrrPtFS4BSy IKwxcirLIjTWBS7ELACftjgxiDGcbQOPutIp2KJWqoqCoIFpRL3ZRf41MaeuW4jP+WqFIYR4tYrez eJ7mmo4JQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK2VG-007KJu-Ip; Wed, 10 Mar 2021 17:20:10 +0000 Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK2V3-007KGs-UC for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 17:20:00 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 9998864FD6 for ; Wed, 10 Mar 2021 17:19:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1615396796; bh=WdJcFgO9Ab4EwkwCGapjsq0NBHCfwsTezuqlatGj9W0=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=ewZT5AU2KxemL7xN1JnFvBkfiwHC4K35mYGZ0hZGYCP60VqGIEgP1/R0K55yEf5qV ing4qozOCFdAjrdV8NRKzn+qy0Lup29tWaI6WOGVaAdxAZ0wJkpvMI/poPVxmebpUZ EGowty58SmmBJqoSPG9aK1doEtusJSZI59XFz9huo0cbNvOExf147jReFm+Ddo2gnV o5r/FIZDP3/94zWqm65erfdgbSt7BrgX2Kt72cgmiCIijTZbV9UpM2nKZ0mFxPKHSH PwoJ4Y5wc0oK2w6D+nrzCjGDD999vvxUaSizZ/PoNnlM4XGKp7rda0HvzrbJb2gQtj RMPSnfS/z8ZGQ== Received: by mail-qk1-f177.google.com with SMTP id s7so17612366qkg.4 for ; Wed, 10 Mar 2021 09:19:56 -0800 (PST) X-Gm-Message-State: AOAM533KQe3OxuJFpI1r/qv/QtKx1m+dTQcnG4RM42Hu7jSV+nMdrixa 8V9mhKo+mEmu2ZgXOqALqjiYpm87SuT0iFUHMg== X-Google-Smtp-Source: ABdhPJxHCUeEM1sl0CP7oLSOGr4ElsXStXMW1BKNcfVgP+4t9wFxrHd80qsCzG9xhSGiPXRgrhqPH64MxqoMe0+aVDA= X-Received: by 2002:a05:620a:b02:: with SMTP id t2mr3811728qkg.128.1615396795357; Wed, 10 Mar 2021 09:19:55 -0800 (PST) MIME-Version: 1.0 References: <20210304070224.22346-1-nava.manne@xilinx.com> <20210304070224.22346-3-nava.manne@xilinx.com> <20210308201944.GA2886704@robh.at.kernel.org> In-Reply-To: From: Rob Herring Date: Wed, 10 Mar 2021 10:19:44 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga manager To: Nava kishore Manne Cc: "mdf@kernel.org" , "trix@redhat.com" , Michal Simek , "gregkh@linuxfoundation.org" , Jolly Shah , Rajan Vaja , "arnd@arndb.de" , Manish Narani , Amit Sunil Dhamne , Tejas Patel , "linux-fpga@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "chinnikishore369@gmail.com" , Appana Durga Kedareswara Rao X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_171958_582515_286F060B X-CRM114-Status: GOOD ( 20.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Mar 10, 2021 at 10:12 AM Rob Herring wrote: > > On Wed, Mar 10, 2021 at 3:50 AM Nava kishore Manne wrote: > > > > Hi Rob, > > > > Thanks for providing the review comments. > > Please find my response inline. > > > > > -----Original Message----- > > > From: Rob Herring > > > Sent: Tuesday, March 9, 2021 1:50 AM > > > To: Nava kishore Manne > > > Cc: mdf@kernel.org; trix@redhat.com; Michal Simek ; > > > gregkh@linuxfoundation.org; Jolly Shah ; Rajan Vaja > > > ; arnd@arndb.de; Manish Narani > > > ; Amit Sunil Dhamne ; Tejas > > > Patel ; linux-fpga@vger.kernel.org; > > > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; linux-arm- > > > kernel@lists.infradead.org; chinnikishore369@gmail.com; Appana Durga > > > Kedareswara Rao > > > Subject: Re: [PATCH v3 2/3] dt-bindings: fpga: Add binding doc for versal fpga > > > manager > > > > > > On Thu, Mar 04, 2021 at 12:32:23PM +0530, Nava kishore Manne wrote: > > > > From: Appana Durga Kedareswara rao > > > > > > > > This patch adds binding doc for versal fpga manager driver. > > > > > > Why do you need a DT entry for this? Can't the Versal firmware driver > > > instantiate the fpga-mgr device? > > > > > This dt entry is need to handle the fpga regions properly for both full and Partial bitstream loading use cases and it cannot be done by Versal firmware driver instantiate. > > Ah yes, I forgot about that. Looking at this some more, please convert xlnx,zynqmp-firmware.txt to schema and add the node for this there. We don't need a whole other schema file just for a node and compatible. Also, looks like xlnx,zynqmp-pcap-fpga.txt is the prior version of the same thing, so it should be handled in the schema too. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel