From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8DBEC3815B for ; Mon, 20 Apr 2020 17:05:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EC132078C for ; Mon, 20 Apr 2020 17:05:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hEqK4JsF"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="q4T1kv7H" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EC132078C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Vkzfv8ikowBYZ//AGXHisDmBmW5ak0ijZ7NtCTzJJOo=; b=hEqK4JsFo2NrPF HTG4PEqKWayuFoUb7PwUKHWMdyQ7twWC+RHcgKjpvfKSukZzb7NskVA1TtuZpJIPo7TqEDV0VD/G9 WLsUcCpm6nheorTDAvXenr7ZsxmJ2kKUfi0mGP2aBycDzzwhcLfK0Pvsf5pSrZ/hPey1IRTagU3xI oyMKAyZPe1itqk0OmbFdMQZr4JNVcrWFDBtWvAVQjyhBieSNYwsfKyG3NDkhB1MSEb7zQlHiIDc+I tdP8DsmgFYMSt1BuJdtKTSdMqb0BX55fPHNo9FqYf0cKIMutgV2BmXewfSPjNAZnW6KC1HBldvWlP XZaaHHP+6ReSiNDb2EIg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQZrZ-0002ST-8m; Mon, 20 Apr 2020 17:05:41 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQZrW-0002RD-Oy for linux-arm-kernel@lists.infradead.org; Mon, 20 Apr 2020 17:05:39 +0000 Received: from mail-qv1-f46.google.com (mail-qv1-f46.google.com [209.85.219.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 57D8422240 for ; Mon, 20 Apr 2020 17:05:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587402338; bh=Xc6XrmLSCIcb51KsMBWF6mTM27IZYmEb7/lQXrM3bu4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=q4T1kv7HdPS1P5AZLjTSWBTvlZzn4+euSJBG9XPEJqjOF4FmZ514Wr1grHZzGoua5 6Z5ff+J6X2CSm24a61Qi0qetLCs0LuaKfQckhEVrAzSFRhtpFfxW3wmn5ON7BcecsZ 6dSEhbpXs3HPlIIV5+JtrFntF009WAxyXwsB7qck= Received: by mail-qv1-f46.google.com with SMTP id v18so5051323qvx.9 for ; Mon, 20 Apr 2020 10:05:38 -0700 (PDT) X-Gm-Message-State: AGi0PuafvSEUUGV6MkmSNVZrjdwm/3+dBMSzDR7CNtsAthFs3ku5jKkl JfAS6EZWM18xy8JrTbNw/7IqyyqyHaiusXWe3A== X-Google-Smtp-Source: APiQypIDWoULtjcdPMhHTwUbjhB5PgHOYuP8qk/54NpEcp5kyQVmA7he6ResPS2EXZ7aD56hadG6ccO+LfE9ccPnqZk= X-Received: by 2002:ad4:4ae3:: with SMTP id cp3mr14899713qvb.136.1587402337413; Mon, 20 Apr 2020 10:05:37 -0700 (PDT) MIME-Version: 1.0 References: <20200419170810.5738-1-robh@kernel.org> <20200419170810.5738-13-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Mon, 20 Apr 2020 12:05:24 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 12/17] mfd: vexpress-sysreg: Support building as a module To: Arnd Bergmann X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200420_100538_831296_DB74EB7F X-CRM114-Status: GOOD ( 12.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lorenzo Pieralisi , Will Deacon , Linux PM list , Stephen Boyd , Catalin Marinas , Linus Walleij , Sudeep Holla , Liviu Dudau , Sebastian Reichel , Kevin Brodsky , Greg Kroah-Hartman , Lee Jones , linux-clk , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Apr 20, 2020 at 10:32 AM Arnd Bergmann wrote: > > On Sun, Apr 19, 2020 at 7:08 PM Rob Herring wrote: > > > > Enable building the vexpress-sysreg driver as a module. > > > - > > - /* Need the sysreg early, before any other device... */ > > - for_each_matching_node(node, vexpress_sysreg_match) > > - of_platform_device_create(node, NULL, NULL); > > Is this safe to remove? If yes, please mention it in the changelog. Well, yes and no (I think). This was purely to instantiate the device early before the default DT probing would do it (as all the parents are 'simple-bus' the default would descend to these nodes). It's fine after patch 14 for sure, but before that I think it is changing the initcall/probe order. So I'll stick this between patch 15 and 16. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel