From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A53CC43464 for ; Fri, 18 Sep 2020 18:56:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE0B2206D4 for ; Fri, 18 Sep 2020 18:56:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Hvz1DZc7"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z65fD12q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BE0B2206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=64RE55PPwVySRSscDOPjuVdUgazbbPjOW9oYImpr7rA=; b=Hvz1DZc7Of/kSYJreOfZxzUti KsBbVdaeO3SGHzeoJH8Jvw+XfXhmOfaf07O6qQoGOz2rvIO6RYljdHA/5mX6TThYYLzmzdE8p+6T6 gcqrhonkzYdOx3GFAnTu8gPXWapnSZcuPMriWoOVjbyFYsUsfZ3Y2KBF1bKGKbAZexJ2RDnoERRUP Nr0lmxu3svqUFPaOxJ03SgqD5d2ZSYd6DmBl/eEApoXgf3A8qmJBkVUhxzWMFhgOdK0ZVY5sNL8q0 uXR/c/Owt3f+sU5vqw8Cf3xEPU0qmlXe65qZfxcDOslz2Ku2mQqkid8ni9xQmNwK8I+HOnX4bRLHY aIXG1drqw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJLWl-00083t-Oy; Fri, 18 Sep 2020 18:54:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kJLWj-00083W-0A for linux-arm-kernel@lists.infradead.org; Fri, 18 Sep 2020 18:54:34 +0000 Received: from mail-oi1-f182.google.com (mail-oi1-f182.google.com [209.85.167.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C002622211 for ; Fri, 18 Sep 2020 18:54:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600455271; bh=MTIW355N5770LNhcizrqElTPdd1Z+DWoNy1nh/Pxcl4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=Z65fD12qWO+Hysp4hF9eF3cwQFnHUIMY4Vq6zn0+8yflj7K8k8Bt/MfTu8ETyyztR +YRRz3NBHOETOtVvwh/zsDArvpdUwaAIB+ldQnWtuvi5eYASPNFCfvsgNyzbUhk7dX DVRni2BN0VMebNzgQJbEf46+Z+cUrR8ze5DBIsBo= Received: by mail-oi1-f182.google.com with SMTP id 185so8183388oie.11 for ; Fri, 18 Sep 2020 11:54:31 -0700 (PDT) X-Gm-Message-State: AOAM533zodxBGbRgYqqD9cK9it15AaLwFdZsiT6+Y37ROZNMnDOfyw0F QPTEcxup3kRM2GqsvElIPUFl/Jz2xDv3f1ol6g== X-Google-Smtp-Source: ABdhPJxa6SLEyrvMzE3y4VWtdB3vRAq+p/PX6Wl96kp1WSzwdGBy4xUeNHXIzNU74uh8nZT63Cc+aFS3bX0n680JWbg= X-Received: by 2002:aca:1711:: with SMTP id j17mr10713572oii.152.1600455270993; Fri, 18 Sep 2020 11:54:30 -0700 (PDT) MIME-Version: 1.0 References: <3647765303e8936d45a69fe7c1f92b8d1b45de4b.1600452762.git.robin.murphy@arm.com> In-Reply-To: <3647765303e8936d45a69fe7c1f92b8d1b45de4b.1600452762.git.robin.murphy@arm.com> From: Rob Herring Date: Fri, 18 Sep 2020 12:54:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2.1 1/3] perf: Add Arm CMN-600 DT binding To: Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200918_145433_172808_2B05848A X-CRM114-Status: GOOD ( 23.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, patrik.berglund@arm.com, tuanphan@os.amperecomputing.com, tsahee@amazon.com, harb@amperecomputing.com, linux-arm-kernel , james.yang@arm.com, Will Deacon , "Saidi, Ali" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Sep 18, 2020 at 12:24 PM Robin Murphy wrote: > > Document the requirements for the CMN-600 DT binding. The internal > topology is almost entirely discoverable by walking a tree of ID > registers, but sadly both the starting point for that walk and the > exact format of those registers are configuration-dependent and not > discoverable from some sane fixed location. Oh well. > > Signed-off-by: Robin Murphy > --- > > fix up $id as well, oops... > > .../devicetree/bindings/perf/arm,cmn.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/perf/arm,cmn.yaml Do you expect this to cover more than cmn-600? If not, use the compatible string for the file name. > > diff --git a/Documentation/devicetree/bindings/perf/arm,cmn.yaml b/Documentation/devicetree/bindings/perf/arm,cmn.yaml > new file mode 100644 > index 000000000000..e4fcc0de25e2 > --- /dev/null > +++ b/Documentation/devicetree/bindings/perf/arm,cmn.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2020 Arm Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/perf/arm,cmn.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Arm CMN (Coherent Mesh Network) Performance Monitors > + > +maintainers: > + - Robin Murphy > + > +properties: > + compatible: > + const: arm,cmn-600 > + > + reg: > + items: > + - description: Physical address of the base (PERIPHBASE) and > + size (up to 64MB) of the configuration address space. > + > + interrupts: > + minItems: 1 > + maxItems: 4 > + items: > + - description: Overflow interrupt for DTC0 > + - description: Overflow interrupt for DTC1 > + - description: Overflow interrupt for DTC2 > + - description: Overflow interrupt for DTC3 > + description: One interrupt for each DTC domain implemented must > + be specified, in order. DTC0 is always present. What's DTC? > + > + arm,root-node: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: Offset from PERIPHBASE of the configuration > + discovery node (see TRM definition of ROOTNODEBASE). You can enforce some alignment: multipleOf: 0x4000 > + > +required: > + - compatible > + - reg > + - interrupts > + - arm,root-node > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + pmu@50000000 { > + compatible = "arm,cmn-600"; > + reg = <0x50000000 0x4000000>; > + /* 4x2 mesh with one DTC, and CFG node at 0,1,1,0 */ > + interrupts = ; > + arm,root-node = <0x104000>; > + }; > +... > -- > 2.28.0.dirty _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel