From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F39EAC76186 for ; Wed, 17 Jul 2019 13:43:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B021820651 for ; Wed, 17 Jul 2019 13:43:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ik+aC57M"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="u9xbWDZZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B021820651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KJi1HLABMG+OQfDv1qw69lZZaxVyHODyOw/ZxCP+/AY=; b=Ik+aC57Mlqqu2n X+cOUsSkyUVFBPSYwNcZE6WYoOjP7v2MSIPMgDXzZOFG3FFltDBclMoFAFfqSGZN74q0Yp747N2ME zLVTertiv1zEC9IqWu2A734O4k+I/nL/jU+qO9rpEiJ8w5sDZTP6Pa8XIpixlz/WZjOrwPSEdIyTD DmDgaCCdG7VEFmxfibBSA9MaH1sE3LxGJFtZz9eCeSaMmBtmUIH/Fi7hKGiwmZC7CAn9zg1tJHlaV 7EwVyfqXq7lH0SkLT88FrilJPeUzsTcUzqd6TuIc7v+F+Bvz3UIk2gTpDk51ZR1OCEnSmiAAKw4eH UfgAA5bFpIwwbfvnVb7A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hnkDM-0004B6-Lq; Wed, 17 Jul 2019 13:43:24 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hnkDI-0004AW-Ly for linux-arm-kernel@lists.infradead.org; Wed, 17 Jul 2019 13:43:22 +0000 Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 25B3421848 for ; Wed, 17 Jul 2019 13:43:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1563371000; bh=b+x+b4NCqFKQ+1PNG6IM4VpJY3IU3W3bJdwBExP8rdA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=u9xbWDZZC5YP0yalQ3negtPPV6BVZQ7wi56ltY7eHOOf0YgpNzBzoxcBwtzW7mOmx WgxFC+nSg1y8MCnUwLtH2v+vmN1vTtdlMQNxWqrBKBKlMD9Z7XKDDL71WWbQa2P2OG GvIirxmMJMNfM0J/46BHFApAo/Kj0P/Bk+RoUxgw= Received: by mail-qt1-f182.google.com with SMTP id h18so23331852qtm.9 for ; Wed, 17 Jul 2019 06:43:20 -0700 (PDT) X-Gm-Message-State: APjAAAVVKPTJf68YnrhOqRJj04KujgR6eQOAgTM9MvHzahRxNEIgYKwj Q3VbfdcCtGRH2oxzrw+2hzmfxzfHDNL2i0IATw== X-Google-Smtp-Source: APXvYqxemI43ftnjQzG6EZtYAR1PGmByDgQ7cM1LN44uorEnKyt8XBd/ehLX6DVgzgxWIxy+3Uz0PjttXYb+ejOST8U= X-Received: by 2002:a0c:acef:: with SMTP id n44mr29346792qvc.39.1563370999272; Wed, 17 Jul 2019 06:43:19 -0700 (PDT) MIME-Version: 1.0 References: <20190712033214.24713-1-andrew@aj.id.au> <20190712033214.24713-2-andrew@aj.id.au> <3fe55ea9-b949-48a0-9eab-90ad3bc1ee2a@www.fastmail.com> In-Reply-To: From: Rob Herring Date: Wed, 17 Jul 2019 07:43:07 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] dt-bindings: mmc: Document Aspeed SD controller To: Andrew Jeffery X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190717_064320_749699_F9960472 X-CRM114-Status: GOOD ( 30.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Ulf Hansson , linux-aspeed@lists.ozlabs.org, Ryan Chen , linux-mmc , Adrian Hunter , "linux-kernel@vger.kernel.org" , Joel Stanley , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jul 16, 2019 at 9:58 PM Andrew Jeffery wrote: > > > > On Wed, 17 Jul 2019, at 00:27, Rob Herring wrote: > > On Mon, Jul 15, 2019 at 6:36 PM Andrew Jeffery wrote: > > > > > > > > > > > > On Tue, 16 Jul 2019, at 07:47, Rob Herring wrote: > > > > On Thu, Jul 11, 2019 at 9:32 PM Andrew Jeffery wrote: > > > > > > > > > > The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the > > > > > SDIO Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit > > > > > data bus if only a single slot is enabled. > > > > > > > > > > Signed-off-by: Andrew Jeffery > > > > > --- > > > > > In v2: > > > > > > > > > > * Rename to aspeed,sdhci.yaml > > > > > * Rename sd-controller compatible > > > > > * Add `maxItems: 1` for reg properties > > > > > * Move sdhci subnode description to patternProperties > > > > > * Drop sdhci compatible requirement > > > > > * #address-cells and #size-cells are required > > > > > * Prevent additional properties > > > > > * Implement explicit ranges in example > > > > > * Remove slot property > > > > > > > > > > .../devicetree/bindings/mmc/aspeed,sdhci.yaml | 90 +++++++++++++++++++ > > > > > 1 file changed, 90 insertions(+) > > > > > create mode 100644 Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > > > > > > > diff --git a/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > > new file mode 100644 > > > > > index 000000000000..67a691c3348c > > > > > --- /dev/null > > > > > +++ b/Documentation/devicetree/bindings/mmc/aspeed,sdhci.yaml > > > > > @@ -0,0 +1,90 @@ > > > > > +# SPDX-License-Identifier: GPL-2.0-or-later > > > > > +%YAML 1.2 > > > > > +--- > > > > > +$id: http://devicetree.org/schemas/mmc/aspeed,sdhci.yaml# > > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > > + > > > > > +title: ASPEED SD/SDIO/eMMC Controller > > > > > + > > > > > +maintainers: > > > > > + - Andrew Jeffery > > > > > + - Ryan Chen > > > > > + > > > > > +description: |+ > > > > > + The ASPEED SD/SDIO/eMMC controller exposes two slots implementing the SDIO > > > > > + Host Specification v2.00, with 1 or 4 bit data buses, or an 8 bit data bus if > > > > > + only a single slot is enabled. > > > > > + > > > > > + The two slots are supported by a common configuration area. As the SDHCIs for > > > > > + the slots are dependent on the common configuration area, they are described > > > > > + as child nodes. > > > > > + > > > > > +properties: > > > > > + compatible: > > > > > + enum: [ aspeed,ast2400-sd-controller, aspeed,ast2500-sd-controller ] > > > > > > > > This is actually a list of 4 strings. Please reformat to 1 per line. > > > > > > On reflection that's obvious, but also a somewhat subtle interaction with the > > > preference for no quotes (the obvious caveat being "except where required"). > > > > It wasn't something I'd run into before. I'm working on a check, but > > unfortunately we can only check for quotes not needed and can't check > > for missing quotes. > > > > > Thanks for pointing it out. > > > > > > I have been running `make dt_binding_check` and `make dtbs_check` over > > > these, looks like I need to up my game a bit though. Do you do additional things > > > in your workflow? > > > > That should have thrown the warnings. If you aren't seeing those, do > > you have dtschema package installed (see > > Documentation/devicetree/writing-schema.md)? > > I do have it installed, but as mentioned previously there's a fair few > warnings emitted currently by the Aspeed devicetrees, so it might have > got lost in the noise. I've started to clean that up, though probably need > some direction there too. > > Separately I'm currently trying to track down an issue where I get errors > on the Aspeed dts cpu nodes about failing to match the riscv CPU > compatibles, it seems dt-validate isn't finding the ARM CPU compatible > strings. It feels more annoying to track down that I'd like. There's a fix in today's linux-next for that and it should be in Linus' tree in a few days. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel