From: Rob Herring <robh@kernel.org>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: PCI <linux-pci@vger.kernel.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Jingoo Han <jingoohan1@gmail.com>,
Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Subject: Re: [PATCH 2/5] PCI: dwc: pci-dra7xx: make it a kernel module
Date: Tue, 18 May 2021 13:55:07 -0500 [thread overview]
Message-ID: <CAL_JsqKcD7iw85X1be20kZxDsHY7F3J0TQTTgeZYiMMX3O3S4w@mail.gmail.com> (raw)
In-Reply-To: <20210517154122.430544-3-luca@lucaceresoli.net>
On Mon, May 17, 2021 at 10:41 AM Luca Ceresoli <luca@lucaceresoli.net> wrote:
>
> This allows to build the driver as a loadable kernel module.
Enable building the driver as a loadable kernel module.
>
> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
> ---
> drivers/pci/controller/dwc/pci-dra7xx.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/dwc/pci-dra7xx.c b/drivers/pci/controller/dwc/pci-dra7xx.c
> index 6457695df00c..fe11b96fe9a5 100644
> --- a/drivers/pci/controller/dwc/pci-dra7xx.c
> +++ b/drivers/pci/controller/dwc/pci-dra7xx.c
> @@ -15,6 +15,7 @@
> #include <linux/irqdomain.h>
> #include <linux/kernel.h>
> #include <linux/init.h>
> +#include <linux/module.h>
> #include <linux/of_device.h>
> #include <linux/of_gpio.h>
> #include <linux/of_pci.h>
> @@ -949,4 +950,8 @@ static struct platform_driver dra7xx_pcie_driver = {
> },
> .shutdown = dra7xx_pcie_shutdown,
> };
> -builtin_platform_driver(dra7xx_pcie_driver);
> +module_platform_driver(dra7xx_pcie_driver);
You need MODULE_DEVICE_TABLE() too for autoloading.
> +
> +MODULE_AUTHOR("Kishon Vijay Abraham I <kishon@ti.com>");
> +MODULE_DESCRIPTION("PCIe controller driver for TI DRA7xx SoCs");
> +MODULE_LICENSE("GPL v2");
> --
> 2.25.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-05-18 18:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-17 15:41 [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Luca Ceresoli
2021-05-17 15:41 ` [PATCH 1/5] PCI: dwc: export more symbols to allow modular drivers Luca Ceresoli
2021-05-17 15:41 ` [PATCH 2/5] PCI: dwc: pci-dra7xx: make it a kernel module Luca Ceresoli
2021-05-18 18:55 ` Rob Herring [this message]
2021-05-18 21:39 ` Luca Ceresoli
2021-05-17 15:41 ` [PATCH 3/5] PCI: dwc: pci-dra7xx: allow to build as a loadable module Luca Ceresoli
2021-05-17 15:41 ` [PATCH 4/5] PCI: dwc: pci-dra7xx: remove unused include Luca Ceresoli
2021-05-17 15:41 ` [PATCH 5/5] PCI: dwc: pci-dra7xx: get an optional clock Luca Ceresoli
2021-05-17 16:36 ` [PATCH 0/5] PCI: dwc: pci-dra7xx: miscellaneous improvements Bjorn Helgaas
2021-05-18 17:06 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqKcD7iw85X1be20kZxDsHY7F3J0TQTTgeZYiMMX3O3S4w@mail.gmail.com \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=luca@lucaceresoli.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).