From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8919C35242 for ; Tue, 11 Feb 2020 22:21:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C3E7206D7 for ; Tue, 11 Feb 2020 22:21:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="exWZxJlM"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="rV/nGp0D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C3E7206D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NWMgthXUObCisM6wmvDxD1uc8rrv35drpIb18XI6BDA=; b=exWZxJlMCtwnzA 7MdUCzllAKWPbETzKPcgRlesZHakhUYpn70+lnSQqC9GihKVXBACAUbVtyXk+Ifr/XJVU/abcpVlX fzR4v4UPiJ7DRf99i+bjdTgBJ66DxPnKrJNjtjXSc+4AhTt7aWmCrC9u1aEWQbQVjA0hPcg1uHqJt IXGfjkzkRW/LNVgVGaF4x0RsLCzFet4ucHXy+rktLkbUtsaUPFSaioMg25bSERL20sgC2RBMpfbR2 CafFuRcKxTmeHxFdpTkvOgdVjwKpzpLOcb5HR0BHEy50TL8h5B0gyOfs63iIkKuM58hmm0cTRznys JF9DeX45ckurD9VmOhvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1duO-0007OD-5r; Tue, 11 Feb 2020 22:21:32 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1j1duK-0007Mf-JF for linux-arm-kernel@lists.infradead.org; Tue, 11 Feb 2020 22:21:30 +0000 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F370F2082F for ; Tue, 11 Feb 2020 22:21:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581459685; bh=q+rSFqo9elU7WRH3thbFoGn3yP+yIz3kC3wdjvUcEw4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=rV/nGp0DMw+OM4GyyfCZOEQrjZosAwguf7FJnjGVtcTwNFmezygvg8I4St45yyY2i liF0fymRuqTIZY9te73bnT2DidMZonbQr1Jux4BdVLPu1WX5Z4qLQbbFGynBOlkYzy YFpfu1tEgo6e7pGXCddgcRnLVzn6mRYQ1x3G2D/4= Received: by mail-qk1-f173.google.com with SMTP id q15so107938qke.9 for ; Tue, 11 Feb 2020 14:21:24 -0800 (PST) X-Gm-Message-State: APjAAAUee+I7gMY0YWEi0ShSvDt075ISSdo51PYoUzTiCP1EIsobDZs8 PtsN3LEnDVD4E1BraA0v94OS9w0mrjNsJOlDAg== X-Google-Smtp-Source: APXvYqz63AEggW2LNGCOGY6poWM+6h8Md6Kh6G+Jq5ZCRemvNqvsOiXJhjYbYxk7LX/OKgDB4G6e6KML6WclOT/ISxg= X-Received: by 2002:a37:6042:: with SMTP id u63mr7617189qkb.119.1581459683937; Tue, 11 Feb 2020 14:21:23 -0800 (PST) MIME-Version: 1.0 References: <1579051845-30378-1-git-send-email-Anson.Huang@nxp.com> <20200121223807.GA24850@bogus> In-Reply-To: From: Rob Herring Date: Tue, 11 Feb 2020 16:21:12 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH V3 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json-schema To: Anson Huang X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200211_142128_674639_7320C259 X-CRM114-Status: GOOD ( 30.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aisheng Dong , "mark.rutland@arm.com" , "devicetree@vger.kernel.org" , "festevam@gmail.com" , "linus.walleij@linaro.org" , "linux-kernel@vger.kernel.org" , "stefan@agner.ch" , "linux-gpio@vger.kernel.org" , dl-linux-imx , "kernel@pengutronix.de" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Feb 11, 2020 at 5:20 AM Anson Huang wrote: > > Hi, Rob > > > Subject: Re: [PATCH V3 1/3] dt-bindings: pinctrl: Convert i.MX8MQ to json- > > schema > > > > On Wed, Jan 15, 2020 at 09:30:43AM +0800, Anson Huang wrote: > > > Convert the i.MX8MQ pinctrl binding to DT schema format using > > > json-schema > > > > > > Signed-off-by: Anson Huang > > > --- > > > Changes since V2: > > > - the lisence should be GPL-2.0. > > > --- > > > .../bindings/pinctrl/fsl,imx8mq-pinctrl.txt | 36 ----------- > > > .../bindings/pinctrl/fsl,imx8mq-pinctrl.yaml | 69 > > ++++++++++++++++++++++ > > > 2 files changed, 69 insertions(+), 36 deletions(-) delete mode > > > 100644 > > > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > > create mode 100644 > > > Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml > > > > > > diff --git > > > a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > > b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > > deleted file mode 100644 > > > index 66de750..0000000 > > > --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.txt > > > +++ /dev/null > > > @@ -1,36 +0,0 @@ > > > -* Freescale IMX8MQ IOMUX Controller > > > - > > > -Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in this > > > directory -for common binding part and usage. > > > - > > > -Required properties: > > > -- compatible: "fsl,imx8mq-iomuxc" > > > -- reg: should contain the base physical address and size of the > > > iomuxc > > > - registers. > > > - > > > -Required properties in sub-nodes: > > > -- fsl,pins: each entry consists of 6 integers and represents the mux > > > and config > > > - setting for one pin. The first 5 integers > > input_reg mux_val > > > - input_val> are specified using a PIN_FUNC_ID macro, which can be > > > found in > > > - imx8mq-pinfunc.h under device tree source folder. The last integer > > > CONFIG is > > > - the pad setting value like pull-up on this pin. Please refer to > > > i.MX8M Quad > > > - Reference Manual for detailed CONFIG settings. > > > - > > > -Examples: > > > - > > > -&uart1 { > > > - pinctrl-names = "default"; > > > - pinctrl-0 = <&pinctrl_uart1>; > > > -}; > > > - > > > -iomuxc: pinctrl@30330000 { > > > - compatible = "fsl,imx8mq-iomuxc"; > > > - reg = <0x0 0x30330000 0x0 0x10000>; > > > - > > > - pinctrl_uart1: uart1grp { > > > - fsl,pins = < > > > - MX8MQ_IOMUXC_UART1_RXD_UART1_DCE_RX 0x49 > > > - MX8MQ_IOMUXC_UART1_TXD_UART1_DCE_TX 0x49 > > > - >; > > > - }; > > > -}; > > > diff --git > > > a/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml > > > b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yaml > > > new file mode 100644 > > > index 0000000..e010808 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx8mq-pinctrl.yam > > > +++ l > > > @@ -0,0 +1,69 @@ > > > +# SPDX-License-Identifier: GPL-2.0 > > > +%YAML 1.2 > > > +--- > > > +$id: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fpinctrl%2Ffsl%2Cimx8mq- > > pinctrl.yaml%23&dat > > > > > +a=02%7C01%7CAnson.Huang%40nxp.com%7C8471ec5c0f6848eafe0e08d79 > > ec297db% > > > > > +7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63715243091635696 > > 3&s > > > > > +data=3SEytaczKAQzAlgI3XJANKuxRjuZj0NzI8eemFoPMeU%3D&reserve > > d=0 > > > +$schema: > > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta- > > schemas%2Fcore.yaml%23&data=02%7C01%7CAnson.Hua > > > > > +ng%40nxp.com%7C8471ec5c0f6848eafe0e08d79ec297db%7C686ea1d3bc2b > > 4c6fa92 > > > > > +cd99c5c301635%7C0%7C0%7C637152430916356963&sdata=V4ul%2Fq > > CNNkKXmX > > > +270HNbhYci4aTwOvTCTpD3NqQAUoQ%3D&reserved=0 > > > + > > > +title: Freescale IMX8MQ IOMUX Controller > > > + > > > +maintainers: > > > + - Anson Huang > > > + > > > +description: > > > + Please refer to fsl,imx-pinctrl.txt and pinctrl-bindings.txt in > > > +this directory > > > + for common binding part and usage. > > > + > > > +properties: > > > + compatible: > > > + const: fsl,imx8mq-iomuxc > > > + > > > + reg: > > > + maxItems: 1 > > > + > > > +# Client device subnode's properties > > > +patternProperties: > > > + 'grp$': > > > + type: object > > > + description: > > > + Pinctrl node's client devices use subnodes for desired pin configuration. > > > + Client device subnodes use below standard properties. > > > + > > > + properties: > > > + fsl,pins: > > > + allOf: > > > + - $ref: /schemas/types.yaml#/definitions/uint32-array > > > + description: > > > + each entry consists of 6 integers and represents the mux and config > > > + setting for one pin. The first 5 integers > > + mux_val input_val> are specified using a PIN_FUNC_ID macro, which > > can > > > + be found in . > > The last > > > + integer CONFIG is the pad setting value like pull-up on this pin. > > Please > > > + refer to i.MX8M Quad Reference Manual for detailed CONFIG > > settings. > > > > Based on the description, I think this should be an uint32-matrix type instead > > with a schema like this: > > > > items: > > items: > > - description: mux_reg > > - description: conf_reg > > - description: input_reg > > - description: mux_val > > - description: input_val > > - description: pad setting > > > > (With better descriptions preferrably) > > I will use something like below: > > + - $ref: /schemas/types.yaml#/definitions/uint32-matrix > + - items: > + items: > + - description: | > + "mux_reg" indicates the offset of mux register. > + - description: | > + "conf_reg" indicates the offset of pad configuration register. > + - description: | > + "input_reg" indicates the offset of select input register. > + - description: | > + "mux_val" indicates the mux value to be applied. > + - description: | > + "input_val" gives the select input value to be applied. > + - description: | > + "pad_setting" gives the pad configuration value to be applied. > > > > > > The dts files should then be bracketed accordingly. > > Sorry, what do you mean of "dts files should then be bracketed accordingly"? > Do you mean dts file needs to be updated? I saw below example already has "<>" for > This matrix: > > + fsl,pins = < > + 0x234 0x49C 0x4F4 0x0 0x0 0x49 > + 0x238 0x4A0 0x4F4 0x0 0x0 0x49 > + >; > > Can you please advise and provide a simple example, I think we should avoid changes > In dts file. Like this: fsl,pins = <0x234 0x49C 0x4F4 0x0 0x0 0x49>, <0x238 0x4A0 0x4F4 0x0 0x0 0x49>; The changes are unavoidable (though not something you're expected to fix immediately). We simply can't just accept any bracketing in dts files *and* have schema to validate them. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel