From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D52A9C32792 for ; Mon, 30 Sep 2019 18:37:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A6886224D7 for ; Mon, 30 Sep 2019 18:37:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="K+xS0j67"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yzJe07xv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6886224D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2bXOX6WxZygYaFR4xZw4mSz+9Y9OvOJL1xH5VuOnMMc=; b=K+xS0j67mhhYL8 iEHxsPYBHUepmWGQzPg4eWO0NvN/Iq3OmC/GGcCkYUtrJwBaLjjETQUdTqBgnZZuIlRPiyRCoWbEq YwPRf1hplHlTTDAYXoX1hKV/LKiMjaXmsxPij9ZPTUSOT0rYgF7CLYxmg3Zdvs42NUEnMK7b1/sAh tresYHnoUOoyioFBJHDYmATKCAhcmSpfX6vP0Z+ydcGAji/03eNcZAUQ/mMJuvgNDTUS8pk5N7SAJ 0ZNeR5eNRQboi3SYng7MEnB2BaOTMdiPgQk5e+S0dQKAlZ4DjwI5VQmC2H/IpBsbAcT5Fv2jhwj13 YDKD4dUP16SfojVPDMQQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iF0Y7-0004TP-Go; Mon, 30 Sep 2019 18:37:31 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iF0X4-0002vW-AP for linux-arm-kernel@lists.infradead.org; Mon, 30 Sep 2019 18:36:32 +0000 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ED011224F0 for ; Mon, 30 Sep 2019 18:36:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569868585; bh=Ve9EmbsF4R2T7X2AuYWHttWGyO9wXFWxIJj8J5eaoDE=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=yzJe07xvPb1X/lMsvcEm9s7vhsjgVOtzM9TWeZHjaB6SLT95m7stqvhjKv5aoL7rF Au6KFV0YzVNY/d8PPnLGj3ZffNV6bhGsyW4EAI74hjCyGKOggKvZZhxHwI07PtdV04 xhw2ONm0tks6XUhVlyIWpOQbiYQE0ucMo3m+y1GI= Received: by mail-qk1-f171.google.com with SMTP id h126so8702882qke.10 for ; Mon, 30 Sep 2019 11:36:24 -0700 (PDT) X-Gm-Message-State: APjAAAVCnuqJzMpydB5ATyABGeR08Ev8mt4jRi7hsWpIOt3ncFS+/U0B ezLoox3dJbaGRj/pQdPhAl2G1lG8/N3fz4lqVA== X-Google-Smtp-Source: APXvYqy2xChitegAmEHzNRbHSSH0nQKcTnaviLTzqyZbMb41lnr9tCCoVkEfo/b9C0IczxPJCD2HaN7s56mcLD1ZT6M= X-Received: by 2002:a05:620a:12d5:: with SMTP id e21mr1643941qkl.152.1569868584102; Mon, 30 Sep 2019 11:36:24 -0700 (PDT) MIME-Version: 1.0 References: <20e142e236decbed1b890ef455c5a1ddbdb48b9d.1569851517.git.robin.murphy@arm.com> In-Reply-To: <20e142e236decbed1b890ef455c5a1ddbdb48b9d.1569851517.git.robin.murphy@arm.com> From: Rob Herring Date: Mon, 30 Sep 2019 13:36:13 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 2/3] iommu/io-pgtable-arm: Support all Mali configurations To: Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190930_113630_402633_FD598684 X-CRM114-Status: GOOD ( 16.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , Neil Armstrong , Joerg Roedel , Steven Price , Linux IOMMU , Will Deacon , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 30, 2019 at 9:11 AM Robin Murphy wrote: > > In principle, Midgard GPUs supporting smaller VA sizes should only > require 3-level pagetables, since level 0 only resolves bits 48:40 of > the address. However, the kbase driver does not appear to have any > notion of a variable start level, and empirically T720 and T820 rapidly > blow up with translation faults unless given a full 4-level table, > despite only supporting a 33-bit VA size. > > The 'real' IAS value is still valuable in terms of validating addresses > on map/unmap, so tweak the allocator to allow smaller values while still > forcing the resultant tables to the full 4 levels. As far as I can test, > this should make all known Midgard variants happy. > > Fixes: d08d42de6432 ("iommu: io-pgtable: Add ARM Mali midgard MMU page table format") > Tested-by: Neil Armstrong > Reviewed-by: Steven Price > Signed-off-by: Robin Murphy > --- > drivers/iommu/io-pgtable-arm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) Reviewed-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel