From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A36DC2D0F1 for ; Tue, 31 Mar 2020 16:17:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F389B20786 for ; Tue, 31 Mar 2020 16:17:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OPT5jsQc"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qexlpxKB"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="w9kKXD8z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F389B20786 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IK0ERJHmmAETI1jSxQX7oD4G+4blx/ozydSs3c5tHes=; b=OPT5jsQciBA9u4 Ptcbo9wQJipayrasFg1/wirk5ZrF5MsKg6gAB5tzWVDCwtHhYI9zWOvDZXEh9p3E3G74pmC3N2n9p ntJC8mLbWNMWmlxaVbeJ+e9gHu+7CM1BEaO5xmTrH+54pYRUvaSUdfP4Cq+eUrDofymlfL/D3tz3j C0Lz785czZTYp7RU9+AzkT5wZdiB5iDH6OsnYpVZK0E7bfNIYDBjpO88mVOzYKv0sHj6vVBdowX6W TfPVi7adiiGB5PL6FSK8iylCEuOhu3L20kEE3C0vC2vX6YDXTwn/efyt4Gkr24YXuRqFxVLy4fy1M pwGsSNOXOLXnoFjtwfYg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJZj-00043k-7C; Tue, 31 Mar 2020 16:17:15 +0000 Received: from merlin.infradead.org ([2001:8b0:10b:1231::1]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJJZF-0003en-Kz; Tue, 31 Mar 2020 16:16:45 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=merlin.20170209; h=Content-Type:Cc:To:Subject:Message-ID: Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=IK9k6BsytbnW1EXy7FI1eJsDUE+tu84D7QZT4uS5ZlU=; b=qexlpxKBLryiGBX+iCkyUSOeTz 5JQ6Br7SWcZmqQv5hE3fT0P4eW4wtZWGuDas8jasGbqTAAvj+y+7eaCi+hapSePOquQ1HQQl8Gls/ G5aIE+GVHy0L8CwcXlx4VLBoZeag++QtxcgQH6H8IbMEoUHN6WAayUf+91dhFuuulif6gBS7ZZcEc 7Mcp1dOuOaNoyQyythrowVTGR53opccKTgQForYVkgQWEI+aw1D03V6ZWxRtI/l5fuqfu2hizna4y 3XtRqtcEWEKhqLncBRRbYA6jlXZ4vtT6LInIqkQH6V9O+roqqQ1p2VKTdANMMXlehBltLdKvNtGuV b3/ZWLbA==; Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jJI2s-0004FN-Le; Tue, 31 Mar 2020 14:39:15 +0000 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AA89E2145D; Tue, 31 Mar 2020 14:39:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585665552; bh=VQTYjDLJpBPL64v+KHcwfSavLEUmQ5VPbYuKeDQvfh4=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=w9kKXD8z4sqI86PU33XbHmfq5R7o1rl1Yc6oUOAz42cwHppv6UAYyiBVNzHr/8rGq fiuijzJ4syHgX49+YFivKcsWhdJV6fv/bOG69I3vdo0Lq1npTDVuNQt+ItarZp4b9G a/bP28cpaoxY9yg7N1tSpyTZfOjD00o0nNDF4FO0= Received: by mail-qk1-f178.google.com with SMTP id j4so23141537qkc.11; Tue, 31 Mar 2020 07:39:12 -0700 (PDT) X-Gm-Message-State: ANhLgQ1LnmuRsJnnhlBo2Ivk2BrFcJvuVj30abEykvUd6WYzUXI01EM9 Aq/2I/R+jgiiyfruAU4QAsJG8of+ukWxSFKoSg== X-Google-Smtp-Source: ADFU+vs96kIPVk/bUhQUvXuwHTzxBhEjf4smiGd+iZOn7jyc5rfIytLi140jinW+le6E+iSeEnGKe3qbfJEIB3it89g= X-Received: by 2002:a37:aa92:: with SMTP id t140mr4802134qke.119.1585665551704; Tue, 31 Mar 2020 07:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20200325220542.19189-1-robh@kernel.org> <20200325220542.19189-5-robh@kernel.org> In-Reply-To: From: Rob Herring Date: Tue, 31 Mar 2020 08:39:00 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/4] dt-bindings: Add missing 'additionalProperties: false' To: Masahiro Yamada X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , "open list:IIO SUBSYSTEM AND DRIVERS" , Linus Walleij , dri-devel , Linux Kernel Mailing List , Guillaume La Roque , Peter Meerwald-Stadler , Lee Jones , linux-clk , Lars-Peter Clausen , Kevin Hilman , Daniel Lezcano , Bartosz Golaszewski , Zhang Rui , Brian Masney , DTML , Michael Hennerich , Linux PM mailing list , linux-arm-msm , Mauro Carvalho Chehab , "open list:GPIO SUBSYSTEM" , Mark Brown , "open list:ARM/Amlogic Meson..." , Thomas Gleixner , Bjorn Andersson , linux-arm-kernel , Stephen Boyd , Networking , Liam Girdwood , Hartmut Knaack , Linux Media Mailing List , "David S. Miller" , Jonathan Cameron Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Mar 30, 2020 at 2:38 AM Masahiro Yamada wrote: > > Hi Rob, > > On Mon, Mar 30, 2020 at 4:09 PM Masahiro Yamada wrote: > > > > On Thu, Mar 26, 2020 at 7:06 AM Rob Herring wrote: > > > > > > Setting 'additionalProperties: false' is frequently omitted, but is > > > important in order to check that there aren't extra undocumented > > > properties in a binding. > > > > > > Ideally, we'd just add this automatically and make this the default, but > > > there's some cases where it doesn't work. For example, if a common > > > schema is referenced, then properties in the common schema aren't part > > > of what's considered for 'additionalProperties'. Also, sometimes there > > > are bus specific properties such as 'spi-max-frequency' that go into > > > bus child nodes, but aren't defined in the child node's schema. > > > > > > So let's stick with the json-schema defined default and add > > > 'additionalProperties: false' where needed. This will be a continual > > > review comment and game of wack-a-mole. > > > > > > Signed-off-by: Rob Herring > > > --- > > > > > > > .../devicetree/bindings/gpio/socionext,uniphier-gpio.yaml | 2 ++ > > > > > > You may have already queue this up, but just in case. > > > > Acked-by: Masahiro Yamada > > > > I take back Ack for socionext,uniphier-gpio.yaml > > > > Now "make dt_binding_check" produces a new warning. > > gpio@55000000: 'interrupt-parent' does not match any of the regexes: > 'pinctrl-[0-9]+' > > > This binding uses 'interrupt-parent' > without 'interrupts'. > > Instead, the mapping of the interrupt numbers > is specified by the vendor-specific property > socionext,interrupt-ranges > > > > I cannot add "interrupt-parent: true" because > dt-schema/meta-schemas/interrupts.yaml > has "interrupt-parent: false". > > > Is there any solution? I'd meant to just drop socionext,uniphier-gpio.yaml. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel