Re: [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding

From: Rob Herring <robh@kernel.org>
To: Dong Aisheng <dongas86@gmail.com>
Cc: Dong Aisheng <aisheng.dong@nxp.com>,
	Sascha Hauer <kernel@pengutronix.de>,
	 devicetree <devicetree@vger.kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	 dl-linux-imx <linux-imx@nxp.com>,
	 "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 6/7] dt-bindings: soc: imx: add missing iomuxc gpr binding
Date: Wed, 28 Jul 2021 11:30:19 -0600	[thread overview]
Message-ID: <CAL_JsqLZLK75pj_HQDNY1CtHuKGRx-u36eDOyr8ObkR==GW6gQ@mail.gmail.com> (raw)
In-Reply-To: <CAA+hA=TsEfz9Zo3wfsf6ZXnYHtfv5AbGNqVQEMn0q0bh1TOQDQ@mail.gmail.com>

On Thu, Jul 15, 2021 at 9:30 PM Dong Aisheng <dongas86@gmail.com> wrote:
>
> Hi Rob,
>
> On Thu, Jul 15, 2021 at 9:54 PM Rob Herring <robh@kernel.org> wrote:
> >
> > On Thu, 15 Jul 2021 16:25:35 +0800, Dong Aisheng wrote:
> > > The General Purpose Registers IOMUXC_GPR are used to select operating
> > > modes for general features in the SoC, usually not related to the IOMUX
> > > itself.
> > >
> > > This binding doc is generated based on the exist usage in dts
> > > in order to fix dt schema check failures.
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  .../devicetree/bindings/soc/imx/fsl,gpr.yaml  | 69 +++++++++++++++++++
> > >  1 file changed, 69 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml
> > >
> >
> > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mfd/syscon.example.dt.yaml: iomuxc-gpr@20e0000: compatible: 'oneOf' conditional failed, one must be fixed:
> >         ['fsl,imx6q-iomuxc-gpr', 'syscon'] is too short
> >         'fsl,imx53-iomuxc-gpr' was expected
> >         'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx6sl-iomuxc-gpr', 'fsl,imx6sll-iomuxc-gpr', 'fsl,imx6sx-iomuxc-gpr', 'fsl,imx6ul-iomuxc-gpr', 'fsl,imx7d-iomuxc-gpr']
> >         'fsl,imx7d-iomuxc-gpr' was expected
> >         'fsl,imx8mq-iomuxc-gpr' was expected
> >         'fsl,imx6q-iomuxc-gpr' is not one of ['fsl,imx8mm-iomuxc-gpr', 'fsl,imx8mn-iomuxc-gpr', 'fsl,imx8mp-iomuxc-gpr']
> >         'fsl,imx6q-iomuxc-gpr' was expected
> >         From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/imx/fsl,gpr.yaml
> > \ndoc reference errors (make refcheckdocs):
> > Warning: MAINTAINERS references a file that doesn't exist: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
> > MAINTAINERS: Documentation/devicetree/bindings/spi/spi-nxp-fspi.txt
>
> The example in syscon.yaml is invalid and needs change as follows.
> However, should I do it in a separate patch cause they're changes for
> two irrelevant binding
> files or merge into this one ?

Separate patch.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index f14ae6da0068..11eae4c5848e 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -90,7 +90,7 @@ examples:
>
>    - |
>      gpr: iomuxc-gpr@20e0000 {
> -        compatible = "fsl,imx6q-iomuxc-gpr", "syscon";
> +        compatible = "fsl,imx6q-iomuxc-gpr", "syscon", "mfd";

I assume you mean 'simple-mfd'?

Adding that means this example doesn't really even match the
syscon.yaml, so I'd just drop the example.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel