From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 895C4C54FC9 for ; Tue, 21 Apr 2020 19:03:21 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65B77206D4 for ; Tue, 21 Apr 2020 19:03:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pw942aPk"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="OxQ7rPaF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65B77206D4 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HJaoIsYYqWZCNnYfTW6pSHELKsVKXKzBliIwTBBAYu4=; b=Pw942aPkMXpdXE lNrtuB6Lvq5LZjXINWxQLEAihgX6hHkiobgYJq/PaJXGc7TUDM6LfLY8T4ONO374dBDkvM/tGZQTo Zg1W2/5lif1fL8oDIVYN5Az9KwDRj1wKsUvQXYHHEC4taCAhikBq+sLfG13zesgickndjkEqk2hOl CDO8UrRvB2BIWQXQvgAuS+YnJskMzwiD3jiqufNsWLgoAnJqzIDOImyAwTNXyOmY1XSqf99g4vllE ncv0YDgpx0o8TA/lD/p3qOizyZqi4PPJTpboZg9kjNp1lZtmdGxFrOosNkb7rsWndP8MXdEGU4izM cqhQYflH0vzqoZNciZ5w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQyAs-00010n-PA; Tue, 21 Apr 2020 19:03:14 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jQyAp-0000zE-5C for linux-arm-kernel@lists.infradead.org; Tue, 21 Apr 2020 19:03:12 +0000 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C10C92072D for ; Tue, 21 Apr 2020 19:03:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587495789; bh=zzuxna0xb8Q1TdC2MB2c2yaiRdzpJ1eGR8Ub8HY5Gd8=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=OxQ7rPaFtXQrWe3Td6ny9BtnD1TQh3P7QOD972q8srd5+AgucSbkxk6uYjIfh+m7N F8Ncj568tjXPTszHVSxio8YtYRoejRoEgjSh/gfxoL8PW8ZNR3z6gvQhx7hA298dIA i/qjotI3hA3MP5fcZf7qR2gN9Ea7AFgg6exLJPTA= Received: by mail-qk1-f176.google.com with SMTP id l78so15679880qke.7 for ; Tue, 21 Apr 2020 12:03:09 -0700 (PDT) X-Gm-Message-State: AGi0PuZyOLJkMx6fYnh2A0656UlIyDPwUarBmvd2xz9vys4Ddq2KGvgB JdI92F2JYOrdcd+7JLt8It2uhsQhx3nZc14hnw== X-Google-Smtp-Source: APiQypK4Yv9pvWyQXJx3JdeSn124hpxtt1JLCDuQWjVYKhF0tbCsvIrqP7V2PBuV1TcfREEdndVuo0ZBbnynFvkhgvg= X-Received: by 2002:a37:4a85:: with SMTP id x127mr23060837qka.152.1587495788872; Tue, 21 Apr 2020 12:03:08 -0700 (PDT) MIME-Version: 1.0 References: <06fb6569259bb9183d0a0d0fe70ec4f3033b8aab.1586939718.git.hns@goldelico.com> <20200416204158.GA1006@bogus> In-Reply-To: From: Rob Herring Date: Tue, 21 Apr 2020 14:02:56 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 01/12] dt-bindings: add img, pvrsgx.yaml for Imagination GPUs To: "H. Nikolaus Schaller" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200421_120311_256395_CAEC31C2 X-CRM114-Status: GOOD ( 20.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Thomas Bogendoerfer , Philipp Rossak , linux-omap , David Airlie , OpenPVRSGX Linux Driver Group , "linux-kernel@vger.kernel.org" , dri-devel , "open list:MIPS" , Chen-Yu Tsai , linux-samsung-soc , Daniel Vetter , kernel@pyra-handheld.com, Discussions about the Letux Kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Apr 17, 2020 at 7:16 AM H. Nikolaus Schaller wrote: > > Hi Rob, > > > Am 16.04.2020 um 22:41 schrieb Rob Herring : > > > > On Wed, 15 Apr 2020 10:35:08 +0200, "H. Nikolaus Schaller" wrote: > >> The Imagination PVR/SGX GPU is part of several SoC from > >> multiple vendors, e.g. TI OMAP, Ingenic JZ4780, Intel Poulsbo, > >> Allwinner A83 and others. > >> > >> With this binding, we describe how the SGX processor is > >> interfaced to the SoC (registers, interrupt etc.). > >> > >> In most cases, Clock, Reset and power management is handled > >> by a parent node or elsewhere (e.g. code in the driver). > >> > >> Tested by make dt_binding_check dtbs_check > >> > >> Signed-off-by: H. Nikolaus Schaller > >> --- > >> .../devicetree/bindings/gpu/img,pvrsgx.yaml | 122 ++++++++++++++++++ > >> 1 file changed, 122 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml > >> > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > Documentation/devicetree/bindings/gpu/img,pvrsgx.yaml: while parsing a block mapping > > in "", line 74, column 13 > > It turned out that there was a stray " in line 74 from the last editing phase. > Will be fixed in v7. > > Would it be possible to make dt_binding_check not only report line/column but the > contents of the line instead of ""? This comes from ruamel.yaml module. I believe "" is supposed to be the type of the data, not what it is. However, it is possible to get something a bit more helpful, but it depends on which parser is used. By default we use the C based parser (aka 'safe'). If we use the round trip parser, we get this: ruamel.yaml.scanner.ScannerError: while scanning a simple key in "", line 84, column 5: maxItems ^ (line: 84) This can be enabled by passing '-n' (line numbers) to dt-doc-validate. Currently, you have have to edit the Makefile to do this. The C parser is a big difference in speed, so I don't want to change the default. I can probably work around this and dump the erroring line, but I'm not sure that's always useful. Many errors are indentation related and those need some context. Plus just dumping the line can be done easily with sed: sed -n ${LINE}p Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel