From: Rob Herring <robh@kernel.org>
To: Peng Fan <peng.fan@nxp.com>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
Aisheng Dong <aisheng.dong@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
Alice Guo <alice.guo@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: imx: drop "fsl,aips-bus"
Date: Tue, 14 Jan 2020 08:39:19 -0600 [thread overview]
Message-ID: <CAL_JsqLsQmvM0Qsspj5n+1iy5X0TXaULonGtjKRkdOoSQVQmzw@mail.gmail.com> (raw)
In-Reply-To: <AM0PR04MB4481917D6A969053CB85276F883C0@AM0PR04MB4481.eurprd04.prod.outlook.com>
On Sun, Jan 5, 2020 at 8:38 PM Peng Fan <peng.fan@nxp.com> wrote:
>
> Hi Rob,
>
> > Subject: Re: [PATCH] ARM: dts: imx: drop "fsl,aips-bus"
> >
> > On Mon, Dec 30, 2019 at 08:58:05AM +0000, Peng Fan wrote:
> > > From: Peng Fan <peng.fan@nxp.com>
> > >
> > > There is no binding doc for "fsl,aips-bus", "simple-bus" is enough for
> > > aips usage, so drop it.
> >
> > NAK. The AIPS bus has registers, so 'simple-bus' alone is not enough.
>
> You mean the "reg" property below, right?
> aips-bus@2000000 { /* AIPS1 */
> - compatible = "fsl,aips-bus", "simple-bus";
> + compatible = "simple-bus";
> #address-cells = <1>;
> #size-cells = <1>;
> reg = <0x02000000 0x100000>;
>
> But the reg property is not required, I think it could be removed.
> There is no binding doc and driver for "fsl,aips-bus", so I think
> It not make sense to have that compatible in dts.
Well, there should be a binding doc, but whether or not there's a
driver is irrelevant.
From what I remember, either AIPS or SPBA bus has registers to allow
user mode access or not. Something may need to configure those and it
may want to use DT info to do that. It's not just Linux that you need
to think about.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-01-14 14:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-30 8:58 [PATCH] ARM: dts: imx: drop "fsl,aips-bus" Peng Fan
2020-01-04 0:36 ` Rob Herring
2020-01-06 2:38 ` Peng Fan
2020-01-14 14:39 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAL_JsqLsQmvM0Qsspj5n+1iy5X0TXaULonGtjKRkdOoSQVQmzw@mail.gmail.com \
--to=robh@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=alice.guo@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=peng.fan@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).