From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AA575C43460 for ; Thu, 20 May 2021 19:24:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DF9E611AD for ; Thu, 20 May 2021 19:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DF9E611AD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gpez7gfq2BR6mPugfSToPLQjVqIUVEVYO8QKLdVEp68=; b=bSbQZ/UIpmmsW1yBEw6pYuSEiw te7mAt+YOtusYrg22mb0vPfSZaxPS2lLkEwYGuhFgIq9fJAvMA6nRY+M2HW3K6iDDjMno/8EPRKdH f8j2mBX0J7hYTQCivDMijtRtiTORqhKr+p2eqrl/XKDtXiTtM8oklEtl4Dl3tMjoN5ZmBHb7pEn7K RBYzOAN8ggunko8+yijsk4tWzUmd8jq1PZ8gQ5gMCYip8+L5FV+okRoo4oVWtqKShdRVQkAmtvrg0 A7pq4LOX1qY57XJxr10Yuebtlwkt7SyoE68DL0kFyjPaaKrMLqLXaCzgir9iH4mLLwednFUviyAP3 bxZxq7Ow==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljoFU-002U04-5I; Thu, 20 May 2021 19:22:24 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ljoFG-002Tz5-Ca for linux-arm-kernel@desiato.infradead.org; Thu, 20 May 2021 19:22:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ME01Ct3ULfaLMQcdQrA2XAXOaI7/bLIcD4nJUCwVX9c=; b=Iw/dPv8pksn4jyrKR2eHDq/H5Y xMHwp3cP+zEXvxIMvKHDa0gT0XwUsWh595SAstZpRY/D4ARVp3OVlPqbxzWTPpbXCGIdheJjaU+ic HFSX+p569qMbz7CkTLGTjf01CSD2MmNcLgp88sExRSFeGnVygP3H2JwUStFqUV/kx8amZxkmtOe5+ C7t9n6EqxMJPdUpMwU51RfCGJXpHo2CkWi4kaGICEX5GCerfxKFSDqwT1oHwvL1fFQiUpF9p/dC54 1CN9P3s1LWRSYjDjvDVygk3/Q5HnnvK25cynAKrBpCKmCdxTMGMedYGI++Je5pkqFL1OhUb/MvhdL 84KlvWUw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ljoFD-00GcHG-EF for linux-arm-kernel@lists.infradead.org; Thu, 20 May 2021 19:22:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 1D2916124C for ; Thu, 20 May 2021 19:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621538527; bh=pGj2m21Rr+RedlO3zLbZQ5wKNm5upkIVwCyZCTL3B9k=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=DR8vXQti4Bohj4xOM6/m2X1atmGoljVVLkFdIBBK5fZXIpPyGtMc39lKURvUPueaj dJvjy+/kkXeeccvCa3WIw47WoTPLXne8CArTSUtHWrPvsK97xgRsnvmddBlWd+89LB k/hWLmf7jAbshtEjLwUy7Vo92ZKvuF6fTHUGNS4XlBruDC81g4LCUJxqVDZMLUOFQB 2naTIhBbey/krvwRiL3c6X4muxpNNKhPN5e5oiWG6JmQF5J2E5ORqZnoU6jRApANjt I8p2VorD9UgSyKYQmVVU23BvWNbOa/8hM0cwpjpG6oX+lvB8EDGK8ubXDOo9cNn91T dqeccufeGsabg== Received: by mail-ej1-f50.google.com with SMTP id et19so19967877ejc.4 for ; Thu, 20 May 2021 12:22:07 -0700 (PDT) X-Gm-Message-State: AOAM532Y/bgEeANZnhw9SqrHSNhyouW1+BkN7fxkbCRG3NeuZ49sJ1HU 6J10nf6+AQ4UzOsBHj3yzug/cd0MRuY0jEp2/g== X-Google-Smtp-Source: ABdhPJxUYGX9fGlR21dCfAS6UFpl3PZ3Xg3sofjrWFaR6sA8n+7gw/W9/kl0GkjNISyhZAYmu+po9iwLSFeAtV5X/08= X-Received: by 2002:a17:907:76e8:: with SMTP id kg8mr5885360ejc.130.1621538525633; Thu, 20 May 2021 12:22:05 -0700 (PDT) MIME-Version: 1.0 References: <20210518172022.10562-1-s-anna@ti.com> <20210520000831.GA3927464@robh.at.kernel.org> In-Reply-To: From: Rob Herring Date: Thu, 20 May 2021 14:21:54 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML To: Suman Anna Cc: Jassi Brar , Tony Lindgren , Nishanth Menon , Jan Kiszka , devicetree@vger.kernel.org, linux-omap , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210520_122207_541144_A27EF7F0 X-CRM114-Status: GOOD ( 29.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, May 20, 2021 at 11:45 AM Suman Anna wrote: > > On 5/19/21 7:08 PM, Rob Herring wrote: > > On Wed, May 19, 2021 at 10:14:14AM -0500, Suman Anna wrote: > >> On 5/18/21 12:20 PM, Suman Anna wrote: > >>> Convert the current OMAP Mailbox binding from text format to YAML > >>> format/DT schema, and delete the legacy text binding file. > >>> > >>> The new YAML binding conversion is an updated version compared to > >>> the original. The descriptions for certain properties have been > >>> improved to provide more clarity. Constraints are added to the > >>> properties 'ti,mbox-num-users', 'ti,mbox-num-fifos' and 'interrupts'. > >>> The 'ti,hwmods' is a legacy property and is retained only to reflect > >>> the existing usage on some older OMAP2 and OMAP3 platforms. > >>> > >>> All the existing examples have also been updated to reflect the > >>> latest dts nodes (ti,hwmods removed from OMAP4 and AM33xx examples, > >>> and interrupts value updated for AM65x SoCs). > >>> > >>> Signed-off-by: Suman Anna > >>> --- > >>> Hi, > >>> > >>> This patch does fix a number of dtbs_check warnings seen around OMAP Mailbox > >>> nodes with the latest kernel. There are few left-over warnings when just > >>> this patch is used on v5.13-rc1 or next-20210518. I have posted a separate > >>> fix for a warning on TI K3 SoCs [1], and will be posting a separate cleanup > >>> series for OMAP2+ SoCs. The dts patches can be picked up independently > >>> of this patch. > >> > >> FYI, All the dtbs_check warnings will be gone with [1] and the OMAP2+ cleanup > >> series [2]. > > > > Nice, though it is a moving target. :) Is that still true with the > > undocumented compatible checks that's been added? > > [1] is acked, so will definitely get picked up for the next merge window. Should > hit next sometime in the next couple of days. > > I didn't exactly understand your second comment, but no new compatibles were > added. The existing nodes are already in compliance with the constraints I added > (so that's strictly binding enforcements). These constraints are almost all on > legacy SoCs, so these do not pose any issues. When you say 'All the dtbs_check warnings', you mean *all* or just all the mailbox ones. I read as the former, but I guess from the prior paragraph and the links you are talking about, it's just mailbox warnings. Overall, this is what TI 32-bit warnings look like: Processing (am3|am4|am5|dra|keystone|omap|compulab|logicpd|elpida|motorola-cpcap|twl|da|dm): warnings: 60358 undocumented compat: 3195 This comes from my CI job[1]. The warnings aren't deduplicated, so 1 SoC warning expands to N board warnings. Only 3879 unique warnings. :) The top warnings are: arch/arm/boot/dts/(am3|am4|am5|dra|keystone|omap|compulab|logicpd|elpida|motorola-cpcap|twl|da|dm):60358:3879:3195 253 segment@0: 'anyOf' conditional failed, one must be fixed: 253 segment@0: $nodename:0: 'segment@0' does not match '^bus(@[0-9a-f]+)?$' 140 segment@200000: 'anyOf' conditional failed, one must be fixed: 140 segment@200000: $nodename:0: 'segment@200000' does not match '^bus(@[0-9a-f]+)?$' 128 0:0: /ocp/target-module@56000000: failed to match any schema with compatible: ['ti,sysc-omap4', 'ti,sysc'] 128 0:0: /ocp/target-module@50000000: failed to match any schema with compatible: ['ti,sysc-omap2', 'ti,sysc'] 128 0:0: /ocp/interconnect@48000000/segment@0/target-module@60000: failed to match any schema with compatible: ['ti,sysc-omap2', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@49032000: failed to match any schema with compatible: ['ti,sysc-omap2-timer', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@48320000: failed to match any schema with compatible: ['ti,sysc-omap2', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@48318000: failed to match any schema with compatible: ['ti,sysc-omap2-timer', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@48304000: failed to match any schema with compatible: ['ti,sysc-omap2-timer', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@480a0000: failed to match any schema with compatible: ['ti,sysc-omap2', 'ti,sysc'] 114 0:0: /ocp@68000000/target-module@48056000: failed to match any schema with compatible: ['ti,sysc-omap2', 'ti,sysc'] 114 0:0: /ocp@68000000/l4@48000000/scm@2000/scm_conf@270/pbias_regulator@2b0: failed to match any schema with compatible: ['ti,pbias-omap3', 'ti,pbias-omap'] 114 0:0: /ocp@68000000/l4@48000000/scm@2000/pinmux@a00: failed to match any schema with compatible: ['ti,omap3-padconf', 'pinctrl-single'] 114 0:0: /ocp@68000000/l4@48000000/scm@2000/pinmux@30: failed to match any schema with compatible: ['ti,omap3-padconf', 'pinctrl-single'] 112 0:0: /opp-table: failed to match any schema with compatible: ['operating-points-v2-ti-cpu'] 111 segment@100000: 'anyOf' conditional failed, one must be fixed: 111 segment@100000: $nodename:0: 'segment@100000' does not match '^bus(@[0-9a-f]+)?$' 108 0:0: /soc: failed to match any schema with compatible: ['ti,omap-infra'] Rob [1] https://gitlab.com/robherring/linux-dt/-/jobs/1261951514 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel