linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Bartosz Golaszewski <brgl@bgdev.pl>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Anand Ashok Dumbre <ANANDASH@xilinx.com>,
	Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	Michal Simek <michals@xilinx.com>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres
Date: Mon, 18 Jan 2021 10:09:56 +0100	[thread overview]
Message-ID: <CAMRc=MfJec9cM8Y7MDux-kd1cuFxy_OiZHU7v-FH3A96H0LHGg@mail.gmail.com> (raw)
In-Reply-To: <20201213120442.3f98814a@archlinux>

On Sun, Dec 13, 2020 at 1:04 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Fri, 11 Dec 2020 12:15:15 +0000
> Anand Ashok Dumbre <ANANDASH@xilinx.com> wrote:
>
> > > -----Original Message-----
> > > From: Jonathan Cameron <jic23@kernel.org>
> > > Sent: Monday 30 November 2020 8:21 PM
> > > To: Bartosz Golaszewski <brgl@bgdev.pl>
> > > Cc: Lars-Peter Clausen <lars@metafoo.de>; Peter Meerwald-Stadler
> > > <pmeerw@pmeerw.net>; Michal Simek <michals@xilinx.com>; linux-
> > > iio@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
> > > kernel@vger.kernel.org; Bartosz Golaszewski
> > > <bgolaszewski@baylibre.com>; Anand Ashok Dumbre
> > > <ANANDASH@xilinx.com>
> > > Subject: Re: [PATH v3 0/3] iio: adc: xilinx: use even more devres
> > >
> > > On Mon, 30 Nov 2020 15:27:56 +0100
> > > Bartosz Golaszewski <brgl@bgdev.pl> wrote:
> > >
> > > > From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
> > > >
> > > > This is a follow-up to commit 750628c79bb1 ("iio: adc: xilinx-xadc:
> > > > use devm_krealloc()"). I noticed we can use even more devres helpers
> > > > and entirely drop the remove() callback.
> > > >
> > > > v1 -> v2:
> > > > - squash three patches adding more devres calls into one for easier
> > > > review
> > > > - don't insist on the 80 characters limit
> > > > - add a new helper: devm_krealloc_array() and use it
> > > >
> > > > v2 -> v3:
> > > > - drop the devm_krealloc_array() helper
> > > >
> > > > Bartosz Golaszewski (3):
> > > >   iio: adc: xilinx: use helper variable for &pdev->dev
> > > >   iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc()
> > > >   iio: adc: xilinx: use more devres helpers and remove remove()
> > > >
> > > >  drivers/iio/adc/xilinx-xadc-core.c | 157
> > > > ++++++++++++++---------------
> > > >  1 file changed, 74 insertions(+), 83 deletions(-)
> > > >
> > >
> > > Series looks good to me but would like to leave it a little longer to let others
> > > take a look at it. That will probably mean it falls into next cycle now.
> > >
> > > +CC Anand who is looking at another series touching this driver and
> > > +might
> > > give this one a spin as well.
> > >
> > > Thanks,
> > >
> > > Jonathan
> >
> > Hi Jonathan, Bartosz,
> >
> > I have tested and reviewed the patch and everything looks good.
> > I have another patch series on the same files that might cause conflicts.
> >
> > Reviewed-by: Anand Ashok Dumbre <anandash@xilinx.com>
> > Tested-by: Anand Ashok Dumbre <anandash@xilinx.com>
> Thanks,
>
> Applied to the togreg branch of iio.git and pushed out as testing for
> the autobuilders to play with it.
>
> There was a small amount of fuzz.
>
> Thanks,
>
> Jonathan
>

Hi Jonathan,

I still don't see these patches in next - is any action required of me
to get this in for the next release?

Bartosz

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-18  9:11 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 14:27 [PATH v3 0/3] iio: adc: xilinx: use even more devres Bartosz Golaszewski
2020-11-30 14:27 ` [PATH v3 1/3] iio: adc: xilinx: use helper variable for &pdev->dev Bartosz Golaszewski
2020-11-30 14:27 ` [PATH v3 2/3] iio: adc: xilinx: use devm_krealloc() instead of kfree() + kcalloc() Bartosz Golaszewski
2020-11-30 14:27 ` [PATH v3 3/3] iio: adc: xilinx: use more devres helpers and remove remove() Bartosz Golaszewski
2020-11-30 14:30   ` Bartosz Golaszewski
2020-11-30 16:16     ` Jonathan Cameron
2020-11-30 20:21 ` [PATH v3 0/3] iio: adc: xilinx: use even more devres Jonathan Cameron
2020-12-11 12:15   ` Anand Ashok Dumbre
2020-12-13 12:04     ` Jonathan Cameron
2021-01-18  9:09       ` Bartosz Golaszewski [this message]
2021-01-18 13:38         ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAMRc=MfJec9cM8Y7MDux-kd1cuFxy_OiZHU7v-FH3A96H0LHGg@mail.gmail.com' \
    --to=brgl@bgdev.pl \
    --cc=ANANDASH@xilinx.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michals@xilinx.com \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).