From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60C07C433EF for ; Fri, 27 May 2022 00:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=chzOIJL5gEAnPG5zFgQzca2Wi8wzjQP6jbgEr1kq3ZA=; b=pZ7CVaRa4oQ34R tCzVepJvgkgJPFzMR0yo2WtGZNBVHn1Ep6fdaMbEVU8pPxGHeQJYjLEy52JtWObUjDMwsKZ0l+Phe eFSa67ZWs3e0gPJleRmIsBBsyvwNWhE7UuzAqI2Swa6musYSKHRilX2nW/0ED4jrRDQjFFwcpHp7u w2+3F0h30E5rxCutA9JCYadjPOt9hMcSH+DEWZiFo/Jz1c2jRlZiLYI8XJErqC2asYp4P8tDLOe8z p2du/rGQx+aVCghXhSRl1Pe2dKEzmBXg5A7qto8Mum2VLUod4Gx/FlIuiubbLVsbwL4Q+fQEG13Y6 2sVE7pHgkViqne8KifXg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuNsg-00GHJ2-WA; Fri, 27 May 2022 00:31:07 +0000 Received: from mail-yw1-x1135.google.com ([2607:f8b0:4864:20::1135]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nuNsd-00GHHO-13 for linux-arm-kernel@lists.infradead.org; Fri, 27 May 2022 00:31:05 +0000 Received: by mail-yw1-x1135.google.com with SMTP id 00721157ae682-300628e76f3so31994907b3.12 for ; Thu, 26 May 2022 17:30:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=elAhUcObwS39lh683eW5heCcXmPEhxRMz3DBXgxXh2M=; b=CBS7mjBjpPqYDkvZ0WwHMXyp+rrb87vDcuge2vvqwOUtirUtYAP2EdfR7XuC0joMTI r2yAaCV8OAIOUCcZGT4QsaplueeCxBdrniz9LXBgDz+8Lyy6T/eMNKvhsEsRwahwzgez LIssmvQdVrpQ2Cls1tnkK7Df9d1Y0nKTA9l9qxZBg7rZXb8YMqM9hrEEDN7sA/Iq9lr2 IvyFJQ+v6/35uscqaSJ/SyYAxFsCkkS26GyRbzNA6wU1s4ZD49uALpmSGL/dU6Lwe7Nk W2WCKbK5NvgB3x1Dzd3bD9uE7HvFMp1T3jswbZz8NDvryOWefk3OK7zIF3bwCm4jBNhx UEYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=elAhUcObwS39lh683eW5heCcXmPEhxRMz3DBXgxXh2M=; b=Yhh4tDCRh79ApI5R80g4nGjTVF9aYIxgiQozvShkrSryAxMBOajnoT+0zHk3eswyCD cwieTbNBy/Lmg0rzT273i4llhwm4TqJ7fKgNHvU5zmfiv83fPk/gyyX+mtKa4DLMsfKQ 1rxUPzMSlqnFBKyONYM3/v/zFZJEuessnsM23y0Um0UkVfEN8UOpNFiMChOjVYZwqw1w FZVQKS8hfUMUyV+sNIzXTriXfPzSW2/y7fbcvTAMv19X36xjdPzcq9GRpvD4m0cOBlL1 H6y5yw9epJ2Zkz5uLeJ4rc0SZ7jiEpXQr8RqMrb4eIGtHcgqGjYbdK1BwWSOKls0gDnj MO3w== X-Gm-Message-State: AOAM533cJq0CHJvIOVKEFLYIf1yG1wNZ+drlzQfvRaXwUGAzEiu83ZSQ 5QLb1R5T3HW/Ixr9uUvvrN8rA3fgXpssJrssBG8= X-Google-Smtp-Source: ABdhPJwviyj3IkTwElbYE9H3XujG8OQkn3xbfyZh0KNIESdd+4iOJCPPlcBD5I90t2/KDB5Uen6ITGRWz1hvnDRHWtk= X-Received: by 2002:a81:5ad6:0:b0:300:3244:341 with SMTP id o205-20020a815ad6000000b0030032440341mr15471202ywb.191.1653611454269; Thu, 26 May 2022 17:30:54 -0700 (PDT) MIME-Version: 1.0 References: <20220512135901.1377087-1-srinivas.neeli@xilinx.com> In-Reply-To: From: Vincent Mailhol Date: Fri, 27 May 2022 09:30:41 +0900 Message-ID: Subject: Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation (TDC) feature support To: Srinivas Neeli Cc: "wg@grandegger.com" , "mkl@pengutronix.de" , "davem@davemloft.net" , "edumazet@google.com" , Appana Durga Kedareswara Rao , Srinivas Goud , Michal Simek , "kuba@kernel.org" , "pabeni@redhat.com" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , git X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220526_173103_117035_300CA533 X-CRM114-Status: GOOD ( 45.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri. 27 May 2022 at 00:51, Srinivas Neeli wrote: > Hi Vincent, > > > -----Original Message----- > > From: Vincent Mailhol > > Sent: Friday, May 13, 2022 6:54 AM > > To: Srinivas Neeli > > Cc: wg@grandegger.com; mkl@pengutronix.de; davem@davemloft.net; > > edumazet@google.com; Appana Durga Kedareswara Rao > > ; Srinivas Goud ; Michal Simek > > ; kuba@kernel.org; pabeni@redhat.com; linux- > > can@vger.kernel.org; netdev@vger.kernel.org; linux-arm- > > kernel@lists.infradead.org; linux-kernel@vger.kernel.org; git > > > > Subject: Re: [PATCH] can: xilinx_can: Add Transmitter delay compensation > > (TDC) feature support > > > > On Fri. 13 May 2022 at 07:30, Srinivas Neeli > > wrote: > > > Added Transmitter delay compensation (TDC) feature support. > > > In the case of higher measured loop delay with higher baud rates, > > > observed bit stuff errors. > > > By enabling the TDC feature in a controller, will compensate for the > > > measure loop delay in the receive path. > > > TDC feature requires BRP values can be 1 or 2. > > > The current CAN framework does not limit the brp so while using TDC, > > > have to restrict BRP values. > > > Ex: > > > ip link set can0 type can tq 12 prop-seg 39 phase-seg1 20 phase-seg2 > > > 20 sjw 20 dtq 12 dprop-seg 5 dphase-seg1 6 dphase-seg2 4 dsjw 4 fd on > > > loopback on tdco 12 tdc-mode auto > > > > Did you experience some cases in which you had BRP > 2 and saw > > transmission errors due to the absence of delay compensation? Could you > > show the calculated values? > > Usually, you start to observe but stuff error at high bitrates (e.g. > > ~5MBPS), and for such bitrates, time quanta has to be small which then > > results in a small BRP. > > yes, we observed errors with higher baud rates(4 and 5 MBPS). > Observation: > BRPA 1Mbps Sampling 75% > BRPD 5MBPS Sampling 75% > On NXP PHY observed a delay of 160 ns. so observing the failure. > After enabling the TDC feature to work fine. Can you also share the results of: | ip --details link show can0 for both the automatic calculation by the CAN framework and for your hand calculated values? Thank you! > > > Signed-off-by: Srinivas Neeli > > > --- > > > drivers/net/can/xilinx_can.c | 30 +++++++++++++++++++++++++----- > > > 1 file changed, 25 insertions(+), 5 deletions(-) > > > > > > diff --git a/drivers/net/can/xilinx_can.c > > > b/drivers/net/can/xilinx_can.c index e2b15d29d15e..7af518fbed02 100644 > > > --- a/drivers/net/can/xilinx_can.c > > > +++ b/drivers/net/can/xilinx_can.c > > > @@ -1,7 +1,7 @@ > > > // SPDX-License-Identifier: GPL-2.0-or-later > > > /* Xilinx CAN device driver > > > * > > > - * Copyright (C) 2012 - 2014 Xilinx, Inc. > > > + * Copyright (C) 2012 - 2022 Xilinx, Inc. > > > * Copyright (C) 2009 PetaLogix. All rights reserved. > > > * Copyright (C) 2017 - 2018 Sandvik Mining and Construction Oy > > > * > > > @@ -133,6 +133,8 @@ enum xcan_reg { > > > #define XCAN_DLCR_BRS_MASK 0x04000000 /* BRS Mask in DLC */ > > > > > > /* CAN register bit shift - XCAN___SHIFT */ > > > +#define XCAN_BRPR_TDCO_SHIFT_CANFD 8 /* Transmitter Delay > > Compensation Offset */ > > > > Having CANFD in the name is redundant (TDC implies CANFD). > > #define XCAN_BRPR_TDCO_SHIFT 8 > update in V2. > > > > > > +#define XCAN_BRPR_TDCE_SHIFT_CANFD 16 /* Transmitter Delay > > Compensation (TDC) Enable */ > > > > Why not: > > #define XCAN_BRPR_TDC_ENABLE BIT(16) > update in V2. > > > > > > #define XCAN_BTR_SJW_SHIFT 7 /* Synchronous jump width */ > > > #define XCAN_BTR_TS2_SHIFT 4 /* Time segment 2 */ > > > #define XCAN_BTR_SJW_SHIFT_CANFD 16 /* Synchronous jump width > > */ > > > @@ -259,7 +261,7 @@ static const struct can_bittiming_const > > xcan_bittiming_const_canfd2 = { > > > .tseg2_min = 1, > > > .tseg2_max = 128, > > > .sjw_max = 128, > > > - .brp_min = 2, > > > + .brp_min = 1, > > > > Was there any reason to have brp_min = 2 in the first place? > > I think this change should be a different patch. If the brp_min = 2 is just a > > typo, you might also want to backport it to stable branches. > > On early silicon engineering samples we observed bit shrinking issue when we use brp =1 , hence we updated brp_min =2. > As in production silicon this issue is fixed we are planning to revert the patch. Great! > > > .brp_max = 256, > > > .brp_inc = 1, > > > }; > > > @@ -272,11 +274,21 @@ static struct can_bittiming_const > > xcan_data_bittiming_const_canfd2 = { > > > .tseg2_min = 1, > > > .tseg2_max = 16, > > > .sjw_max = 16, > > > - .brp_min = 2, > > > + .brp_min = 1, > > > .brp_max = 256, > > > .brp_inc = 1, > > > }; > > > > > > +/* Transmission Delay Compensation constants for CANFD2.0 and Versal > > > +*/ static const struct can_tdc_const xcan_tdc_const = { > > > + .tdcv_min = 0, > > > + .tdcv_max = 0, /* Manual mode not supported. */ > > > > Right, had a look at the datasheet and xilinx indeed does not support setting > > TDCV. > > However, xilinx still has a TDCV register to report the measured transmission > > delay. > > > > Socket CAN's TDC framework provides can_priv::do_get_auto_tdcv() to > > report the measured value through the netlink interface: > > https://elixir.bootlin.com/linux/v5.17/source/include/linux/can/dev.h#L87 > > > > Can you implement this call back function? > Will implement in V2. > > > > > > + .tdco_min = 0, > > > + .tdco_max = 64, > > > + .tdcf_min = 0, /* Filter window not supported */ > > > + .tdcf_max = 0, > > > +}; > > > + > > > /** > > > * xcan_write_reg_le - Write a value to the device register little endian > > > * @priv: Driver private data structure > > > @@ -425,6 +437,11 @@ static int xcan_set_bittiming(struct net_device > > *ndev) > > > priv->devtype.cantype == XAXI_CANFD_2_0) { > > > /* Setting Baud Rate prescalar value in F_BRPR Register */ > > > btr0 = dbt->brp - 1; > > > + if (can_tdc_is_enabled(&priv->can)) { > > > + btr0 = btr0 | > > > + (priv->can.tdc.tdco) << XCAN_BRPR_TDCO_SHIFT_CANFD | > > > + 1 << XCAN_BRPR_TDCE_SHIFT_CANFD; > > > > I don't think the parenthesis around (priv->can.tdc.tdco) are needed. > Yes, will update. > > > > btr0 = btr0 | > > priv->can.tdc.tdco << XCAN_BRPR_TDCO_SHIFT | > > XCAN_BRPR_TDC_ENABLE > > > > (c.f. above for macro names) > > > > > + } > > > > > > /* Setting Time Segment 1 in BTR Register */ > > > btr1 = dbt->prop_seg + dbt->phase_seg1 - 1; @@ > > > -1747,13 +1764,16 @@ static int xcan_probe(struct platform_device *pdev) > > > priv->can.data_bittiming_const = > > > &xcan_data_bittiming_const_canfd; > > > > > > - if (devtype->cantype == XAXI_CANFD_2_0) > > > + if (devtype->cantype == XAXI_CANFD_2_0) { > > > priv->can.data_bittiming_const = > > > &xcan_data_bittiming_const_canfd2; > > > + priv->can.tdc_const = &xcan_tdc_const; > > > + } > > > > > > if (devtype->cantype == XAXI_CANFD || > > > devtype->cantype == XAXI_CANFD_2_0) > > > - priv->can.ctrlmode_supported |= CAN_CTRLMODE_FD; > > > + priv->can.ctrlmode_supported |= CAN_CTRLMODE_FD | > > > + CAN_CTRLMODE_TDC_AUTO; > > > > > > priv->reg_base = addr; > > > priv->tx_max = tx_max; _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel