From: Peter Geis <pgwipeout@gmail.com>
To: Yifeng Zhao <yifeng.zhao@rock-chips.com>
Cc: Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
Vinod Koul <vkoul@kernel.org>,
Michael Riesch <michael.riesch@wolfvision.net>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
arm-mail-list <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-phy@lists.infradead.org,
Kishon Vijay Abraham I <kishon@ti.com>,
p.zabel@pengutronix.de
Subject: Re: [PATCH v1 0/3]
Date: Fri, 17 Sep 2021 13:21:58 -0400 [thread overview]
Message-ID: <CAMdYzYpo4mRqMRSF=chp4PhL609FKv_b3HHa0+7=ph2C_DfvuA@mail.gmail.com> (raw)
In-Reply-To: <20210826123844.8464-1-yifeng.zhao@rock-chips.com>
On Thu, Aug 26, 2021 at 8:42 AM Yifeng Zhao <yifeng.zhao@rock-chips.com> wrote:
>
> Add Naneng combo PHY support for RK3568
>
> This phy can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
Good Afternoon,
Some feedback on this driver, for when you resend it to the mailing list.
I'm sending this against the cover letter since the mailing list
doesn't have the actual driver.
The driver doesn't work out of the box, you renamed the clocks but
missed one use point.
There's a lot of "magic numbers" that need to be defined.
Configuration could use some cleanup.
A parallel problem, if the PCIe phy fails to probe (because of the
aforementioned clock issue) the PCIe controller hard locks the board
during probe.
I look forward to version two.
Very Respectfully,
Peter Geis
>
>
>
> Yifeng Zhao (3):
> dt-bindings: phy: rockchip: Add Naneng combo PHY bindings
> phy/rockchip: add naneng combo phy for RK3568
> arm64: dts: rockchip: add naneng combo phy nodes for rk3568
>
> .../phy/phy-rockchip-naneng-combphy.yaml | 100 +++
> arch/arm64/boot/dts/rockchip/rk356x.dtsi | 68 ++
> drivers/phy/rockchip/Kconfig | 8 +
> drivers/phy/rockchip/Makefile | 1 +
> .../rockchip/phy-rockchip-naneng-combphy.c | 646 ++++++++++++++++++
> 5 files changed, 823 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml
> create mode 100644 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c
>
> --
> 2.17.1
>
>
>
>
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-09-17 17:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 12:38 [PATCH v1 0/3] Yifeng Zhao
2021-08-26 12:38 ` [PATCH v1 1/3] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings Yifeng Zhao
2021-08-26 13:26 ` Rob Herring
2021-08-26 12:38 ` [PATCH v1 3/3] arm64: dts: rockchip: add naneng combo phy nodes for rk3568 Yifeng Zhao
2021-10-12 11:24 ` Nicolas Frattaroli
2021-09-17 17:21 ` Peter Geis [this message]
[not found] ` <20210826123844.8464-3-yifeng.zhao@rock-chips.com>
2021-10-12 7:36 ` [PATCH v1 2/3] phy/rockchip: add naneng combo phy for RK3568 Nicolas Frattaroli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMdYzYpo4mRqMRSF=chp4PhL609FKv_b3HHa0+7=ph2C_DfvuA@mail.gmail.com' \
--to=pgwipeout@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=michael.riesch@wolfvision.net \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).