From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0D284C433F5 for ; Fri, 22 Oct 2021 17:31:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CF5D860FF2 for ; Fri, 22 Oct 2021 17:31:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org CF5D860FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gDnCmwH9i6Xb8DZVI3OAB/AWiE+W+NSYD0pzdYt6FSk=; b=BJj4NFQwefGgVh WRUyqhk2JXM3dD4O2HV9edvtQmy2/oym5qtgJA0Rucjs23Z0UlDoSXwgtOPfZr5UZa78zqN30vxPa X0xbohBLpLSlTRLrwUjvFyz8TsEdikEaC3urNCjoU8axFZuILpNKlIzkrVv1G0L4VEEfnV7xHiFgQ /dGFeTxyOTtSJE4Eczm717knUk746BPRzQd/Go0glm7PF+FQWbXNeGPqZ9OSe9yfP5uk66Ky6RBZ2 lmeay/tItPJ+nUSqfT1mIURH0zZI8lSxNgy2FJ0P5F+7Epwns+mMYlSUk+icjw35F4exKy1AcY+6n ApIReAJaMcEfFG7nkDAA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdxto-00BZcO-4u; Fri, 22 Oct 2021 17:00:08 +0000 Received: from mail-io1-xd2c.google.com ([2607:f8b0:4864:20::d2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mdxtj-00BZbC-KP for linux-arm-kernel@lists.infradead.org; Fri, 22 Oct 2021 17:00:05 +0000 Received: by mail-io1-xd2c.google.com with SMTP id i189so6306351ioa.1 for ; Fri, 22 Oct 2021 10:00:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kTen2SJ5OXpwrB3GYaVSgs5PSr8Wl3SgV5Rb/nQHzy4=; b=OfBpCJAzSU6W7PZkLXvnp5uTA+iDkXVIdjqAMBeIpoljCUIE4H16rweL/sbBvPgjOz a7XnxBwIYdIryHPaHA7ppp+xRkuJ8ZkGtFQ917cYf6DXBKPw/S1sutxiZQufEACp4UpT PLnHHSzn4hQ4AhSAlnXGb0jGqcXGqNTs1nU6fnOh+AIxI5Q8oMN4iE7Fya+Xc4OOZBym rRn0MMZj1yiUeB/E8pchAg4wkBwHmXHOyXkKHbDeAue4CSfMCyDa4KbzZTr3JaR9+GBS VNmBEefGtXM9NaGbU0Rp/mPohCP047tLX02ikVEAVBUzcMC6NEhoorwouURdd7M5e8d/ nviw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kTen2SJ5OXpwrB3GYaVSgs5PSr8Wl3SgV5Rb/nQHzy4=; b=3QMoeD5yt0Ygk3NSA6pK++MhdUrbe+nGXK37Ac0mIKK9oxox+Z7Wa7aC8e+LaGUzRP xT8SZtn9DUrqHUVyLE1dRriOiCt9BAWOGX9TPhMiAYZ1D1Xp8ThqhdubB7ubJQ7gwIUo 8bZ2MV5MIFDsR6E1/aQenKzY79mFglIJS8WBqqAV3XJ6hRegos03b86P1oRPvuTWch5L QU3g2OEdBn3tZjrky7bfvPZAxcUh4slwLmhFSHLIkmObWn4rnmCl022TRPMvVFwUTpoW IVrhlnaHzSaxNVV3hSDuK/V+sQxArxGRF/Nq8gHu8Ed38fwiTdMA96mg9Xz6xGIU4aQa AORQ== X-Gm-Message-State: AOAM532i0VI4URmbwsFQmSwRNijmjrrmmLsWykt3YtMREeoz9xpoHj1Q jVOUhtSJfQXUd/qIeGsVKAr/3KNVry83DbbjvXIYCg== X-Google-Smtp-Source: ABdhPJzxQ0fZin7R9PkqV1UP1dkqBLaE11BhnPXYcqoa5W2nV/HynKJCgyp+2iBylPP9BT6beLI8s2+3hLU0rL6J7ec= X-Received: by 2002:a05:6602:168f:: with SMTP id s15mr547913iow.178.1634922001157; Fri, 22 Oct 2021 10:00:01 -0700 (PDT) MIME-Version: 1.0 References: <20210929000735.585237-1-saravanak@google.com> <20210929000735.585237-3-saravanak@google.com> In-Reply-To: From: Amit Pundir Date: Fri, 22 Oct 2021 22:29:24 +0530 Message-ID: Subject: Re: [PATCH v4 2/2] drivers: bus: Delete CONFIG_SIMPLE_PM_BUS To: Saravana Kannan Cc: Russell King , Neil Armstrong , Geert Uytterhoeven , Magnus Damm , Tony Lindgren , Catalin Marinas , Will Deacon , Damien Le Moal , Greg Kroah-Hartman , Ulf Hansson , Rob Herring , Android Kernel Team , linux-arm-kernel@lists.infradead.org, lkml , linux-oxnas@groups.io, linux-renesas-soc@vger.kernel.org, linux-omap@vger.kernel.org, linux-riscv@lists.infradead.org, Dmitry Baryshkov , John Stultz X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211022_100003_734522_9388755E X-CRM114-Status: GOOD ( 28.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 22 Oct 2021 at 05:13, Saravana Kannan wrote: > > On Thu, Oct 21, 2021 at 4:21 AM Amit Pundir wrote: > > > > Hi Saravana, > > > > This patch broke v5.15-rc6 on RB5 (sm8250 | qcom/qrb5165-rb5.dts). > > I can't boot past this point https://www.irccloud.com/pastebin/raw/Nv6ZwHmW. > > Amit top posting? How did that happen? :) > > The fact you are seeing this issue is super strange though. The driver > literally does nothing other than allowing some sync_state() callbacks > to happen. I also grepped for the occurence of "simple-bus" in > arch/arm64/boot/dts/qcom/ and the only instance for 8250 is for the > soc node. > > The only thing I can think of is that without my patch some > sync_state() callbacks weren't getting called and maybe it was masking > some other issue. > > Can you try to boot with this log (see log patch below) and see if the > device hangs right after a sync_state() callback? Also, looking at the > different sync_state() implementations in upstream, I'm guessing one > of the devices isn't voting for interconnect bandwidth when it should > have. > > Another thing you could do is boot without the simple-bus changes and > then look for all instances of "state_synced" in /sys/devices and then > see if any of them has the value "0" after boot up is complete. Turned out RB5 is not even reaching up to device_links_flush_sync_list() and seem to be stuck somewhere in device_links_driver_bound(). So I added more print logs to narrow down to any specific lock state but those additional prints seem to have added enough delay to unblock that particular driver (Serial: 8250/16550 driver if I understood the logs correctly) and I eventually booted to UI. On the booted RB5 *with* and *without* the simple-bus changes, I see 4 instances of "0" state_synced nodes at: /sys/devices/platform/soc@0/9100000.interconnect/state_synced /sys/devices/platform/soc@0/1500000.interconnect/state_synced /sys/devices/platform/soc@0/1740000.interconnect/state_synced /sys/devices/platform/soc@0/163d000.interconnect/state_synced Regards, Amit Pundir > > -Saravana > > -- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -1099,6 +1099,7 @@ static void device_links_flush_sync_list(struct > list_head *list, > if (dev != dont_lock_dev) > device_lock(dev); > > + dev_info(dev, "Calling sync_state()\n"); > if (dev->bus->sync_state) > dev->bus->sync_state(dev); > else if (dev->driver && dev->driver->sync_state) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel