From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC57CC433ED for ; Tue, 20 Apr 2021 16:12:47 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C11F613C9 for ; Tue, 20 Apr 2021 16:12:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C11F613C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/8YZg82wBCWjKlKJY9clOTntBCKrRB6b7NMJ0jA98p4=; b=oimOcpgUqTqtLtFUiPtAInpJd F8NJbOEFs0YSh6l20f6Y6m0UvIKW6sxHfp7nujiBnYaz88ti19GW6tj/Lazk4feqRV07KTxwy4Ild OU2mJ+3CAd35tHYipEv5pHXV+U3FG7Jp7W2tJvoNCShMnfKgTNBdAmerEoKGM9ha8UJPWblh+n78O tJgoHwzoJXnh/z9zXiwkhx3hwwSa014XAa30N+6yolpXwF4qtxdTANhcdfh4qu+RDrtRnTQettdqy ukY0Di6HIl4tkRQtQpIIOHe+p58RDraqQ2evYeqS5vn1mq5XSuWJOceMDjvuPL0a/rb+hDpNJajm7 Ue7qdp3JQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYsxZ-00CYEj-Kg; Tue, 20 Apr 2021 16:10:45 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYsxW-00CYET-Pd for linux-arm-kernel@desiato.infradead.org; Tue, 20 Apr 2021 16:10:43 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=1N7qLishPOeaVzhX7TWxEZwiSPC4YEjIwdzBRzm7nfw=; b=3j1gMKUnlveCu/f4n7gu8rx7p9 fVreNZioUCo38CBei9V1tFAaMCusRUdVp4MqjbsVvHCxunNDsIwIQxTuVHvdEEXlbGN8KlCwyH01M 3wuz1tDxt+RPlu2/PP2SHaQfAeSNEnalk3o1UPVHMmiRasCv0IIq5RKQh2k2K/ViC8Udck5l+g4cs S5gKeWYdZ3E5QczIMAj3QqhHlvD/+JO+Jm6Mt8VRfGcX7tvyhAv8JDLy7zciDRT+AAmJ2sx+Sy55w khbi0NG5V2BlpnGxaV+Sy2zQCe/1j2b90FuvvHJi9HtN112S85Rwt0VaBY4em6ah5f6zF+PKiSdCZ 4Xuc5Bng==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYsxU-00CGFX-5p for linux-arm-kernel@lists.infradead.org; Tue, 20 Apr 2021 16:10:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8C574613D3 for ; Tue, 20 Apr 2021 16:10:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1618935039; bh=JmvIBFjNFzY+Tbh/Rvhur6HjvhdR6YOR20xkk+tupLA=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=mo7Wq1Qo5/LMo+zGtDwSIGtakFBsrF4XZG0VFBhIfYWH2wSEc4Uqd6FtUKg8nMufW uonku8qX1V8WQXtLJIUtEEutxqewkPDlPLE8MPojwm6WiVjFo0L03jXrj8BSnFbrAj Kpplxep9BKuMpk6jp92VaVX3f49oTmqtV04ahy1ceyf0NGQmEleZWFf0mCEv+1Cgpz IlunToNhctxWLMe1YMtQAG9SDrGxk/rEHY+8bLnPBv3329Luadc3s+MCccmq7MS/uW 7CwyuCUamZxp/8eyBs7XnV8TFqnCuJJL4uHFiD4qwSJXG5cbQBG8xNb3rPC3DD5LCB hnElrtFD/CLWQ== Received: by mail-ot1-f48.google.com with SMTP id e89-20020a9d01e20000b0290294134181aeso10477363ote.5 for ; Tue, 20 Apr 2021 09:10:39 -0700 (PDT) X-Gm-Message-State: AOAM530C0FzyEs4MPMddhWMJGmRp9ldhCxUw7bS0SVQTnnunHYqA5l/R phbrbMxjpj69KQOpe5i9ElqdG4v33ZjQtHUuldE= X-Google-Smtp-Source: ABdhPJwJYzzV7y6P8YWEeQcFAUMKTStDy/CzVY5/ZIb5abLOvYetwnEASw2bBgIIB8EPcE2oeWurf5DhK/lCN3R/+mQ= X-Received: by 2002:a9d:311:: with SMTP id 17mr1508765otv.77.1618935038443; Tue, 20 Apr 2021 09:10:38 -0700 (PDT) MIME-Version: 1.0 References: <4a4734d6-49df-677b-71d3-b926c44d89a9@foss.st.com> <001f8550-b625-17d2-85a6-98a483557c70@foss.st.com> In-Reply-To: From: Ard Biesheuvel Date: Tue, 20 Apr 2021 18:10:27 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [v5.4 stable] arm: stm32: Regression observed on "no-map" reserved memory region To: Rob Herring Cc: Alexandre TORGUE , Quentin Perret , Greg Kroah-Hartman , Sasha Levin , stable , Arnd Bergmann , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , Nicolas Boichat , Stephen Boyd , Florian Fainelli , KarimAllah Ahmed , Android Kernel Team , Architecture Mailman List , Frank Rowand , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210420_091040_316258_9996AC4D X-CRM114-Status: GOOD ( 33.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Apr 2021 at 17:54, Rob Herring wrote: > > On Tue, Apr 20, 2021 at 10:12 AM Alexandre TORGUE > wrote: > > > > > > > > On 4/20/21 4:45 PM, Rob Herring wrote: > > > On Tue, Apr 20, 2021 at 9:03 AM Alexandre TORGUE > > > wrote: > > >> > > >> Hi, > > > > > > Greg or Sasha won't know what to do with this. Not sure who follows > > > the stable list either. Quentin sent the patch, but is not the author. > > > Given the patch in question is about consistency between EFI memory > > > map boot and DT memory map boot, copying EFI knowledgeable folks would > > > help (Ard B for starters). > > > > Ok thanks for the tips. I add Ard in the loop. > > Sigh. If it was only Ard I was suggesting I would have done that > myself. Now everyone on the patch in question and relevant lists are > Cc'ed. > Thanks for the cc. > > > > Ard, let me know if other people have to be directly added or if I have > > to resend to another mailing list. > > > > thanks > > alex > > > > > > > >> > > >> Since v5.4.102 I observe a regression on stm32mp1 platform: "no-map" > > >> reserved-memory regions are no more "reserved" and make part of the > > >> kernel System RAM. This causes allocation failure for devices which try > > >> to take a reserved-memory region. > > >> > > >> It has been introduced by the following path: > > >> > > >> "fdt: Properly handle "no-map" field in the memory region > > >> [ Upstream commit 86588296acbfb1591e92ba60221e95677ecadb43 ]" > > >> which replace memblock_remove by memblock_mark_nomap in no-map case. > > >> Why was this backported? It doesn't look like a bugfix to me. > > >> Reverting this patch it's fine. > > >> > > >> I add part of my DT (something is maybe wrong inside): > > >> > > >> memory@c0000000 { > > >> reg = <0xc0000000 0x20000000>; > > >> }; > > >> > > >> reserved-memory { > > >> #address-cells = <1>; > > >> #size-cells = <1>; > > >> ranges; > > >> > > >> gpu_reserved: gpu@d4000000 { > > >> reg = <0xd4000000 0x4000000>; > > >> no-map; > > >> }; > > >> }; > > >> > > >> Sorry if this issue has already been raised and discussed. > > >> Could you explain why it fails? The region is clearly part of system memory, and tagged as no-map, so the patch in itself is not unreasonable. However, we obviously have code that relies on how the region is represented in /proc/iomem, so it would be helpful to get some insight into why this is the case. In any case, the mere fact that this causes a regression should be sufficient justification to revert/withdraw it from v5.4, as I don't see a reason why it was merged there in the first place. (It has no fixes tag or cc:stable) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel