From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72D92C07E9B for ; Tue, 20 Jul 2021 12:41:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2DF2260C40 for ; Tue, 20 Jul 2021 12:41:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DF2260C40 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g52wGbfOfH0dIfPqASI+WV20F+NBYzwQGJWc0WmdnJw=; b=ssoJG0rO0fWMJG Fiwyu8oYZrnKtXS4pRx1GQaqz/s7FQ5slgGMhYyI0zzuSDScF4b3tqRxmOjFKuR9POnmghCQH326T hvsxcRCh/Drz8rJcGYobl6zcBRqOGg+OThXD3rnvHxIJ3u05f+A1SK9IHbTwjxE7YxRwkCCo0IOGE dHMOsWteM3287+1XoexX5+KIUslhuTQhoUGY6Z93Jh9bTMm81I5tHceSFyTXBGIWU96E2ZsBx0BCd vnl0wVA55aPD4VIK3L6nQ25Wpht0Aq1+LYO91oOjSWdXfwHPVo/7kVtyCt4YlCCAF1l1rvr/lRajO zAgaiQBSMZhyNWVisLXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5p2h-00CnQu-KH; Tue, 20 Jul 2021 12:40:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m5p2d-00CnQ2-E6 for linux-arm-kernel@lists.infradead.org; Tue, 20 Jul 2021 12:40:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 121D7611CE for ; Tue, 20 Jul 2021 12:40:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1626784807; bh=j5yVgUcbPHo9edWrwfukxKJRljArTBYReyh1q8GZdBs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=i2UbOfBgZahLU5oZHcy8xfhCmwtSLiE38CoeUbTaM7a0Qyjd+lynHPFItMnu+awu2 XPzU9u6C83A5j/HsVvQKQM7NGPcMdlKhWJmInEsgppF4iKBbxGE3gxWxyQ+TAZ0+If rzulp6ApCaalvE6Z/fiO9gNNPW/QTEXXv00ezjjs9JpQv6wN3h11+G5hqBcNM/LLWN kL1beiTmW3cS7Fydh4+JQTM6YEYmhGXH5DvL8BZugsu604aShJQjQbB9aeFeRNaSPb 5zv8b0pAXQiagXtKsl353tcPqUb7zO2Z57pLVdG5q6eRmUHgxRy1ZzwHpokaXcgy9H zdgGmMK98H4cA== Received: by mail-oi1-f170.google.com with SMTP id s23so8622681oiw.12 for ; Tue, 20 Jul 2021 05:40:07 -0700 (PDT) X-Gm-Message-State: AOAM531qj3QY3eUqBqvwq0fjOtqfg65Xc8s6aBoVFAdlWgSyNbT+3suY T8cegWYjuiruc8vBP5NHPiIzChE2iwvocwwYV/U= X-Google-Smtp-Source: ABdhPJznCVFG5AVEcej6pWCLuP8cHM9+9oqtLT/DitSVAeRRS1AIHXu2wfgZgjTZstv04lK9BZUf9hoBKzTnupH4WmE= X-Received: by 2002:aca:4c49:: with SMTP id z70mr20356509oia.174.1626784806378; Tue, 20 Jul 2021 05:40:06 -0700 (PDT) MIME-Version: 1.0 References: <20210720123512.8740-1-will@kernel.org> In-Reply-To: <20210720123512.8740-1-will@kernel.org> From: Ard Biesheuvel Date: Tue, 20 Jul 2021 14:39:55 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 0/2] Fix arm64 boot regression in 5.14 To: Will Deacon Cc: Linux Kernel Mailing List , Michael Ellerman , Thomas Gleixner , Benjamin Herrenschmidt , Christophe Leroy , Paul Mackerras , Jonathan Marek , Catalin Marinas , Andrew Morton , Mike Rapoport , Mark Rutland , Geert Uytterhoeven , Marc Zyngier , "open list:LINUX FOR POWERPC (32-BIT AND 64-BIT)" , Linux ARM X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210720_054007_533678_22FE9FA2 X-CRM114-Status: GOOD ( 25.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 20 Jul 2021 at 14:35, Will Deacon wrote: > > Hi folks, > > Jonathan reports [1] that commit c742199a014d ("mm/pgtable: add stubs > for {pmd/pub}_{set/clear}_huge") breaks the boot on arm64 when huge > mappings are used to map the kernel linear map but the VA size is > configured such that PUDs are folded. This is because the non-functional > pud_set_huge() stub is used to create the linear map, which results in > 1GB holes and a fatal data abort when the kernel attemps to access them. > > Digging further into the issue, it also transpired that huge-vmap is > silently disabled in these configurations as well [2], despite working > correctly in 5.13. The latter issue causes the pgtable selftests to > scream due to a failing consistency check [3]. > > Rather than leave mainline in a terminally broken state for arm64 while > we figure this out, revert the offending commit to get things working > again. Unfortunately, reverting the change in isolation causes a build > breakage for 32-bit PowerPC 8xx machines which recently started relying > on the problematic stubs to support pte-level huge-vmap entries [4]. > Since Christophe is away at the moment, this series first reverts the > PowerPC 8xx change in order to avoid breaking the build. > > I would really like this to land for -rc3 and I can take these via the > arm64 fixes queue if the PowerPC folks are alright with them. > > Cheers, > > Will > > [1] https://lore.kernel.org/r/20210717160118.9855-1-jonathan@marek.ca > [2] https://lore.kernel.org/r/20210719104918.GA6440@willie-the-truck > [3] https://lore.kernel.org/r/CAMuHMdXShORDox-xxaeUfDW3wx2PeggFSqhVSHVZNKCGK-y_vQ@mail.gmail.com/ > [4] https://lore.kernel.org/r/8b972f1c03fb6bd59953035f0a3e4d26659de4f8.1620795204.git.christophe.leroy@csgroup.eu/ > > Cc: Ard Biesheuvel > Cc: Michael Ellerman > Cc: Thomas Gleixner > Cc: Benjamin Herrenschmidt > Cc: Christophe Leroy > Cc: Paul Mackerras > Cc: Jonathan Marek > Cc: Catalin Marinas > Cc: Andrew Morton > Cc: Nicholas Piggin Cc: Mike Rapoport > Cc: Mark Rutland > Cc: Geert Uytterhoeven > Cc: Marc Zyngier > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-kernel@lists.infradead.org > > --->8 > > Jonathan Marek (1): > Revert "mm/pgtable: add stubs for {pmd/pub}_{set/clear}_huge" > > Will Deacon (1): > Revert "powerpc/8xx: add support for huge pages on VMAP and VMALLOC" > Reviewed-by: Ard Biesheuvel > arch/arm64/mm/mmu.c | 20 ++++----- > arch/powerpc/Kconfig | 2 +- > arch/powerpc/include/asm/nohash/32/mmu-8xx.h | 43 -------------------- > arch/x86/mm/pgtable.c | 34 +++++++--------- > include/linux/pgtable.h | 26 +----------- > 5 files changed, 25 insertions(+), 100 deletions(-) > > -- > 2.32.0.402.g57bb445576-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel