From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B245C433B4 for ; Tue, 18 May 2021 07:46:26 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A46FE611BF for ; Tue, 18 May 2021 07:46:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A46FE611BF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=enuRsdjLIcoUbfVTMqYkS8jQlLrOeOPtyuMG/vIUSJc=; b=MgcUyiqXXJPOzRmS1Lgd4lyQM H+Yv8BkEoxgvTZdu7A59HM3N3AfPCvJH2vWpKAwqwZcfcgaYZZVFKcRP3Qlw1SQ71qYB7HaOGbO5F lR11O9NC87rHU9uX0yClTwD9aZr+hmWEQx//WDwuwu+M9I5OfLN/ZKiVsll2Hsy6i95CKcwtCiwff 6PHpQ8I6Z2kEqYcuzjftuAXu1+iJDldmQvh75k8bRudMvbZvHxub/IJR6fkPxkMGDPwB7jTDhWm36 5H2hlovODdf5ttcY9Ifo3vk67ezIcc10vd5pFS26AU9QDpZbzfYRT8WH70mxAoYnG6vDMMth5ZUqV TyVIbDk+Q==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1liuOz-00HQQA-Ql; Tue, 18 May 2021 07:44:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liuOx-00HQPj-0y for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 07:44:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=961zhe5A3M9C2HVJ2GF5T02wX6xNTj+9CP6YUm214do=; b=TqAWOeGgCODJ8OUvx+2J8VrFSL 04KRcbPy4qKZNKymY5XWQ2P5Scfvf3UhV6NjQ1pnl8C1ifyuMSdqtx0A7yO0suJgMTOTzygQe7+Mj KPwvmd5GbRKiocl7Ofg559ull5tw7SEM6g5hpK5sLJv2QmJdMluhnICUX/xMFQyLd1tQevGlUl9/i fT4Oq45SaFvgESpLAeL/h8WILw3Mar5srsOQOWhg2FrxkFrlGPG21vVMLa4Ay8dQ3E1xoDv+X3jBF VMGM08VZJIAUoIp17DUs7qxpx7BBU96y8fVffVMpG+Mw7VDRjl2DPwpVoBXTlklKeUzD+S5q0G+/+ CStPPGAg==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1liuOu-00EQTD-Jo for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 07:44:25 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id F3D1361354 for ; Tue, 18 May 2021 07:44:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621323864; bh=Uuhf+yoymso8YqIT8WOHRoExsrTtRN7XlpyWr8JDrsM=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=er9ZT468M24ZsVQrHPuz/KThW8zN6PBrgPBVfDnlLi+X1S7xwIOpkzY3uNsidREtw JY/i7Ym7nhXHjIfecQB1BG+lxo2rAmHvWPJ9XSXtTY2dCQjvCr8tAkCY2meVdStjxM rhSAtE5q8qUa1OOcHx0DivESydfsd7rnblSWYQSCyNj40P4mVdbFOZYt79Whm/yPqj uJ90PrkuHY5tusS0ImkLKbZMjI/x7Uupkccyl8lf/GLm/Uhc9a+TqYzhOvVQC+yOLD fDU1fx86hDBgBDAu23m+lZ8zdIgHwdw+uH6ltgcOY+yGXGbB4wLqS4mLMlw6RbW67Q ApO7FPEP8+MoQ== Received: by mail-oi1-f173.google.com with SMTP id d21so8910673oic.11 for ; Tue, 18 May 2021 00:44:23 -0700 (PDT) X-Gm-Message-State: AOAM53338GEvv0Qwu3Nx4RwgnQcYmdv0luvILva56SFqTyTsV8tVegI3 ++yHK4UA0UwTPLS0tfFVcEBGHYtPORpLHeIInU8= X-Google-Smtp-Source: ABdhPJwvS8+WgM001FNdM1fj5bKDPq745upBFUE3BOJ1Lkz8DUWdNFRN3n1WXJe+3oGEALFBoZBVpKh/2O2+CK8JT/0= X-Received: by 2002:aca:4343:: with SMTP id q64mr2981525oia.33.1621323863302; Tue, 18 May 2021 00:44:23 -0700 (PDT) MIME-Version: 1.0 References: <20210305065120.11355-1-shawn.guo@linaro.org> <20210517005903.GA15021@dragon> In-Reply-To: <20210517005903.GA15021@dragon> From: Ard Biesheuvel Date: Tue, 18 May 2021 09:44:12 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] arm64: efi: add check for broken efi poweroff To: Shawn Guo Cc: Maximilian Luz , Catalin Marinas , Will Deacon , Jeffrey Hugo , Bjorn Andersson , linux-efi , Linux ARM , linux-arm-msm X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_004424_689905_54F109EC X-CRM114-Status: GOOD ( 19.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 17 May 2021 at 02:59, Shawn Guo wrote: > > + Maximilian > > On Fri, Mar 05, 2021 at 08:01:02AM +0100, Ard Biesheuvel wrote: > > On Fri, 5 Mar 2021 at 07:51, Shawn Guo wrote: > > > > > > Poweroff via UEFI Runtime Services doesn't always work on every single > > > arm64 machine. For example, on Lenovo Flex 5G laptop, it results in > > > a system reboot rather than shutdown. Add a DMI check to keep such > > > system stay with the original poweroff method (PSCI). > > > > > > Signed-off-by: Shawn Guo > > > > What is the point of using EFI runtime services on this machine if > > poweroff doesn't work either? Can't we just boot this thing with > > efi=noruntime? > > Ard, > > With Maximilian playing ACPI kernel on Microsoft Surface Pro X, this > ResetSystem service issue triggers more discussion and testing [1]. > Maximilian tested it with uefi-test-runner and reported that ResetSystem > actually works [2]. > > Looking at the kernel dump, I'm wondering if it's because that kernel > calls into the services with assuming they are in virtual addressing > mode, while actually they are in flat physical mode instead, due to > that SetVirtualAddressMap() call is skipped (efi_novamap). > That looks like a firmware bug. Boot with efi=debug to figure out whether the faulting address is a physical address that falls inside a EfiRuntimeServicesData region. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel