From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F296CC433B4 for ; Wed, 12 May 2021 21:27:12 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5B99A611C9 for ; Wed, 12 May 2021 21:27:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B99A611C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=n9N4/3KJtJjdSzInMKwWpYhAPN+y4bi2FxXykUy7g9k=; b=NU3L/NVgmtOq4VK9YMUMnIkQe FThuGvzMleN2CWEIaiJdI69gzPvhrvG1CTQzusZ0zDdlYJwhbV6zf119aUt86jqP4uME6+TAb89zA nHqI/GzaHw8EXsbJUQaBJu6UpA/YcIem+e/qwZOLP1Os4ND9OF2XbHe8akm5m10mUIfJfd+IEmApm sem5hVJycycMTn0t5OiqlXrFxXiyzJPas37C7yOGFkQcvjo5Afiv17wMXV5t3SC4kSYI2aq5XslMj YHvfOm0LzYdjkoZcxTsp5yv9H3BVEcJuc82zj6Uf4sEBlI6evOwUDMIjy56GVmQhfKiVHOfdqdWOy OHSrNgf5A==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgwLu-0042Xj-2H; Wed, 12 May 2021 21:25:11 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgwLq-0042Wy-92 for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 21:25:06 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ffSJXKpyrLd2e22BNh8CozzcziIiwSR/pJU62Tr1ugk=; b=2u3DvNqvpK4fPwRPgl75UP1Ewa TQS7+BwYwhiRY5WBbcnau4VIet1HkTpmkwz8DF9qDKbS3xvDM/XJonow7CrTHzUYG3W/iromXcnbi /sphBhn8ZwJBE1SLBEa55t9IZ1W7xFt9R/hwlMW2338zQPAL/dfxBYU6ohWoJutYRx6GIo68QB19g +QbvwXn6V9+ZST25C7sWrb04+4qejkKTO1V8UOjxKZkYWzDn1+gFw/2tj6ZqNqjs7FxFY1Q3q+Z1M cgxkHU19mCUgkd4AfpLN+/tp9Kx//Oarb/vEoXHHjOvwGb9cr8pAebPY/Bf1ek8Pzm5iLwc0rI3bo dTER3r7Q==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgwLn-00Aq1q-OY for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 21:25:05 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 170E761406 for ; Wed, 12 May 2021 21:25:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620854703; bh=f95kky9fWPP9zmOAqEAX7s3lv8BZDFV+H/qK5UnLA5Y=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=HZguiLPH5qdbXAdBg478u9jptd5qxHD/I1Amhw3QGV1r4dOZcrZ0BrqqZcgJiYPUK NabD9JhMOTmZrHnm95ThqAbRAhmYImRURAdQraL/FNwiunW91rOoEKCWivfsNi8bUY ZlPvK4za5i6NpONGTNYQW4TSfT8e/JdR6v7v0UYYQ6TkTuOELqI/pWlbivg3JXXk39 ZD/0bPkgeJ7kXbVHw3UbitKM/oGXOPQZ9mwsseb1XFajKkd63rTU4iqEwHBP8zx+Yg Lxhht5t/s74TgeHcsviEACyGjrAxPl1OIXDmU+sj974I71bRt5Nh0cjTRVrdP58OMj DRYS3HiU5SMsg== Received: by mail-ot1-f45.google.com with SMTP id 69-20020a9d0a4b0000b02902ed42f141e1so11692830otg.2 for ; Wed, 12 May 2021 14:25:03 -0700 (PDT) X-Gm-Message-State: AOAM533CEAczLkpzwJG9NAoxoGSmC7Eamg6zRxnXvrB+i8q1SCDasTms WX+/uQPlG3en8RJMntb6D/SDwPI8ojjhGuu08Xo= X-Google-Smtp-Source: ABdhPJyqF400LwQmcv8n0cvc2qRMttw1kHSf37IPM7sk7LtlHoXuad+DAhDwnwZps9xMbduti9tZZpgD41cySXXo43A= X-Received: by 2002:aca:4056:: with SMTP id n83mr386361oia.47.1620854702296; Wed, 12 May 2021 14:25:02 -0700 (PDT) MIME-Version: 1.0 References: <20210512184439.8778-1-ardb@kernel.org> <20210512184439.8778-3-ardb@kernel.org> In-Reply-To: From: Ard Biesheuvel Date: Wed, 12 May 2021 23:24:51 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v3 2/7] crypto: aead - disallow en/decrypt for non-task or non-softirq context To: Eric Biggers Cc: Linux Crypto Mailing List , Linux ARM , Herbert Xu , Will Deacon , Android Kernel Team X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_142503_848162_D77C0D99 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 12 May 2021 at 22:06, Eric Biggers wrote: > > On Wed, May 12, 2021 at 08:44:34PM +0200, Ard Biesheuvel wrote: > > In order to ensure that kernel mode SIMD routines will not need a scalar > > fallback if they run with softirqs disabled, disallow any use of the > > AEAD encrypt and decrypt routines from outside of task or softirq context. > > > > Signed-off-by: Ard Biesheuvel > > --- > > crypto/aead.c | 10 ++++++++++ > > 1 file changed, 10 insertions(+) > > > > diff --git a/crypto/aead.c b/crypto/aead.c > > index 16991095270d..b5304b3d3314 100644 > > --- a/crypto/aead.c > > +++ b/crypto/aead.c > > @@ -87,6 +87,11 @@ int crypto_aead_encrypt(struct aead_request *req) > > unsigned int cryptlen = req->cryptlen; > > int ret; > > > > + if (!(alg->cra_flags & CRYPTO_ALG_ASYNC) && > > + WARN_ONCE(!in_task() && !in_serving_softirq(), > > + "synchronous call from invalid context\n")) > > + return -EBUSY; > > + > > crypto_stats_get(alg); > > if (crypto_aead_get_flags(aead) & CRYPTO_TFM_NEED_KEY) > > ret = -ENOKEY; > > @@ -104,6 +109,11 @@ int crypto_aead_decrypt(struct aead_request *req) > > unsigned int cryptlen = req->cryptlen; > > int ret; > > > > + if (!(alg->cra_flags & CRYPTO_ALG_ASYNC) && > > + WARN_ONCE(!in_task() && !in_serving_softirq(), > > + "synchronous call from invalid context\n")) > > + return -EBUSY; > > + > > crypto_stats_get(alg); > > if (crypto_aead_get_flags(aead) & CRYPTO_TFM_NEED_KEY) > > ret = -ENOKEY; > > This probably should go after crypto_stats_get() so that the error gets counted > in the stats (if stats are enabled) -- analogous to how the ENOKEY error is > counted. > > Likewise for the skcipher patch. > Good point, I'll fix that _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel