From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A4D6C433B4 for ; Tue, 11 May 2021 12:32:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7DDC761919 for ; Tue, 11 May 2021 12:32:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7DDC761919 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4mMXcTjU/zEirRouqcPj+iEEoaQOYS4UvFjAoNCzdf0=; b=PSGepf5QpR9SSxH3dD38rHUyf IvN4RAoCOUBmhZdRBioljZHv8+etKvotUcr9mJpC60K9bJf429pUAH/bjdO7++PdYFTNUJYpX5AG2 tUJeB9S+Tt47EvxRLAMkjZVsx4M4y7uNZs0CrdhWV1dxwtxYiOzr29c+WgwbdNxt4Tqrq1wTOPQVb PjydcdCbNvkzOn/+m+B4IxMCWR9ot5ky6tX8rR4BDPWBaedftpohnCeRpWWWcEIXa4Zp2pSm3d7Hw EcZSFysaaRHSw7Apv0z0JtdljR4TbwaYbguTwYkxB5nnew+FJugoy3nziZl4se0dY3TEcVL9QKNAH HvK1AJZUw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgRXh-00HOnj-3r; Tue, 11 May 2021 12:31:17 +0000 Received: from [2607:7c80:54:e::133] (helo=bombadil.infradead.org) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgOSW-00Genh-VC for linux-arm-kernel@desiato.infradead.org; Tue, 11 May 2021 09:13:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=8u0MKPiYGq4Siy0bRVbRt6GLEL1/suPHbS9O13WwlyQ=; b=w15ocaFH8Q6OTtxz/jb9KOe1y9 kQFxyyDTA+vvZCxsndO+M/ujLNRSt9IFTFgKnyCVMFiFX5V4ny2IMwcgM/qR0ycdNKeYXjiLwl05Z 1Wn4pRcOvQs1san8iLmDj6KxKPni9joGTUiruhVaik7rK5z/+mOInhH9g+t2tMYhFN+9ZrsY9kAPh VssUTCY2mpAxcGBTqy5oZ6urL1CS5q4vvQ9Z7HVfzdKea1+z1kA6T6x9mwjknVz32fxVIzbG1sG6O czk1IEaOmY/AN2zUVQ93g7lJHdN88lFqwIvFEt/4q3CBhUKdlxGs+pl2hzjXwd0aLGQUAmuOspJoG LYvjjbRw==; Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgOSU-009QDt-Fk for linux-arm-kernel@lists.infradead.org; Tue, 11 May 2021 09:13:43 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id E25766192C for ; Tue, 11 May 2021 09:13:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620724421; bh=BR81VXadwSN0Wb8eCKd0AEu/wCwHkOKE2OFkPtdge9I=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=cVEP6IKtG+wR7W4R/gvZnVy/MTprx9+SnnZsvKnvbHIkQbFP7u87QPfWYPsQUNuhG PSuKxOBVC4a213TyvE/Ofw8TqmmYGnA/mcLmB8gm+c8H0X1JNbuwhEkvcjPO9Jv5H3 6XXEQRd6lDHMpZYoKzhE8g8GmMx1lfIQQZAzyc6k7jbVJFNTxq2AFvSXtnTbPvqWWu t3Gf9g4o8R9AiqpTO6MHwQyhzBFbt6eIxB7rZ/3G+mXdlRFYRV+yLjbu4m+mKOkkIS 5slYSQXFMoallYRE24BsFU1pge8ldW6sL+QrAi/H3z6HLCw1e5w6aWaeR2Mxp/Md02 ElBMCPkzn2vUA== Received: by mail-oi1-f172.google.com with SMTP id u16so18432914oiu.7 for ; Tue, 11 May 2021 02:13:41 -0700 (PDT) X-Gm-Message-State: AOAM532pLs2OJzg+CDLfiN5DwSmtS88PTPeWD+K1ReJdINdjQt5Vlbn6 mQqDWFXkDjTgCxeERpEIHdWitatAKx+kFy/bNQQ= X-Google-Smtp-Source: ABdhPJx9zC1SejZv808n7w5SuuidqWsE6YY630XuCVsbreWZYfVnf6PKHZ8mH+jyGaF/1OIqhQ6jFs4ouSJneTxTo9I= X-Received: by 2002:aca:4056:: with SMTP id n83mr2784337oia.47.1620724421115; Tue, 11 May 2021 02:13:41 -0700 (PDT) MIME-Version: 1.0 References: <20210511090318.478586-1-arnd@kernel.org> In-Reply-To: <20210511090318.478586-1-arnd@kernel.org> From: Ard Biesheuvel Date: Tue, 11 May 2021 11:13:30 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] ARM: mark prepare_page_table as __init To: Arnd Bergmann Cc: Russell King , Arnd Bergmann , Mike Rapoport , Linus Walleij , Andrew Morton , Hailong Liu , Changbin Du , Linux ARM , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_021342_584588_C1106BEE X-CRM114-Status: GOOD ( 22.03 ) /bin/ln: failed to access 'reaver_cache/texts/20210511_021342_584588_C1106BEE': No such file or directory X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_021342_584588_C1106BEE X-CRM114-Status: GOOD ( 18.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 11 May 2021 at 11:04, Arnd Bergmann wrote: > > From: Arnd Bergmann > > In some configurations when building with gcc-11, prepare_page_table > does not get inline, which causes a build time warning for a section > mismatch: > > WARNING: modpost: vmlinux.o(.text.unlikely+0xce8): Section mismatch in reference from the function prepare_page_table() to the (unknown reference) .init.data:(unknown) > The function prepare_page_table() references > the (unknown reference) __initdata (unknown). > This is often because prepare_page_table lacks a __initdata > annotation or the annotation of (unknown) is wrong. > > Mark the function as __init to avoid the warning regardless of the > inlining. > > Signed-off-by: Arnd Bergmann I think the inline should be dropped here. Either inlining is absolutely required for correct code generation (which is rare), or the inline is optional, and better left up to the compiler, especially given that this is __init code so the time/space tradeoff is moot anyway. With or without that change, Acked-by: Ard Biesheuvel > --- > arch/arm/mm/mmu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mm/mmu.c b/arch/arm/mm/mmu.c > index 051f4f82414b..5220b8147f40 100644 > --- a/arch/arm/mm/mmu.c > +++ b/arch/arm/mm/mmu.c > @@ -1246,7 +1246,7 @@ void __init adjust_lowmem_bounds(void) > memblock_set_current_limit(memblock_limit); > } > > -static inline void prepare_page_table(void) > +static inline __init void prepare_page_table(void) > { > unsigned long addr; > phys_addr_t end; > -- > 2.29.2 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel