From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 74E7BC04FF3 for ; Mon, 24 May 2021 19:15:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EC7961415 for ; Mon, 24 May 2021 19:15:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2EC7961415 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pVYA/0N8V44E7aTdzhVWcr5fe4NeYtNpbV6+jEx+UP8=; b=LiGGnAXO0YPgYg dnTIX0ZnKqBWbUEhBCifKJstQ4LysMyTA6cOQeEFC4p12JUiAB1f9BhdOwv1umpCDVUl72bjH902D nIIto46C/BjeS77tDZk1SMJadM1hJv//MaBsTdrPPuC0o4l641u0d2cQy8VClQUfjbh+WShip1wcb n2AzROcAjwJ1xSX8M1PmtS0WXyhcy83DtqBzvNx/t0cLIl9i64/9EGr1eCXiOqHcGWbkVODfiGINa s/v1n1LHh0q2d18YQTxs6mb4daljI+xWSP0oUXO0rWTLLUMY95J1a9BLZ8lU4LdQutfml4IqJT375 pOP4iBQryTVHREEUKj/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1llG0e-001caR-PS; Mon, 24 May 2021 19:13:05 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ll7Bd-000oMo-B4 for linux-arm-kernel@lists.infradead.org; Mon, 24 May 2021 09:47:51 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id CAC7B61209 for ; Mon, 24 May 2021 09:47:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1621849668; bh=1/VJmgqAoDaXb3NNoaTNTwh8uTjwQXJ603DICVsEd3U=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=brCwQTl4tBqylS0B71pk3eOCJ3CTVT16fcDClDamXzcD9P9UhtL5sz7Frpt/RXYSG c/zI81NEajnR9m4bhbSOJ2jid2V3RYT8sSLKXDEHtn2zkeXAV6hMwRaQ+C9S7q8unv HM2VnxvJh5F8FVrWPatu5KXh0J26ItjiTxBYAz83m8mzoz773PM6I1MM14OLcX7bd5 IQO6XCofUcB0HRelaRjOYVPEzIvOGmOa/kby0KGW2vBqnwB9Qo3pGWh/geRpOHBTIr CcS8KtACBbvDZVoHSrb7AP806xX6f2/tb18uLF6MG1jVSC3jkJRWqVlupe80kCEz3E cZl9vYjRas7rw== Received: by mail-oi1-f176.google.com with SMTP id b25so26629153oic.0 for ; Mon, 24 May 2021 02:47:48 -0700 (PDT) X-Gm-Message-State: AOAM532L3FspX4dV2wXBJhOBJmG2T8ZZgTbpjGyNZvZH+kzKZXcSNDjs ePkexPtNVEJ+LpUsbbOgzHmevIaQgl24pkLJO8M= X-Google-Smtp-Source: ABdhPJxePa8mFJMpHFZQVLO9kTfd/mGw4NDaQCeTWgUCNPVXVGmxB1cKcQmNYbEwkC5VwjnT+NLhQ1EUibu7IfhPaUU= X-Received: by 2002:aca:3182:: with SMTP id x124mr10319249oix.47.1621849668155; Mon, 24 May 2021 02:47:48 -0700 (PDT) MIME-Version: 1.0 References: <20210524083001.2586635-1-tabba@google.com> In-Reply-To: <20210524083001.2586635-1-tabba@google.com> From: Ard Biesheuvel Date: Mon, 24 May 2021 11:47:36 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 00/18] Tidy up cache.S To: Fuad Tabba Cc: Linux ARM , Will Deacon , Catalin Marinas , Mark Rutland , Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Robin Murphy X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210524_024749_449224_1657B51E X-CRM114-Status: GOOD ( 27.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 24 May 2021 at 10:30, Fuad Tabba wrote: > > Hi, > > Changes since v3 [1]: > - Rebased onto v5.13-rc3 > - Redid __flush_cache_range to use dcache_by_line_op (Mark) > - Remove user_alt macro (Mark) > - Tidying up some code, comments, and commit messages. (Mark) > > This should cover all the feedback from v2 [2]. > > Changes since v2 [2]: > - Brought in Mark's patches that add conditional cache fixups, only generating > an extable entry if a label is provided [3]. NOTE: The patches missed some of > the code comments to reflect the changes. I took the liberty of fixing the > comments in Mark's patch. > - Tidied up the new cache flush (clean/invalidate) macro by removing code > duplication, conditional variables/labels. Moved the ttbr manipulation, > fixup handler, and rets inline in __flush_cache_user_range. (Mark) > - Fixed comments and commit messages. (Mark) > > Changes since v1 [4]: > - Apply ARM64_WORKAROUND_CLEAN_CACHE errata to > swsusp_arch_suspend_exit (Mark) > - Remove toggling of uaccess from the newly created cache flush > (clean/invalidate) macro and leave it up to the caller (Robin) > - Fix renaming of cache maintenance functions (Ard, Mark) > - Fix comment on maintenance operations in machine_kexec_post_load (Ard) > - Fix commit msg comments to clarify some of the changes and outline potential > performance impact (Mark) > - Fix code comments that refer to flush_icache_range when the intended function > is __flush_icache_range > > As has been noted before [5], the code in cache.S isn't very tidy. Some of its > functions accept address ranges by start and size, whereas others with similar > names do so by start and end. This has resulted in at least one bug [6]. > > Moreover, invalidate_icache_range and __flush_icache_range toggle uaccess, > which isn't necessary because they work on kernel addresses [7]. > > This patch series attempts to fix these issues, as well as tidy up the code in > general to reduce ambiguity and make it consistent with Arm terminology and > with the functions' actual operations. > > No functional change intended in this series. However, there might be a > performance impact due to the reduced number of instructions in general. > > This series is based on v5.13-rc3. You can find the applied series here [8]. > > Cheers, > /fuad > > [1] https://lore.kernel.org/linux-arm-kernel/20210520124406.2731873-1-tabba@google.com/ > [2] https://lore.kernel.org/linux-arm-kernel/20210517075124.152151-1-tabba@google.com/ > [3] https://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git/log/?h=arm64/cleanups/cache > [4] https://lore.kernel.org/linux-arm-kernel/20210511144252.3779113-1-tabba@google.com/T/ > [5] https://lore.kernel.org/linux-arch/20200511075115.GA16134@willie-the-truck/ > [6] https://lore.kernel.org/linux-arch/20200510075510.987823-3-hch@lst.de/ > [7] https://lore.kernel.org/linux-arch/20200511110014.lb9PEahJ4hVOYrbwIb_qUHXyNy9KQzNFdb_I3YlzY6A@z/ > [8] https://android-kvm.googlesource.com/linux/+/refs/heads/tabba/fixcache-5.13 > > Fuad Tabba (16): > arm64: Apply errata to swsusp_arch_suspend_exit > arm64: Do not enable uaccess for flush_icache_range > arm64: Do not enable uaccess for invalidate_icache_range > arm64: Downgrade flush_icache_range to invalidate > arm64: assembler: remove user_alt > arm64: Move documentation of dcache_by_line_op > arm64: Fix comments to refer to correct function __flush_icache_range > arm64: __inval_dcache_area to take end parameter instead of size > arm64: dcache_by_line_op to take end parameter instead of size > arm64: __flush_dcache_area to take end parameter instead of size > arm64: __clean_dcache_area_poc to take end parameter instead of size > arm64: __clean_dcache_area_pop to take end parameter instead of size > arm64: __clean_dcache_area_pou to take end parameter instead of size > arm64: sync_icache_aliases to take end parameter instead of size > arm64: Fix cache maintenance function comments > arm64: Rename arm64-internal cache maintenance functions > > Mark Rutland (2): > arm64: assembler: replace `kaddr` with `addr` > arm64: assembler: add conditional cache fixups > These all look good to me. Thanks for cleaning this up. Reviewed-by: Ard Biesheuvel > arch/arm64/include/asm/alternative-macros.h | 5 - > arch/arm64/include/asm/arch_gicv3.h | 3 +- > arch/arm64/include/asm/assembler.h | 80 ++++++---- > arch/arm64/include/asm/cacheflush.h | 71 +++++---- > arch/arm64/include/asm/efi.h | 2 +- > arch/arm64/include/asm/kvm_mmu.h | 7 +- > arch/arm64/kernel/alternative.c | 2 +- > arch/arm64/kernel/efi-entry.S | 9 +- > arch/arm64/kernel/head.S | 13 +- > arch/arm64/kernel/hibernate-asm.S | 7 +- > arch/arm64/kernel/hibernate.c | 20 ++- > arch/arm64/kernel/idreg-override.c | 3 +- > arch/arm64/kernel/image-vars.h | 2 +- > arch/arm64/kernel/insn.c | 2 +- > arch/arm64/kernel/kaslr.c | 12 +- > arch/arm64/kernel/machine_kexec.c | 30 ++-- > arch/arm64/kernel/probes/uprobes.c | 2 +- > arch/arm64/kernel/smp.c | 8 +- > arch/arm64/kernel/smp_spin_table.c | 7 +- > arch/arm64/kernel/sys_compat.c | 2 +- > arch/arm64/kvm/arm.c | 2 +- > arch/arm64/kvm/hyp/nvhe/cache.S | 4 +- > arch/arm64/kvm/hyp/nvhe/setup.c | 3 +- > arch/arm64/kvm/hyp/nvhe/tlb.c | 2 +- > arch/arm64/kvm/hyp/pgtable.c | 13 +- > arch/arm64/lib/uaccess_flushcache.c | 4 +- > arch/arm64/mm/cache.S | 158 ++++++++++---------- > arch/arm64/mm/flush.c | 29 ++-- > 28 files changed, 282 insertions(+), 220 deletions(-) > > > base-commit: c4681547bcce777daf576925a966ffa824edd09d > -- > 2.31.1.818.g46aad6cb9e-goog > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel