From: Ard Biesheuvel <ardb@kernel.org>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <will@kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue
Date: Fri, 8 May 2020 09:58:50 +0200 [thread overview]
Message-ID: <CAMj1kXGoe4aar3g3Qu7LU85JSdd1QqOMYp2mGtO1p2h_KiDb7g@mail.gmail.com> (raw)
In-Reply-To: <1588910198-8348-1-git-send-email-guohanjun@huawei.com>
On Fri, 8 May 2020 at 06:07, Hanjun Guo <guohanjun@huawei.com> wrote:
>
> As we already applied a workaround for the off-by-1 issue,
> it's good to add extra message "applying workaround" to make
> people less uneasy to see FW_BUG message in the boot log.
>
> Signed-off-by: Hanjun Guo <guohanjun@huawei.com>
> ---
>
> v2:
> - Print the extra message only for rid_in == map->input_base;
> - Still based on top of for-next/acpi branch of ARM64 repo
>
> drivers/acpi/arm64/iort.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c
> index b011d25..6e445bc 100644
> --- a/drivers/acpi/arm64/iort.c
> +++ b/drivers/acpi/arm64/iort.c
> @@ -332,6 +332,8 @@ static int iort_id_map(struct acpi_iort_id_mapping *map, u8 type, u32 rid_in,
> map, rid_in);
> if (rid_in != map->input_base)
> return -ENXIO;
> +
> + pr_err(FW_BUG "applying workaround.\n");
> }
>
> *rid_out = map->output_base + (rid_in - map->input_base);
> --
> 1.7.12.4
>
Acked-by: Ard Biesheuvel <ardb@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-08 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 3:56 [PATCH v2] ACPI: IORT: Add extra message "applying workaround" for off-by-1 issue Hanjun Guo
2020-05-08 7:58 ` Ard Biesheuvel [this message]
2020-05-11 16:27 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMj1kXGoe4aar3g3Qu7LU85JSdd1QqOMYp2mGtO1p2h_KiDb7g@mail.gmail.com \
--to=ardb@kernel.org \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).