From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55430C433F5 for ; Mon, 10 Oct 2022 10:21:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=rB71qSLEDToZWr++Ll2/s/l+AzfgQWrc4VxrYkopbVQ=; b=nd8K5A7s7bVmbu bk1fos2aIuDHXBdtrWqLTSlI2k1nSnu05/nfOW+78OLDtCdfquhNXNpD5CYem4hEr0DV+nSnk4Mvp axlB5tTClgUZqqX5kysJP4nRu5LJtdtg52wxr4z87Ex2x+XVm1ucXXjKTKm6Yfks5JKGRs32K7hrR SQpN1B06cz5kzBeAfKotJnf67XOS+5JhnZLG84WXtLvv2DAinUcL8iec4/JExhhJItF6wvdE+4ic4 wsJV3/TYEvgnyouxkHaUj2LtSPEyxWlRSBz0Xa4XfDPRuvCNg7MCFbiGiTwQ39UQcBYD5os3ky40k jUlwkhE/gtawns5yYJxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohpu2-000MiG-Vn; Mon, 10 Oct 2022 10:20:55 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ohptx-000Mgf-Gp for linux-arm-kernel@lists.infradead.org; Mon, 10 Oct 2022 10:20:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B4DC460EC9 for ; Mon, 10 Oct 2022 10:20:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27356C433D6 for ; Mon, 10 Oct 2022 10:20:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1665397248; bh=w80vbmdBsUQ38PcZM7KUgaYXUtnKGnyzONFOJgcKacs=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=BK2lXICfa3SPleuwgbpQxkIsMz0HV4Htjyru/OJC3f9R1anlVMGRK0VeZqXp8mL1i HFoW5ZUtCx5J8gkwRQZwLZ5+QrBW4u4cWU2r2XQZd30zwi3cHL/4YcETgbBiISQvKA uvcx1vvaJic5nzXJ3cbYKSzhCBcvn3p8tyVkjMWO8+L1ZKovuBB2rq81BvlGZfkkmk V7y7Gc7G/lLaIrURQMNcK2kBxaDCUEVzlaD1ADwDMAhIAFnkHGzi3sAon98oBB5EsH MweUFZ8iZw/lakZVuhmLiJ1IuQWbnUnBZtqGDYjLDLsRp4a79ADvZCIQuNK6HBdKjm O3r9D/jJcF5wg== Received: by mail-lf1-f47.google.com with SMTP id j4so16015197lfk.0 for ; Mon, 10 Oct 2022 03:20:48 -0700 (PDT) X-Gm-Message-State: ACrzQf1TSWVIcZjKndQSajDgL53zTiN6NZwtBus3uR1MxRQQfGBV9U1x AqBbEVZgqI6igo2ZzYuGB0F6PhP1GgGGrmCzkpA= X-Google-Smtp-Source: AMsMyM5244zjH5Fytb6hVEoSiq8q5sgmu6ZQ/7Swti5msJ1aEam/Gk6oXbr15EANbFpsa4I/lF+zTIGZx9q22rZlWNI= X-Received: by 2002:a05:6512:104a:b0:4a2:9c7b:c9c with SMTP id c10-20020a056512104a00b004a29c7b0c9cmr5413624lfb.122.1665397246153; Mon, 10 Oct 2022 03:20:46 -0700 (PDT) MIME-Version: 1.0 References: <20221010095346.1957-1-thunder.leizhen@huawei.com> <20221010095346.1957-2-thunder.leizhen@huawei.com> In-Reply-To: <20221010095346.1957-2-thunder.leizhen@huawei.com> From: Ard Biesheuvel Date: Mon, 10 Oct 2022 12:20:35 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v2 1/2] ARM: Fix some check warnings of tool sparse To: Zhen Lei Cc: Russell King , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221010_032049_661752_C347CB36 X-CRM114-Status: GOOD ( 23.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 10 Oct 2022 at 11:56, Zhen Lei wrote: > > Fix the following warnings: > warning: incorrect type in initializer (different address spaces) > expected unsigned short [noderef] __user *register __p > got unsigned short [usertype] * > warning: cast removes address space '__user' of expression > > Signed-off-by: Zhen Lei > --- > arch/arm/kernel/traps.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/kernel/traps.c b/arch/arm/kernel/traps.c > index 20b2db6dcd1ced7..34aa80c09c508c1 100644 > --- a/arch/arm/kernel/traps.c > +++ b/arch/arm/kernel/traps.c > @@ -188,9 +188,9 @@ static void dump_instr(const char *lvl, struct pt_regs *regs) > } > } else { > if (thumb) > - bad = get_user(val, &((u16 *)addr)[i]); > + bad = get_user(val, &((u16 __user *)addr)[i]); > else > - bad = get_user(val, &((u32 *)addr)[i]); > + bad = get_user(val, &((u32 __user *)addr)[i]); > } > > if (!bad) > @@ -455,15 +455,15 @@ asmlinkage void do_undefinstr(struct pt_regs *regs) > if (processor_mode(regs) == SVC_MODE) { > #ifdef CONFIG_THUMB2_KERNEL > if (thumb_mode(regs)) { > - instr = __mem_to_opcode_thumb16(((u16 *)pc)[0]); > + instr = __mem_to_opcode_thumb16(((__force u16 *)pc)[0]); Shouldn't this be __user as well? (and below) > if (is_wide_instruction(instr)) { > u16 inst2; > - inst2 = __mem_to_opcode_thumb16(((u16 *)pc)[1]); > + inst2 = __mem_to_opcode_thumb16(((__force u16 *)pc)[1]); > instr = __opcode_thumb32_compose(instr, inst2); > } > } else > #endif > - instr = __mem_to_opcode_arm(*(u32 *) pc); > + instr = __mem_to_opcode_arm(*(__force u32 *) pc); > } else if (thumb_mode(regs)) { > if (get_user(instr, (u16 __user *)pc)) > goto die_sig; > -- > 2.25.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel