linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Peter Collingbourne <pcc@google.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Brodsky <Kevin.Brodsky@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	ML dri-devel <dri-devel@lists.freedesktop.org>,
	Eric Anholt <eric@anholt.net>, Daniel Vetter <daniel@ffwll.ch>,
	Sean Paul <sean@poorly.run>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver"
Date: Tue, 29 Sep 2020 14:37:37 -0700	[thread overview]
Message-ID: <CAMn1gO5r7wJtROCUYtEceqTx1D8ixLerRuctO7Ea9BrGnjqSXw@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdYoOVeEkF6RiJSUykJfmJUthXNHMdTUmu+02OXRCgOd0A@mail.gmail.com>

On Tue, Sep 29, 2020 at 1:29 PM Linus Walleij <linus.walleij@linaro.org> wrote:
>
> On Tue, Sep 29, 2020 at 8:44 PM Daniel Vetter <daniel@ffwll.ch> wrote:
> > On Tue, Sep 29, 2020 at 7:49 PM Peter Collingbourne <pcc@google.com> wrote:
>
> > But aside from all this, why is this blocking the migration from fbdev
> > to drm? With fbdev you don't have buffer allocations, nor dma-buf
> > support, and somehow android can boot.
>
> I do not know how Android does things these days but back in the
> days it would request a virtual framebuffer twice the height of the
> physical framebuffer and then pan that up/down between composing
> frames, thus achieving a type of double-buffering from userspace.
>
> Given the type of bugs Peter is seeing this seems to still be the
> case, Peter can you confirm?

This is what the userspace fbdev driver does (or at least tries to
do). If this operation fails (as it does with the old fbdev CLCD
driver) the driver falls back to using a single buffer. The DRM driver
doesn't do anything like that, it allocates multiple buffers. IIRC
that fails on stock kernels but with an increase to the amount of
video RAM declared in the DTS (e.g. [1]) that operation turns out to
succeed.

Peter

[1] https://www.spinics.net/lists/arm-kernel/msg800628.html

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-09-29 21:39 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-28 20:08 [PATCH] Revert "video: fbdev: amba-clcd: Retire elder CLCD driver" Peter Collingbourne
2020-09-29  7:28 ` Neil Armstrong
2020-09-29  9:32   ` Daniel Vetter
2020-09-29 16:30     ` Peter Collingbourne
2020-09-29 16:48       ` Daniel Vetter
2020-09-29 16:52         ` Daniel Vetter
2020-09-29 17:49           ` Peter Collingbourne
2020-09-29 18:41             ` Daniel Vetter
2020-09-29 18:44             ` Daniel Vetter
2020-09-29 20:29               ` Linus Walleij
2020-09-29 21:37                 ` Peter Collingbourne [this message]
2020-09-30  9:40                 ` Daniel Vetter
2020-09-29 20:51               ` Peter Collingbourne
2020-09-30  9:43                 ` Daniel Vetter
2020-10-12 12:50                   ` Neil Armstrong
2021-12-05 13:34       ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMn1gO5r7wJtROCUYtEceqTx1D8ixLerRuctO7Ea9BrGnjqSXw@mail.gmail.com \
    --to=pcc@google.com \
    --cc=Kevin.Brodsky@arm.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eric@anholt.net \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@armlinux.org.uk \
    --cc=narmstrong@baylibre.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).