From: Bartosz Golaszewski <bgolaszewski@baylibre.com>
To: Stephen Kitt <steve@sk2.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Sekhar Nori <nsekhar@ti.com>,
Russell King <linux@armlinux.org.uk>,
arm-soc <linux-arm-kernel@lists.infradead.org>,
linux-i2c <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] ARM: davinci: use simple i2c probe function
Date: Mon, 10 Aug 2020 20:47:47 +0200 [thread overview]
Message-ID: <CAMpxmJXLELE7CmMpqvw_1jFJW80f_O2wQg08JAd0gv-XBrWq_Q@mail.gmail.com> (raw)
In-Reply-To: <20200809172444.16019-1-steve@sk2.org>
On Sun, Aug 9, 2020 at 7:24 PM Stephen Kitt <steve@sk2.org> wrote:
>
> The i2c probe functions here don't use the id information provided in
> their second argument, so the single-parameter i2c probe function
> ("probe_new") can be used instead.
>
> This avoids scanning the identifier tables during probes.
>
> Signed-off-by: Stephen Kitt <steve@sk2.org>
> ---
> Changes since v1:
> - split into per-sub-architecture patches.
>
> arch/arm/mach-davinci/board-dm644x-evm.c | 5 ++---
> arch/arm/mach-davinci/board-dm646x-evm.c | 10 ++++------
> 2 files changed, 6 insertions(+), 9 deletions(-)
>
> diff --git a/arch/arm/mach-davinci/board-dm644x-evm.c b/arch/arm/mach-davinci/board-dm644x-evm.c
> index a5d3708fedf6..d0dcf69cc76d 100644
> --- a/arch/arm/mach-davinci/board-dm644x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm644x-evm.c
> @@ -548,8 +548,7 @@ static const struct property_entry eeprom_properties[] = {
> */
> static struct i2c_client *dm6446evm_msp;
>
> -static int dm6446evm_msp_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int dm6446evm_msp_probe(struct i2c_client *client)
> {
> dm6446evm_msp = client;
> return 0;
> @@ -569,7 +568,7 @@ static const struct i2c_device_id dm6446evm_msp_ids[] = {
> static struct i2c_driver dm6446evm_msp_driver = {
> .driver.name = "dm6446evm_msp",
> .id_table = dm6446evm_msp_ids,
> - .probe = dm6446evm_msp_probe,
> + .probe_new = dm6446evm_msp_probe,
> .remove = dm6446evm_msp_remove,
> };
>
> diff --git a/arch/arm/mach-davinci/board-dm646x-evm.c b/arch/arm/mach-davinci/board-dm646x-evm.c
> index 4600b617f9b4..2dce16fff77e 100644
> --- a/arch/arm/mach-davinci/board-dm646x-evm.c
> +++ b/arch/arm/mach-davinci/board-dm646x-evm.c
> @@ -160,8 +160,7 @@ static struct platform_device davinci_aemif_device = {
> #define DM646X_EVM_ATA_PWD BIT(1)
>
> /* CPLD Register 0 Client: used for I/O Control */
> -static int cpld_reg0_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int cpld_reg0_probe(struct i2c_client *client)
> {
> if (HAS_ATA) {
> u8 data;
> @@ -197,7 +196,7 @@ static const struct i2c_device_id cpld_reg_ids[] = {
> static struct i2c_driver dm6467evm_cpld_driver = {
> .driver.name = "cpld_reg0",
> .id_table = cpld_reg_ids,
> - .probe = cpld_reg0_probe,
> + .probe_new = cpld_reg0_probe,
> };
>
> /* LEDS */
> @@ -402,8 +401,7 @@ static struct snd_platform_data dm646x_evm_snd_data[] = {
> #ifdef CONFIG_I2C
> static struct i2c_client *cpld_client;
>
> -static int cpld_video_probe(struct i2c_client *client,
> - const struct i2c_device_id *id)
> +static int cpld_video_probe(struct i2c_client *client)
> {
> cpld_client = client;
> return 0;
> @@ -424,7 +422,7 @@ static struct i2c_driver cpld_video_driver = {
> .driver = {
> .name = "cpld_video",
> },
> - .probe = cpld_video_probe,
> + .probe_new = cpld_video_probe,
> .remove = cpld_video_remove,
> .id_table = cpld_video_id,
> };
>
> base-commit: bcf876870b95592b52519ed4aafcf9d95999bc9c
> --
> 2.20.1
>
Reviewed-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-10 18:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-09 17:24 [PATCH v2] ARM: davinci: use simple i2c probe function Stephen Kitt
2020-08-10 9:37 ` Wolfram Sang
2020-09-03 5:38 ` Sekhar Nori
2020-08-10 18:47 ` Bartosz Golaszewski [this message]
2020-08-13 13:08 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMpxmJXLELE7CmMpqvw_1jFJW80f_O2wQg08JAd0gv-XBrWq_Q@mail.gmail.com \
--to=bgolaszewski@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nsekhar@ti.com \
--cc=steve@sk2.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).