From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCBFEC43381 for ; Mon, 18 Mar 2019 16:48:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9C43720854 for ; Mon, 18 Mar 2019 16:48:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="QvObkcUx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="XL4Yfszo" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9C43720854 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Ek2mR2IY1DnJJzaVJYjdnV4azel1rQhpNU2ipX4AA8Q=; b=QvObkcUxbr2+JF NvDtfj1KJmkX/VApODn0H9EeS1XSudLFVPKUwppKE+phfVvJhKSWfJ7Ck36/dm65gQAt1d+Z3v7yy OmBwfV8p7oh1mWdjW4V1eScv0bdWaOgTsL4lQmZJ9FidlpSvbgzwgZ9+1HqUDAmnIyg4XfiOi0ZXc rppPQBDd2+7VeGB4hulPykB7RPmYxj6NGIYm7MDuEDrYXWSOdHM4BSSjwRLrnYa5wCjdJuiq2kB7u nlymmED68PiNsz4T5+4XahomFBe/mdFvZJ7IbhCjwKsiBtwc/ixh92IBtQ2ZTwlMi9dzY6hEDTvfu o5b0LtMWZI+KdAQOa8XQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5vR7-0004rv-Me; Mon, 18 Mar 2019 16:48:29 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h5vR3-0004r8-2z for linux-arm-kernel@lists.infradead.org; Mon, 18 Mar 2019 16:48:27 +0000 Received: by mail-io1-xd44.google.com with SMTP id p17so15030865iol.7 for ; Mon, 18 Mar 2019 09:48:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DU0j7gWBwfe7zDyjBs05MgiZSkKZWyXIJCa+ccAxou8=; b=XL4YfszorHTM4F1iHrb5JB0fdVp9yf6kG5cHKD5Ks8ekbUmXWIyoaBxMPlRNLJ79c/ +dLGXRoU7duFICjWKLNn3OhEVxQ7K3UgijjSaMyoX7XjO2DJejYBJvlb+v7ZiubOWtgy Tyt4aQkruUtinMfq7fNI7y+WGnR5JV4LBTDYU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DU0j7gWBwfe7zDyjBs05MgiZSkKZWyXIJCa+ccAxou8=; b=TMYsOAHceXNEHgY9cFMXhn70qJh5tL3rIqkIMtwnAETCNaPI9EPeHtCagSTOF6W7im EH+ja75MJgndxQbbSmTImIvJyjcGJd6cs5N6iZyYMt/yTOVesFKYnQQ49Kx/KTLdez5T SD9ihB18WiN3tKPxqmFcehcXUP57WHIwQJicTVjBKouyjAslg90KCMSz7dYJJGj3DMr/ Nxa1DeAc4TPUGSSbZ5pbAYi2kBokjHp1UCDyS24BC9w0vVKh6ht3c/YgkX/8SBZ0oEyN o+dtr+A8Jg6L4usat3b8qQk09HZ05s9PXOb5aPcJzcSBOWwRATWZXLDojeKzNrZSFcUo or1A== X-Gm-Message-State: APjAAAWFi+ioWNQAzv/XsENsePuCrppTS0UJp+0hQUDSbiJaZFyP+/O1 gG8NrGWq0bniUGM7X6o0LAfsgDKVXMtisUG2gbliZw== X-Google-Smtp-Source: APXvYqzuPHY1jkuNIGwTVbjbgMeNmA8zhkwSLwIk+L+/jjHzHRgrvql975Z1F+OpbHgdoj/Kr41vxvg1KQD2lejwSrA= X-Received: by 2002:a6b:d80a:: with SMTP id y10mr11265333iob.114.1552927703397; Mon, 18 Mar 2019 09:48:23 -0700 (PDT) MIME-Version: 1.0 References: <20190315130825.9005-1-jagan@amarulasolutions.com> <20190315130825.9005-2-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Mon, 18 Mar 2019 22:18:11 +0530 Message-ID: Subject: Re: [linux-sunxi] [PATCH 1/6] drm/bridge: Export drm_bridge_detach To: Paul Kocialkowski X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190318_094825_618844_17802547 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Maxime Ripard , David Airlie , linux-sunxi , linux-kernel , dri-devel , Andrzej Hajda , Chen-Yu Tsai , Rob Herring , Laurent Pinchart , Daniel Vetter , Michael Trimarchi , linux-amarula@amarulasolutions.com, linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Fri, Mar 15, 2019 at 6:58 PM Paul Kocialkowski wrote: > > Hi Jakan, > > On Fri, 2019-03-15 at 18:38 +0530, Jagan Teki wrote: > > Export drm_bridge_detach from drm bridge core so-that it > > can use on respective interface or bridge driver while > > detaching the bridge. > > I don't see why this change is required based on the commit log. The > DRM bridge code clearly indicates that drm_bridge_attach should *not* > be balanced with a drm_bridge_detach call in the driver, so this seems > quite wrong. > > The DRM core itself should handle detaching the bridge, not the driver. > Is there any reason why you need to do things differently for DSI? Yes, you are correct the detach of bridge is being taking care via drm_encoder_cleanup. This patch exported explicitly, since we need to taken care bridge detach during unbind even exynos_drm_dsi in other patch seems using detach by explicitly pointing. so I think the better approach is to use drm_encoder_cleanup in unbind, what do you say? Jagan. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel