From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F9CBC43603 for ; Mon, 16 Dec 2019 16:59:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 127FC206D7 for ; Mon, 16 Dec 2019 16:59:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RDp8/TOg"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="mvCGoG39" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 127FC206D7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7JVqJAaKPtij5fORKp3ozujfLwcVVq9cGWLeDN3MJB4=; b=RDp8/TOgke7bsM 1yPG3a7jcJ835+aC8c1wly1df4xm35+xy9atM2CNngUlrJbt14ici5ImzBAfMI7C1K/nvluj1nDL6 1vo4e4m31ywT9NTl00i67v+WwqEF6vxsw8mAkkTdkTMFpdAV5GlKkNq4U/rkYYYrj3MGG3cNaqcoV IOY8b3LR7Mu50GAq1XX4ZH/4llZY8VPLRoYmbZQevw+E9w0/BxW3zB64qF3iPtUBadWqYog4VpuSL LzTRM5rW06RWHyCQd8z/y1q/ZxE/jUlAsfQSAY4/xmOpxqOzG1fAPKmu/PKwrdmxy8Rr/2eAdl1cz 7xAo3e+iXaSWGM9KSV/w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1igtiP-0008LZ-7B; Mon, 16 Dec 2019 16:59:25 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1igtiL-0008Kx-KS for linux-arm-kernel@lists.infradead.org; Mon, 16 Dec 2019 16:59:23 +0000 Received: by mail-io1-xd41.google.com with SMTP id x1so7691684iop.7 for ; Mon, 16 Dec 2019 08:59:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wT7SZ+OLO630PVI5NYrvDjy+jNlP7/vPSuqmUxImjRI=; b=mvCGoG390lkQhIGt10C5uJOnQlDLqM7ckcj5+vO5/E5UBpBhaLT0+k2/e7I4DLcEeY 2ifgfrg+zjpexA6m1T2Ge1sRCpRRTyvEIhEZTAMP9J664HhTWziOuDAb1+iyH7srY7PA ozqRWgCYhHDvJDJ5yuT6pDwnFshn+bjNE7YmA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wT7SZ+OLO630PVI5NYrvDjy+jNlP7/vPSuqmUxImjRI=; b=Pro6jWVjJHO9tfFu3Snh0WmfKoYTABfvAn+IsGpvwEbuYacz0N0mC0lREERbCvW7qU UUXEtdcmsSs76CKfi9nWtu9CYKGz12v2RiblkfyTLFtNA3GXfptj5Y2flUbwstyyvW+F AamMloz6P5E07kzMZCgI4xhUgfFzDq1UrKhQLQHZ4cDLjonah0u+JXkxShHw6NSykl+X GaB03t+UYkd+I5rcBkJBSHFw6L6lKRFI3b91Ul/S6WaQzRPp9Q6Vpd+yPMoxDkMStgWU qQOTwM6LnQ8BG0p8USkKpu8fUU5CDWy094gJW/PZ/n+NY6dAT47oy4CmADQEFvJB2SbV RlNg== X-Gm-Message-State: APjAAAVYm9d1t3SmB23Qc4207quIidBZz3Hs0pCRZrLCkvVNKGvfXgug BYhkizAiFmTF0OysqwEmZPyFN+Am4bQWZFMzxf/zxw== X-Google-Smtp-Source: APXvYqxdRoeWD1Tywgum5/3SAGtinVvAq8t3n49rScn14Yz2lW3axKTMURLW3omvXjZ5mdfPRnnhCaLiPDyJLxS1qSY= X-Received: by 2002:a05:6602:2504:: with SMTP id i4mr19060859ioe.173.1576515559642; Mon, 16 Dec 2019 08:59:19 -0800 (PST) MIME-Version: 1.0 References: <20191203134816.5319-1-jagan@amarulasolutions.com> <20191203134816.5319-2-jagan@amarulasolutions.com> <20191204133600.gnv6dnhk6upe7xod@gilmour.lan> <20191216112042.f4xvlgnbm4dk6wkq@gilmour.lan> In-Reply-To: <20191216112042.f4xvlgnbm4dk6wkq@gilmour.lan> From: Jagan Teki Date: Mon, 16 Dec 2019 22:29:08 +0530 Message-ID: Subject: Re: [PATCH v12 1/7] dt-bindings: sun6i-dsi: Document A64 MIPI-DSI controller To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191216_085922_108285_0F1B18A6 X-CRM114-Status: GOOD ( 24.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Airlie , linux-sunxi , dri-devel , linux-kernel , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 16, 2019 at 4:50 PM Maxime Ripard wrote: > > On Mon, Dec 16, 2019 at 04:37:20PM +0530, Jagan Teki wrote: > > On Wed, Dec 4, 2019 at 7:06 PM Maxime Ripard wrote: > > > > > > On Tue, Dec 03, 2019 at 07:18:10PM +0530, Jagan Teki wrote: > > > > The MIPI DSI controller in Allwinner A64 is similar to A33. > > > > > > > > But unlike A33, A64 doesn't have DSI_SCLK gating so it is valid > > > > to have separate compatible for A64 on the same driver. > > > > > > > > DSI_SCLK uses mod clock-names on dt-bindings, so the same > > > > is not required for A64. > > > > > > > > On that note > > > > - A64 require minimum of 1 clock like the bus clock > > > > - A33 require minimum of 2 clocks like both bus, mod clocks > > > > > > > > So, update dt-bindings so-that it can document both A33, > > > > A64 bindings requirements. > > > > > > > > Reviewed-by: Rob Herring > > > > Signed-off-by: Jagan Teki > > > > --- > > > > Changes for v12: > > > > - Use 'enum' instead of oneOf+const > > > > > > > > .../display/allwinner,sun6i-a31-mipi-dsi.yaml | 20 +++++++++++++++++-- > > > > 1 file changed, 18 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > > index dafc0980c4fa..b91446475f35 100644 > > > > --- a/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > > +++ b/Documentation/devicetree/bindings/display/allwinner,sun6i-a31-mipi-dsi.yaml > > > > @@ -15,7 +15,9 @@ properties: > > > > "#size-cells": true > > > > > > > > compatible: > > > > - const: allwinner,sun6i-a31-mipi-dsi > > > > + enum: > > > > + - allwinner,sun6i-a31-mipi-dsi > > > > + - allwinner,sun50i-a64-mipi-dsi > > > > > > > > reg: > > > > maxItems: 1 > > > > @@ -24,6 +26,8 @@ properties: > > > > maxItems: 1 > > > > > > > > clocks: > > > > + minItems: 1 > > > > + maxItems: 2 > > > > items: > > > > - description: Bus Clock > > > > - description: Module Clock > > > > @@ -63,13 +67,25 @@ required: > > > > - reg > > > > - interrupts > > > > - clocks > > > > - - clock-names > > > > - phys > > > > - phy-names > > > > - resets > > > > - vcc-dsi-supply > > > > - port > > > > > > > > +allOf: > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + const: allwinner,sun6i-a31-mipi-dsi > > > > + then: > > > > + properties: > > > > + clocks: > > > > + minItems: 2 > > > > + required: > > > > + - clock-names > > > > + > > > > > > Your else condition should check that the number of clocks items is 1 > > > on the A64 > > > > But the minItems mentioned as 1 in clocks, which is unchanged number > > by default. doesn't it sufficient? > > In the main schema, it's said that the clocks property can have one or > two elements (to cover the A31 case that has one, and the A64 case > that has 2). > > This is fine. > > Later on, you enforce that the A64 has two elements, and this is fine > too. Actually A31 case has 2 and A64 case has 1. > > However, you never check that on the A31 you only have one clock, and > you could very well have two and no one would notice. I did check A31 case for 2 but not in A64. this is what you mean? so adding A64 check like below would fine? allOf: - if: properties: compatible: contains: const: allwinner,sun6i-a31-mipi-dsi then: properties: clocks: minItems: 2 required: - clock-names - if: properties: compatible: contains: const: allwinner,sun50i-a64-mipi-dsi then: properties: clocks: minItems: 1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel