From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8682C4CED1 for ; Thu, 3 Oct 2019 07:01:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7D2E0222C5 for ; Thu, 3 Oct 2019 07:01:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pme+cHFs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="AYvgtbDi" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D2E0222C5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fkAo0CJT34hTOgwStJNQlyFzkm6rl1LOyAWJWM2hyiA=; b=Pme+cHFszoUIED j0niKGxmZydmGdHxsULIVNHaei8lu6k+UlkHcYMtCIyrJNoN8JK47DlDb8o7hbFCm9TZCnOBm+WOS 2puq+o8/WAt7f5WGK9Za5ZCrhSO1gzFS4WaxPcIp10YBZ6Zi0qv2PHrIh8RJPitmwIbm/q7EHj0IO VnhDw/msWqKSo8WcYebDrMmLroiPjDyqswfQeQ2lXgPPnwlJhdpW1kQ7iezdg+GK/g8jE0XcMok4T 1arMAwtoAsrJwyORL1KZeU21bvHnGU7xPW5QEyWNxEhujCilr6JPPuMWPSKN7z/+s0BslSwZbOpdY O5xdOk5vEeAwvag4sjsg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFv7S-0004lt-9r; Thu, 03 Oct 2019 07:01:46 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFv7P-0004lO-Jc for linux-arm-kernel@lists.infradead.org; Thu, 03 Oct 2019 07:01:45 +0000 Received: by mail-io1-xd42.google.com with SMTP id c6so2994843ioo.13 for ; Thu, 03 Oct 2019 00:01:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RaTSOsWkX0NwMXV+OVQ4GdiZGiGZm7DQLiGys1P/CwM=; b=AYvgtbDiQ21Bs+qVq2dGhqdNnCjEZtjI+RtycTGJZwDSFgTMwWE/ZDzIDSjDPI+4ko XIJkx4HVNDR3hj83PjWGh38PHwo7NJn/JnLE30yVfqtLZvxtTvU81/OWwr1NfwK1qwm8 ZsKxbOXBdfpY3Evv0RggiUM8VFxlUP6MW24aY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RaTSOsWkX0NwMXV+OVQ4GdiZGiGZm7DQLiGys1P/CwM=; b=QakMRBvLPClJp5lMfOmKMg3zQI4GjQ2NnQmXIqsxfcTS8iLrw/r4FvruRnLK7KcbGc xZ7PsNoapph53DqQbmPciRLYUfuyNrpssnD5+mbST+mbl7bthXgEXcjciUKuE/upjBTg 1oa4up7c5/NKJoUEaFXXNlX2abkSAEad+Up9t21DZTrTA9NLwS6KvkalcTRiiAGHb/TD c5fLv1mga2fI56FTkb6KiXPBSDZ5AV4Oakiyw+L7uidUtTIUDtOBd+Bxo4TlA+PCPF1I C/LhBrgeI20e90nkfFSGp+GlUfGET0Sj74k9WonBj66DoOZDf9eUXV41u238LypxHWWS KYgA== X-Gm-Message-State: APjAAAXSKVJjBcVp/zpYyCBB3wsVZUJcTeJ0EANJ8N8IhfyODNj0Eqh9 9SkTVJxqwdp3Kblh9qw4UxsrMWY7oeKDWDKjjgOYUg== X-Google-Smtp-Source: APXvYqxM2F/rF0fpKNncuUJT+YRkExY6NtSZFmZJqRNh7an4Mrr/PKtbKXdxgxjXj+qLiStrfZW997mYZqDUjGR51tg= X-Received: by 2002:a6b:2b07:: with SMTP id r7mr7264826ior.173.1570086102574; Thu, 03 Oct 2019 00:01:42 -0700 (PDT) MIME-Version: 1.0 References: <20191003064527.15128-1-jagan@amarulasolutions.com> <20191003064527.15128-6-jagan@amarulasolutions.com> In-Reply-To: From: Jagan Teki Date: Thu, 3 Oct 2019 12:31:31 +0530 Message-ID: Subject: Re: [PATCH v11 5/7] drm/sun4i: sun6i_mipi_dsi: Add VCC-DSI regulator support To: Chen-Yu Tsai X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191003_000143_791708_7D0A8B6A X-CRM114-Status: GOOD ( 17.51 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree , David Airlie , linux-kernel , Maxime Ripard , linux-sunxi , dri-devel , Daniel Vetter , Michael Trimarchi , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 3, 2019 at 12:26 PM Chen-Yu Tsai wrote: > > On Thu, Oct 3, 2019 at 2:46 PM Jagan Teki wrote: > > > > Allwinner MIPI DSI controllers are supplied with SoC > > DSI power rails via VCC-DSI pin. > > > > Add support for this supply pin by adding voltage > > regulator handling code to MIPI DSI driver. > > > > Tested-by: Merlijn Wajer > > Signed-off-by: Jagan Teki > > --- > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c | 14 ++++++++++++++ > > drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h | 2 ++ > > 2 files changed, 16 insertions(+) > > > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > index 446dc56cc44b..fe9a3667f3a1 100644 > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c > > @@ -1110,6 +1110,12 @@ static int sun6i_dsi_probe(struct platform_device *pdev) > > return PTR_ERR(base); > > } > > > > + dsi->regulator = devm_regulator_get(dev, "vcc-dsi"); > > + if (IS_ERR(dsi->regulator)) { > > + dev_err(dev, "Couldn't get VCC-DSI supply\n"); > > + return PTR_ERR(dsi->regulator); > > + } > > + > > dsi->regs = devm_regmap_init_mmio_clk(dev, "bus", base, > > &sun6i_dsi_regmap_config); > > if (IS_ERR(dsi->regs)) { > > @@ -1183,6 +1189,13 @@ static int sun6i_dsi_remove(struct platform_device *pdev) > > static int __maybe_unused sun6i_dsi_runtime_resume(struct device *dev) > > { > > struct sun6i_dsi *dsi = dev_get_drvdata(dev); > > + int err; > > + > > + err = regulator_enable(dsi->regulator); > > + if (err) { > > + dev_err(dsi->dev, "failed to enable VCC-DSI supply: %d\n", err); > > + return err; > > + } > > > > reset_control_deassert(dsi->reset); > > clk_prepare_enable(dsi->mod_clk); > > @@ -1215,6 +1228,7 @@ static int __maybe_unused sun6i_dsi_runtime_suspend(struct device *dev) > > > > clk_disable_unprepare(dsi->mod_clk); > > reset_control_assert(dsi->reset); > > + regulator_disable(dsi->regulator); > > > > return 0; > > } > > diff --git a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > index 5c3ad5be0690..a01d44e9e461 100644 > > --- a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > +++ b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.h > > @@ -12,6 +12,7 @@ > > #include > > #include > > #include > > +#include > > You don't need to include the header file since you are only > including a pointer to the struct, and nothing else. Yes, make sense. I will drop it. > > Otherwise, > > Reviewed-by: Chen-Yu Tsai thanks. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel