From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9B30CA9EC3 for ; Mon, 28 Oct 2019 22:34:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 970F120862 for ; Mon, 28 Oct 2019 22:34:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ss7VMvXW"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="n4p86Jog" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 970F120862 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iTsHg1TzRIbaXZdfI268hkR62fEHkyOiLbwhbmjyBW4=; b=Ss7VMvXWDH/Wm1 ixqHzqFaUYRQyclCGZE+jGscijlr/V7Z2JcU1ITQ4J6st+Lnh7A+rzEh2vyPcEXkHvcGrEzjXjHfj 6yX54lHuYZhNWnkYdleVx4iYBPte5HFHLY0KNk9vvo4JEN5kMXQuFG4UaX07slsOiS1K0+nwG3K4k jnxHyqWVhqDNrgvxEop2n47VCny3RDOgdv28rI/rn6SFaUMFyrVvig1Y3fPOPPqtkED+AiwblhY7h GKPMvSfcQqtFs7hFBwgRb5fvRW/iiCA8PdC2zP0XJj6WswrJbiQsA9mj9ENGkPBF/lBhSMPR6dEy3 NK22V04fPRQhGGhus/BQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPDaY-0008Uc-T1; Mon, 28 Oct 2019 22:34:14 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPDaU-0008Tg-Rs for linux-arm-kernel@lists.infradead.org; Mon, 28 Oct 2019 22:34:13 +0000 Received: by mail-il1-x142.google.com with SMTP id o16so9621910ilq.9 for ; Mon, 28 Oct 2019 15:34:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c2XX2oa9okl2tfpust4RUifahZHp7tb1+MoPm2u47Wc=; b=n4p86JogluIaUwX8lpVfKCl315ggHShPT/3PG9nmdvv6A+WmkcxoXlJ1p500UHclpZ V7orIaazLLn5Miq8ZaNeWiihu1+79cg9oAg+i/LcaIdcqZQ5iG4T4aVCMjo26c+Cdn97 r3IOx7w0Y6kNlL3cRfnacuWuUmSw1xh6YKtgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c2XX2oa9okl2tfpust4RUifahZHp7tb1+MoPm2u47Wc=; b=aeKR2YV9PjLNAlcl4KczQRJBFRJ81ZoX9c/o4cf+XzrfoqTHtNXsa4MU8L22dXIrOD x3fedELLSeQy33hpyo1syvmqraqg4y4io22IJ6YMyokqYNC+V2YMInJaBB3A9rMARf+q idDSTOwdf0i9i16YZf/5eA/W636AbuTX7p+I3PGVWTGdTlELHQvF6f6vt+TZ9+Fj9g59 qHZpt8SR06cAgIVTwarRNVBMiN4+bnNM6Fvjdi6QuP+SsOO/0uJX2H/FvTVZiikj2gyG du17j8V2NrhELXF6+FftuaL7mqt0tt4x3E4LDFPr12txy6aR97k4EQ29MBIOyWctge4+ /Cjw== X-Gm-Message-State: APjAAAWkz2cQr5xlHSZ/GpCl6zqJdkqZhnmaGQYYvXG1SbBflWkWdi9A aqNd+fgQDNuLHi5SnH1oNfVS6DI+McLDmcBRbZ+QVQ== X-Google-Smtp-Source: APXvYqyCGJQl+HAm+sa8mYYJp4Wxr/m+y+g/6ntOZCrMubS4XyZUczCAk4EdzfbP8O6fyXYOHmttxwz3zGzyvqk0tc0= X-Received: by 2002:a92:99ca:: with SMTP id t71mr8413794ilk.61.1572302047950; Mon, 28 Oct 2019 15:34:07 -0700 (PDT) MIME-Version: 1.0 References: <20191025175625.8011-1-jagan@amarulasolutions.com> <20191025175625.8011-5-jagan@amarulasolutions.com> <20191028153427.pc3tnoz2d23filhx@hendrix> In-Reply-To: <20191028153427.pc3tnoz2d23filhx@hendrix> From: Jagan Teki Date: Tue, 29 Oct 2019 04:03:56 +0530 Message-ID: Subject: Re: [PATCH v11 4/7] drm/sun4i: dsi: Handle bus clock explicitly To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_153411_845789_9FE6B022 X-CRM114-Status: GOOD ( 14.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , David Airlie , linux-sunxi , dri-devel , linux-kernel , Chen-Yu Tsai , Rob Herring , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel , Icenowy Zheng Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Maxime, On Mon, Oct 28, 2019 at 9:06 PM Maxime Ripard wrote: > > On Fri, Oct 25, 2019 at 11:26:22PM +0530, Jagan Teki wrote: > > Usage of clocks are varies between different Allwinner > > DSI controllers. Clocking in A33 would need bus and > > mod clocks where as A64 would need only bus clock. > > > > To support this kind of clocking structure variants > > in the same dsi driver, > > There's no variance in the clock structure as far as the bus clock is > concerned. > > > explicit handling of common clock would require since the A64 > > doesn't need to mention the clock-names explicitly in dts since it > > support only one bus clock. > > > > Also pass clk_id NULL instead "bus" to regmap clock init function > > since the single clock variants no need to mention clock-names > > explicitly. > > You don't need explicit clock handling. Passing NULL as the argument > in regmap_init_mmio_clk will make it use the first clock, which is the > bus clock. Indeed I tried that, since NULL clk_id wouldn't enable the bus clock during regmap_mmio_gen_context code, passing NULL triggering vblank timeout. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel