From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23410C31E45 for ; Thu, 13 Jun 2019 08:04:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED8F720896 for ; Thu, 13 Jun 2019 08:04:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XS8PV0G5"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="lTEEDc27" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED8F720896 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=WZfZYgm2uAfpxEF+8ox0crk3z2T+tCYqfmsqdRMCb08=; b=XS8PV0G5O6FvMG O4kQFi8KgTyeZjwyGgEB4ma0SOk5nqonuw9sfdav+ra3aft50HX2OelolqA+56ng3z4b8Qh2bITwd 5NLKujdquXa5lkU74FGVmrqGWjxaFISvpIAxIazEv0VJwUJVWGXF+Pl1GB3zdLGwJV2XpwjSnFy9r zJIKYhyWdb9B+jy+o3IPwX0k/IAtCTtnJiHOiMfrcysf77WRBlPkudk7HVGVlRi9UM8vtFugMDARP mezz2wyXHhSLmZrDgbHCB5lzxUYSGbfwlFyWbM1Zaa2L6ylDBYMJrYWuPyRfUVlJGRTQxLyR0KmNc 9H93KqaFfE/3m0kR8vmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbKie-0008Ri-80; Thu, 13 Jun 2019 08:04:24 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hbKia-0008Qu-C6 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 08:04:22 +0000 Received: by mail-io1-xd41.google.com with SMTP id n5so15253035ioc.7 for ; Thu, 13 Jun 2019 01:04:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=koN+00G7CU0eh11NaVYbCwU6i9zCMJjXz116ZdVU+xU=; b=lTEEDc27WypEUHtSdTgUvnXupW5/VUK3QMCoMTGJX3XVCWkkoxUv9sl4p2XYpfv+Xs hYfL5X/8NXtBbC3/bWgFrTBB0dXM8s71qpMZInzNpqc90yYlOvYCoL84/ErHox3e01cg ACU5CrA5DnCLwUy7BivPu5L8ln3CYfqM38Pjg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=koN+00G7CU0eh11NaVYbCwU6i9zCMJjXz116ZdVU+xU=; b=ocRLru8F9qA17n1u24jV5/ePuHHeGP2IoVAuUly2LUzwzFxUTWmGDV+q48d4phdfTU pZv8KIXaWGpn7WtdDY3vWmvVZJxqC5bglRcFPE+yohI+hndU78pWPXRr2SxqSFbnrNDy yJJ8O1W+SJ3Exny0i/UPAHPcTWNRciF2fGbWPJaYwX87/iEbPLT1LvNenMnW3sl3+KCi BoU+Qz576fcylG/rwNFfMfCeCmpfq2tSucz1fhJfx7jH+Jy37widyvSGlv4DssqWi3pT Z+6ixwbsGqv/Y7hyu58tIai4MiAEU2aEoyB+LPdMCQdb2Sh9l6xakUBH3rSX0blXYAVD OTsw== X-Gm-Message-State: APjAAAX25md8HGmuyV2L4ne3FnEVOh1qMjLmh2WFjTJMbdsZ6/ual/ZF ViX013hoeFk4aU+CjqW3gyvu3iV+xCo47JFp6irLuw== X-Google-Smtp-Source: APXvYqzpYyrAAPRFueEyS+j4+BBscppU+Zr9W00YE1s8AZSWRgXHWdfv0Q00CHduNxq6esClfTmSm5lW1IAFFoTPsuo= X-Received: by 2002:a6b:6b14:: with SMTP id g20mr51062517ioc.28.1560413055231; Thu, 13 Jun 2019 01:04:15 -0700 (PDT) MIME-Version: 1.0 References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-3-jagan@amarulasolutions.com> <20190523203754.2lhi37veeh4rwiy3@flea> <20190530104242.d6ktwv7lip27vc3x@flea> In-Reply-To: <20190530104242.d6ktwv7lip27vc3x@flea> From: Jagan Teki Date: Thu, 13 Jun 2019 13:34:04 +0530 Message-ID: Subject: Re: [PATCH v10 02/11] drm/sun4i: dsi: Update start value in video start delay To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_010420_417337_3404ED55 X-CRM114-Status: GOOD ( 25.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bhushan Shah , David Airlie , linux-sunxi , linux-kernel , dri-devel , =?UTF-8?B?5Z2a5a6a5YmN6KGM?= , Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 31, 2019 at 12:23 AM Maxime Ripard wrote: > > On Fri, May 24, 2019 at 03:55:42PM +0530, Jagan Teki wrote: > > On Fri, May 24, 2019 at 2:07 AM Maxime Ripard wrote: > > > > > > On Mon, May 20, 2019 at 02:33:09PM +0530, Jagan Teki wrote: > > > > start value in video start delay computation done in below commit > > > > is as per the legacy bsp drivers/video/sunxi/legacy.. > > > > "drm/sun4i: dsi: Change the start delay calculation" > > > > (sha1: da676c6aa6413d59ab0a80c97bbc273025e640b2) > > > > > > > > This existing start delay computation gives start value of 35, > > > > for "bananapi,s070wv20-ct16" panel timings which indeed trigger > > > > panel flip_done timed out as: > > > > > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > > > [CRTC:46:crtc-0] vblank wait timed out > > > > Modules linked in: > > > > CPU: 0 PID: 31 Comm: kworker/0:1 Tainted: G W 5.1.0-next-20190514-00025-gf928bc7cc146 #15 > > > > Hardware name: Allwinner sun8i Family > > > > Workqueue: events deferred_probe_work_func > > > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_pan_display+0xac/0x1d0) > > > > [] (drm_fb_helper_pan_display) from [] (fb_pan_display+0xcc/0x134) > > > > [] (fb_pan_display) from [] (bit_update_start+0x14/0x30) > > > > [] (bit_update_start) from [] (fbcon_switch+0x3d8/0x4e0) > > > > [] (fbcon_switch) from [] (redraw_screen+0x174/0x238) > > > > [] (redraw_screen) from [] (fbcon_prepare_logo+0x3c4/0x400) > > > > [] (fbcon_prepare_logo) from [] (fbcon_init+0x3c8/0x5ac) > > > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > > > Exception stack(0xde539fb0 to 0xde539ff8) > > > > 9fa0: 00000000 00000000 00000000 00000000 > > > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > > > ---[ end trace 755e10f62b83f396 ]--- > > > > Console: switching to colour frame buffer device 100x30 > > > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:46:crtc-0] flip_done timed out > > > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:48:DSI-1] flip_done timed out > > > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:30:plane-0] flip_done timed out > > > > > > > > But the expected start delay value is 1 which is confirmed from > > > > new bsp [2]. > > > > > > If you're saying that the "legacy" link (second one) is the new BSP. > > > > Will update, thanks. > > > > > > > > > The important and unclear note on legacy and new bsp codes [1] [2] > > > > is both use similar start computation initially but it later reassign > > > > it to 1 in new bsp. > > > > > > Then start_delay is never reassigned to 1 in that link, and is clamped > > > between 8 and 100 as the code that you are removing is doing. > > > > Please see the link one more please > > https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/lowlevel_sun8iw5/de_dsi.c#L807 > > > > > > > > > Unfortunately we don't have any evidence or documentation for this > > > > reassignment to 1 in new bsp, but it is working with all supported > > > > panels in A33, A64. > > > > > > No, it's not. That was added to fix a panel that is supported today. > > > > No, I have see this in A33, A64. and these are controller drivers > > right, if it panel fix and it should be part of panel driver isn't > > it? > > I'm not sure to follow that argument. You're submitting that fix to > allow other panels to work, right? So surely, some issues that can be > found using a given panel might not be solely fixed in the panel driver. I'm not sure I understand this. I have been verifying different panels to check across. and this change literally in BSP and the BSP code is using this based on the logs confirmation. all the logs and working conditions shows that the fix would required in dsi. > > > We can even see the same in pin64 longsleep kernel and others. > > > > https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/lowlevel_sun8iw5/de_dsi.c#L807 > > https://github.com/longsleep/linux-pine64/blob/pine64-hacks-1.2/drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c#L730 > > Yeah, and both of these have the legacy driver part with the clamping > too. Yes, both legacy has clamping, but not using. they used it in new version driver which I'm referring above. > > I'll test these patches again some time next week Any help on the testing. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel