From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D601C072B5 for ; Fri, 24 May 2019 10:19:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F91320856 for ; Fri, 24 May 2019 10:19:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XiRhYSeX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="WEpmWyHP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6F91320856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xki+qjHMDGgvsovRRoDCNB1sePC2CRSJvRAMVcZV5xU=; b=XiRhYSeXngnC1X UXt5aSH32HImL2Occ4OfyKK4yNF7q7wfk+m6C4/2U4sKOwHAoSE/k/ZaNoeV1dtpffxtTMGz+g7h/ M2LhHRHXDvqylxVGfhsAJFkR31SqtIFbfAYHJaLIFxuAG3ZbqtlSWZBis1gDHeRQiDCuH8jPtmeTj 6KpWkkLjgc6152BKgtI6ipP0nO9fvlJkecbBq20Ra0oIMASt1LCy8Kq/oZO3fH1sSknBK9PB1umYE qVI57H3XrrN22hT/Qq49Qucl6WOdZioPSL7yeJzqRbs2IpscwJQia9K7OQGfaxkc+sIvx1TIrjf7i F6RpNUr5GHEX8OPCowsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hU7I6-0005YQ-F1; Fri, 24 May 2019 10:19:10 +0000 Received: from mail-it1-x142.google.com ([2607:f8b0:4864:20::142]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hU7I2-0005Y0-79 for linux-arm-kernel@lists.infradead.org; Fri, 24 May 2019 10:19:08 +0000 Received: by mail-it1-x142.google.com with SMTP id a186so4979519itg.0 for ; Fri, 24 May 2019 03:19:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+1O9AXcjrMEu4VeLA6eEenuC1bu9Kn9d6D6TJCNVW/s=; b=WEpmWyHPGsIqnGbVr25U+H+O1V7K7r5ZM4DIQDiLOm/1DAq5l3NCzBiW8w7qaZgRng wrR/RRutN874X1u8wct97AQ5lw/eEZTkNwmr9jtoCjAeLK49Ywb1+j+bdmc8HLjyB1Pl RQ9TsxYtyLhBqW0uHXVgo6l2eQ9bI9hhHykN0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+1O9AXcjrMEu4VeLA6eEenuC1bu9Kn9d6D6TJCNVW/s=; b=XrZXaXG1kVdAZehM7EifvvaSEYxNtSC1r8j+ZfuJr9Zrh5yImLa3Z4/vVgNunRXItW V/I2IiOUDZ1vWWLfkxwoSoisBeoAdBYGlpSTlSz9OTScKQKV95Z5W0LKQiyUaaXLazej ura9TFsMcPF2k3hFXWvPPnt+yl/FBnE1injhkUTQt72ImLtb6EGyWSyHWiKtkULNIbDJ 131XAgWxSL7M0qb1gczQQBQ9wF9zqmrIkZkBKtZC0kSaeDTD8oJFc3ysPsuXXoPJKBH+ pE0TRTF9t+pM9N+95zUvbQNPVvRxfZmzFhdDNkjLEhYRaSVlS32LHNerTHOj/u0+5RvY vjTg== X-Gm-Message-State: APjAAAWnCrPqwgCzlVAToSmhqcmvhIbkRAFzAWDZRTv2yE+j70H0kE1j NDP2zsT/zd4vhmPHE6vNuNnzIOzHTGrF7GFi2zkA3g== X-Google-Smtp-Source: APXvYqwaPWtOa1oDtBly0jMp86HBmnUtTePjmdZJW5YYeLXvqjVQp2GFW09QEmuwR4PuP52viuzvwhAmG1SO3zLGSaY= X-Received: by 2002:a02:241:: with SMTP id 62mr26933937jau.58.1558693142640; Fri, 24 May 2019 03:19:02 -0700 (PDT) MIME-Version: 1.0 References: <20190520090318.27570-1-jagan@amarulasolutions.com> <20190520090318.27570-2-jagan@amarulasolutions.com> <20190523203407.o5obg2wtj7wwau6a@flea> In-Reply-To: <20190523203407.o5obg2wtj7wwau6a@flea> From: Jagan Teki Date: Fri, 24 May 2019 15:48:51 +0530 Message-ID: Subject: Re: [PATCH v10 01/11] drm/sun4i: dsi: Fix TCON DRQ set bits To: Maxime Ripard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190524_031906_447384_D516535E X-CRM114-Status: GOOD ( 16.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bhushan Shah , David Airlie , linux-sunxi , linux-kernel , dri-devel , =?UTF-8?B?5Z2a5a6a5YmN6KGM?= , Chen-Yu Tsai , Daniel Vetter , Michael Trimarchi , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, May 24, 2019 at 2:04 AM Maxime Ripard wrote: > > On Mon, May 20, 2019 at 02:33:08PM +0530, Jagan Teki wrote: > > According to "DRM kernel-internal display mode structure" in > > include/drm/drm_modes.h the current driver is trying to include > > sync timings along with front porch value while checking and > > computing drq set bits in non-burst mode. > > > > mode->hsync_end - mode->hdisplay => horizontal front porch + sync > > > > With adding additional sync timings, the dsi controller leads to > > wrong drq set bits for "bananapi,s070wv20-ct16" panel which indeed > > trigger panel flip_done timed out as: > > > > WARNING: CPU: 0 PID: 31 at drivers/gpu/drm/drm_atomic_helper.c:1429 drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0 > > [CRTC:46:crtc-0] vblank wait timed out > > Modules linked in: > > CPU: 0 PID: 31 Comm: kworker/0:1 Not tainted 5.1.0-next-20190514-00026-g01f0c75b902d-dirty #13 > > Hardware name: Allwinner sun8i Family > > Workqueue: events deferred_probe_work_func > > [] (unwind_backtrace) from [] (show_stack+0x10/0x14) > > [] (show_stack) from [] (dump_stack+0x84/0x98) > > [] (dump_stack) from [] (__warn+0xfc/0x114) > > [] (__warn) from [] (warn_slowpath_fmt+0x44/0x68) > > [] (warn_slowpath_fmt) from [] (drm_atomic_helper_wait_for_vblanks.part.1+0x298/0x2a0) > > [] (drm_atomic_helper_wait_for_vblanks.part.1) from [] (drm_atomic_helper_commit_tail_rpm+0x5c/0x6c) > > [] (drm_atomic_helper_commit_tail_rpm) from [] (commit_tail+0x40/0x6c) > > [] (commit_tail) from [] (drm_atomic_helper_commit+0xbc/0x128) > > [] (drm_atomic_helper_commit) from [] (restore_fbdev_mode_atomic+0x1cc/0x1dc) > > [] (restore_fbdev_mode_atomic) from [] (drm_fb_helper_restore_fbdev_mode_unlocked+0x54/0xa0) > > [] (drm_fb_helper_restore_fbdev_mode_unlocked) from [] (drm_fb_helper_set_par+0x30/0x54) > > [] (drm_fb_helper_set_par) from [] (fbcon_init+0x560/0x5ac) > > [] (fbcon_init) from [] (visual_init+0xbc/0x104) > > [] (visual_init) from [] (do_bind_con_driver+0x1b0/0x390) > > [] (do_bind_con_driver) from [] (do_take_over_console+0x13c/0x1c4) > > [] (do_take_over_console) from [] (do_fbcon_takeover+0x74/0xcc) > > [] (do_fbcon_takeover) from [] (notifier_call_chain+0x44/0x84) > > [] (notifier_call_chain) from [] (__blocking_notifier_call_chain+0x48/0x60) > > [] (__blocking_notifier_call_chain) from [] (blocking_notifier_call_chain+0x18/0x20) > > [] (blocking_notifier_call_chain) from [] (register_framebuffer+0x1e0/0x2f8) > > [] (register_framebuffer) from [] (__drm_fb_helper_initial_config_and_unlock+0x2fc/0x50c) > > [] (__drm_fb_helper_initial_config_and_unlock) from [] (drm_fbdev_client_hotplug+0xe8/0x1b8) > > [] (drm_fbdev_client_hotplug) from [] (drm_fbdev_generic_setup+0x88/0x118) > > [] (drm_fbdev_generic_setup) from [] (sun4i_drv_bind+0x128/0x160) > > [] (sun4i_drv_bind) from [] (try_to_bring_up_master+0x164/0x1a0) > > [] (try_to_bring_up_master) from [] (__component_add+0x94/0x140) > > [] (__component_add) from [] (sun6i_dsi_probe+0x144/0x234) > > [] (sun6i_dsi_probe) from [] (platform_drv_probe+0x48/0x9c) > > [] (platform_drv_probe) from [] (really_probe+0x1dc/0x2c8) > > [] (really_probe) from [] (driver_probe_device+0x60/0x160) > > [] (driver_probe_device) from [] (bus_for_each_drv+0x74/0xb8) > > [] (bus_for_each_drv) from [] (__device_attach+0xd0/0x13c) > > [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) > > [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) > > [] (deferred_probe_work_func) from [] (process_one_work+0x204/0x420) > > [] (process_one_work) from [] (worker_thread+0x274/0x5a0) > > [] (worker_thread) from [] (kthread+0x11c/0x14c) > > [] (kthread) from [] (ret_from_fork+0x14/0x2c) > > Exception stack(0xde539fb0 to 0xde539ff8) > > 9fa0: 00000000 00000000 00000000 00000000 > > 9fc0: 00000000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 > > 9fe0: 00000000 00000000 00000000 00000000 00000013 00000000 > > ---[ end trace b57eb1e5c64c6b8b ]--- > > random: fast init done > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CRTC:46:crtc-0] flip_done timed out > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [CONNECTOR:48:DSI-1] flip_done timed out > > [drm:drm_atomic_helper_wait_for_dependencies] *ERROR* [PLANE:30:plane-0] flip_done timed out > > > > But according to Allwinner A33, A64 BSP code [1] [3] the TCON DRQ for > > non-burst DSI mode can be computed based on "horizontal front porch" > > value only (no sync timings included). > > > > Detailed evidence for drq set bits based on A33 BSP [1] [2] > > > > => panel->lcd_ht - panel->lcd_x - panel->lcd_hbp - 20 > > => (tt->hor_front_porch + lcdp->panel_info.lcd_hbp + > > lcdp->panel_info.lcd_x) - panel->lcd_x - panel->lcd_hbp - 20 > > => tt->hor_front_porch - 20 > > The thing is, while your explanation on the DRM side is sound, > Allwinner has been using the hbp field of their panel description to > store what DRM calls the backporch and the sync period. Exactly, hbp = backporch + sync https://github.com/BPI-SINOVOIP/BPI-M2M-bsp/blob/master/linux-sunxi/drivers/video/sunxi/disp/de/disp_lcd.c#L2046 And the above computation is rely on that as well. If you can see the final out of the above computation you can get the front porch value (w/o sync ) > > And nowhere in that commit log you are describing whether it's still > an issue or not, and if it's not anymore how you did test that it's > not the case anymore. No, I have explained 1st and 2nd para about 00. There is any additional sync timings in the drq set bits 01: issue occur due to adding addition sync timings with longs on the panel, by referring 03: and later paragraphs proved that there is no sync timings used in BSP Am I missing anythings? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel