From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 090F8C388F3 for ; Tue, 1 Oct 2019 10:26:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D35CE21924 for ; Tue, 1 Oct 2019 10:26:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eEQrBFQb"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=amarulasolutions.com header.i=@amarulasolutions.com header.b="MW/6KBSt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D35CE21924 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amarulasolutions.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=e2cCHxLdG3RG5DQCmcSHQt5HjooRtvC30OFgDSy/8cQ=; b=eEQrBFQbIfj58H 1SrRcOeuoIaSc8ztIn068besv/LWuuO6MRp9y9vkyYT3DmmAX10XN1hZQJBQ3PtdSfsg/VkTLatcc h6eUAkz71EbB8Js9I6NACJaHY87k4E5o4KRMd+lHqvAPU10o7uAuRSgq6uEYOHo+YnldwJlyoW9gQ 6vFkg+tCOJMbIgXz0wkw20mAIQE8BUFDvgCMq+nJ/8ktui9zZ+e8CpILT49xiVLo63dRqKFoc9Zqk knrUlNt7uwMSAr4S+T6dJQGPEvYTKDtHO9vqj7ljt5LGYc75F2H+PyE4UOF0gAW+gMGRKfWuD+Z2V +POB2wbf48YE+bCEkd9g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFFMV-0004Wd-Cr; Tue, 01 Oct 2019 10:26:31 +0000 Received: from mail-io1-xd41.google.com ([2607:f8b0:4864:20::d41]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iFFMR-0004VD-14 for linux-arm-kernel@lists.infradead.org; Tue, 01 Oct 2019 10:26:29 +0000 Received: by mail-io1-xd41.google.com with SMTP id u8so46485597iom.5 for ; Tue, 01 Oct 2019 03:26:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7dJvQt2XADSP58gshAp3mouDAHa/fpvN+3lt4rGrgN0=; b=MW/6KBStB07v5dXk4ZigslPFPugYyqpQ/ScdkbBrgCiKH3o4AbFDQ1qwAd32i3L1Ut qcFaTGc/lhLrM65+N2L6mT4GH2quV73dZ3OW0f6J3hfFwX4x/zkGKr+2BK03MWo28DBy KNoWV2aGvRV8NEKSqzFK7sgsmnnNqr38yDafY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7dJvQt2XADSP58gshAp3mouDAHa/fpvN+3lt4rGrgN0=; b=N8/4EeyaDs2o6i7jx7/GVe/mWPuaIIELqBkSu2yzzU5iZ3ombD+6KQY+PA9JAhTagN NDP1pKD/rUxNSqHshfMQnM0BzKKkPK24FwXsbSyFJ9L56zPVHGntUJOAwBuJYQx0g7a6 N/ZFp1L1xK/tSVbQFduXdiO5+dMVZphL1hUd9Ly5KzQUW0aq6dsbfScd5ZvKZtcc2M3x mHKKaksX/21WrCugs3oxKO9YOZ7FZ8B0Suyzh8EKLIx/HCIGNjxDEFOIElYrFAr7occG 3OPoZjlUGu1G+TdOprjKPhGdMq6Vay6+o4d/VuVE6TeMlroV/8KYvYt1gG9VCmVF7Sez rlOg== X-Gm-Message-State: APjAAAWCo2OYOaxHSKQZlc7imefYMRsexx2AT2918CcuNjdX0dqOW/0w Q/YDtYE9gZskd0o/kUT2YwurrjuGu8Z47uwDO6kpSg== X-Google-Smtp-Source: APXvYqyE36IiztYNTVOMhjmeAHCFxs73KTI2V5Ei5/NiBQ6XuIFOw+4jhZSV1acSSHmC1qFffPrmWbSyxu+uPa3yx0A= X-Received: by 2002:a5d:89da:: with SMTP id a26mr23534629iot.61.1569925585423; Tue, 01 Oct 2019 03:26:25 -0700 (PDT) MIME-Version: 1.0 References: <20190919052822.10403-1-jagan@amarulasolutions.com> <20190919052822.10403-2-jagan@amarulasolutions.com> <6797961.eJj5WIFbM9@phil> In-Reply-To: <6797961.eJj5WIFbM9@phil> From: Jagan Teki Date: Tue, 1 Oct 2019 15:56:14 +0530 Message-ID: Subject: Re: [PATCH 1/6] arm64: dts: rockchip: Fix rk3399-roc-pc pwm2 pin To: Heiko Stuebner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191001_032627_494595_75A0BDC7 X-CRM114-Status: GOOD ( 18.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Da Xue , linux-kernel , "open list:ARM/Rockchip SoC..." , Rob Herring , Akash Gajjar , Levin Du , linux-amarula , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heiko, On Mon, Sep 30, 2019 at 2:51 AM Heiko Stuebner wrote: > > Hi Jagan, > > Am Donnerstag, 19. September 2019, 07:28:17 CEST schrieb Jagan Teki: > > ROC-PC is not able to boot linux console if PWM2_d is > > unattached to any pinctrl logic. > > > > To be precise the linux boot hang with last logs as, > > ... > > ..... > > [ 0.003367] Console: colour dummy device 80x25 > > [ 0.003788] printk: console [tty0] enabled > > [ 0.004178] printk: bootconsole [uart8250] disabled > > > > In ROC-PC the PWM2_d pin is connected to LOG_DVS_PWM of > > VDD_LOG. So, for normal working operations this needs to > > active and pull-down. > > > > This patch fix, by attaching pinctrl active and pull-down > > the pwm2. > > This looks highly dubious on first glance. The pwm subsystem nor > the Rockchip pwm driver do not do any pinctrl handling. > > So I don't really see where that "active" pinctrl state is supposed > to come from. > > Comparing with the pwm driver in the vendor tree I see that there > is such a state defined there. But that code there also looks strange > as that driver never again leaves this active state after entering it. > > Also for example all the Gru devices run with quite a number of pwm- > regulators without needing additional fiddling with the pwm itself, so > I don't really see why that should be different here. I deed, I was supposed to think the same. but the vendor kernel dts from firefly do follow the pwm2 pinctrl [1]. I wouldn't find any information other than this vensor information, ie one of the reason I have marked "Levin Du" who initially supported this board. One, think I have seen was this pinctrl active fixed the boot hang. any inputs from would be very helpful. Levin Du, any inputs? [1] https://github.com/FireflyTeam/kernel/blob/stable-4.4-rk3399-linux/arch/arm64/boot/dts/rockchip/rk3399-roc-pc.dtsi#L1184 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel