From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56612C433ED for ; Mon, 19 Apr 2021 13:56:29 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B08B761077 for ; Mon, 19 Apr 2021 13:56:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B08B761077 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-m68k.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xbhx0HXWJO46ItMuur3E5oEBvgWlm9/BHmghtzLOTsg=; b=ibI2PNTPvu5aVEWLUQ2h/4fJ3 3Yiqwo/7lKiHosBQ0K9IXsKVQmVS9aZXWE/ozKteJeI12INpyPy5wNg7vM26HFqfP3rXHhdV60EI/ aV6jGLTVyjbEfUAv16882Yz+Mbq3mQXXylrjZ/mO5vFTk7jmd8npGrs87MnQ7IVlZp8hP0NNhfB3/ KNKILnfxrUiQ9ZUih4z5mNBET34ab8/pmJDhbUXK8EYLIfpYCvPCC+25u7aF2WxXfqY45ne7cr/R2 qEWUujuHLRg9OCBFxsNjPzPSk/wFJBv1Q+4PQ+wICAMjIzdT+DUn6XeVKmEoQaOZfnvfxkpwYppme f5aScq4Ow==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lYUMA-00A1xn-AC; Mon, 19 Apr 2021 13:54:30 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUM8-00A1xd-5X for linux-arm-kernel@desiato.infradead.org; Mon, 19 Apr 2021 13:54:28 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type:Cc:To:Subject:Message-ID :Date:From:In-Reply-To:References:MIME-Version:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=JL6d1XdDaj8WiEzJbvQLLWoDwh1itkt9fBhBIziUdrE=; b=Hl7xYaxy/SAKngItT2jJLAQ6tQ OBa/gqFa2PtxGFS4C6tb77vR0BEmt4G2rbTtsR5Ykw4qHZvrGnrc34i2XtpeHXSYz06xfinpdklAk bfDRMv/DzkgtdJXrHGp7P2LujojjdOgtJrZ3iHToXEFTWGUpmMpBxqiknreOUQNtm44D8DVFv3UUi nB+wbzOXvQi2+P7qtrRChHgLb7mWmwIxC836VzPbjupMCpvDouhmjSWsIHZFtp8OF0HlRj1P2xu7a YbkC58V8hfEm+QVVIlygcrkMNeseKOC4ZwoTMQSMBGJg5McA9k06HillmBOYz1TT16SpuIKh7aSDn htmo+/5Q==; Received: from mail-ua1-f46.google.com ([209.85.222.46]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lYUM2-00BQ95-B1 for linux-arm-kernel@lists.infradead.org; Mon, 19 Apr 2021 13:54:26 +0000 Received: by mail-ua1-f46.google.com with SMTP id m20so6049587uah.0 for ; Mon, 19 Apr 2021 06:54:22 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JL6d1XdDaj8WiEzJbvQLLWoDwh1itkt9fBhBIziUdrE=; b=Hp4MNR2rUzWX5HAXchoM+DPaSjtCPm/ljWOtj76HwFZi+1zxiZq9x6sGFOoK9vWW6S GPjxkNqZhN3KihsDZVnZK1UpQmltj/JK6zZ3WcrPlTGKG0ci2PBGvrSL8KSoigjUDPTF Km6aeCcJiB151tCm1fXqvMTFVqToiD8y57aImkIl7RYGqZDhZkp/CPByfS4KZHbfHA/O EwSsoZOsVsukHOiDkomEsM9GlSQB6sUbx9RTPqxfcDoibfIQD0dgfhXoMEA/rldy4fmC dzxxvQuvRc5MSNqeHUTvKESUxKkNqKCAKlnRgBd3xU/oz3+NyfmfD4rX7f+9OWlBLJkW Y6+A== X-Gm-Message-State: AOAM533kFWWSdBQYyHzFN5xZZE8e6CC1K0Rl5skckQK7bEZdVCNfNHx3 umu5SMx8BnGsippzLau09jiYtxvoyPiUqReRL/jHov7clBAaPw== X-Google-Smtp-Source: ABdhPJyjQdTQ1aETHy6U3DdnBYa0ha6mMDdDcINzkW86JQMI52CmM0oSsy2rSRgm5LHhvDe6IrlXkhiqQ5078m8cBVQ= X-Received: by 2002:ab0:2c16:: with SMTP id l22mr7503352uar.100.1618840461416; Mon, 19 Apr 2021 06:54:21 -0700 (PDT) MIME-Version: 1.0 References: <26db9291095c1dfd81c73b0f5f1434f9b399b1f5.1618316565.git.geert+renesas@glider.be> In-Reply-To: From: Geert Uytterhoeven Date: Mon, 19 Apr 2021 15:54:10 +0200 Message-ID: Subject: Re: [PATCH] i2c: I2C_HISI should depend on ARCH_HISI && ACPI To: Andy Shevchenko Cc: Andy Shevchenko , Yicong Yang , Wei Xu , Wolfram Sang , Dmitry Osipenko , Linux I2C , Linux ARM , Linux Kernel Mailing List , Linuxarm X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210419_065422_404545_F6F72F47 X-CRM114-Status: GOOD ( 39.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Andy, On Mon, Apr 19, 2021 at 3:35 PM Andy Shevchenko wrote: > On Mon, Apr 19, 2021 at 4:02 PM Geert Uytterhoeven wrote: > > On Thu, Apr 15, 2021 at 10:50 AM Andy Shevchenko > > wrote: > > > On Thu, Apr 15, 2021 at 3:43 AM Geert Uytterhoeven wrote: > > > > On Wed, Apr 14, 2021 at 9:14 PM Andy Shevchenko > > > > wrote: > > > > > On Wed, Apr 14, 2021 at 08:55:21PM +0200, Geert Uytterhoeven wrote: > > > > > > On Wed, Apr 14, 2021 at 8:18 PM Andy Shevchenko > > > > > > wrote: > > > > > > > On Wed, Apr 14, 2021 at 08:06:18PM +0200, Geert Uytterhoeven wrote: > > > > > > > > On Wed, Apr 14, 2021 at 11:24 AM Yicong Yang wrote: > > ... > > > > > > > > > I guess it's still fine to add a dependency on ACPI? > > > > > > > > > > > > > > But why? > > > > > > > > > > > > Please tell me how/when the driver is used when CONFIG_ACPI=n. > > > > > > > > > > I'm not using it at all. Ask the author :-) > > > > > > > > > > But if we follow your logic, then we need to mark all the _platform_ drivers > > > > > for x86 world as ACPI dependent? This sounds ugly. > > > > > > > > Do all other x86 platform drivers have (1) an .acpi_match_table[] and > > > > (2) no other way of instantiating their devices? > > > > The first driver from the top of my memory I looked at is rtc-cmos: > > > > it has no .acpi_match_table[], and the rtc-cmos device is instantiated > > > > from arch/x86/kernel/rtc.c. > > > > > > > > For drivers with only an .of_match_table(), and no legacy users > > > > instantiating platform devices, we do have dependencies on OF. > > > > > > This is not true. Entire IIO subsystem is an example. > > > > Do you care to elaborate? > > Three quarters of the IIO drivers are I2C and SPI drivers, and thus not > > subject to the above. > > It seems I missed that you are talking about platform device drivers. OK. > In any case it's not true. We have the platform drivers w/o legacy > users that are not dependent on OF. Example? ;-) > They may _indirectly_ be dependent, but this is fine as I stated above > when suggested to move ACPI dependency on ARCH_xxx level. As per the response from the driver maintainer https://lore.kernel.org/linux-arm-kernel/bd8db435-24e1-5ab3-6b35-1d4d8a292a7e@hisilicon.com/, there is no dependency on ARCH_HISI, so moving the ACPI dependency up won't help. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel